[Bug 31040] New: jsTree image being used outside of jsTree plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 Bug ID: 31040 Summary: jsTree image being used outside of jsTree plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 11873 Bug 11873 upgraded jsTree to the latest version, which included a change in the plugin's asset directory structure. Unfortunately this now highlights the fact that we were using one of jsTree's images for other aspects of the OPAC. For instance, the spinner image shown when search results show the "Searching OverDrive..." message. These images are now broken. We don't need to depend on the plugin for this image, we have our "own" version. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 [Bug 11873] Upgrade jstree jQuery plugin to the latest version -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 136487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136487&action=edit Bug 31040: jsTree image being used outside of jsTree plugin This patch corrects OPAC templates which tried to use a jsTree image asset which is missing following the jsTree upgrade (see Bug 11873). Templates should use /images/spinner-small.gif instead. To test, apply the patch and enable OpenLibrarySearch and populate OverDrive and RecordedBooks preferences with credentials (they don't have to be valid). Perform a catalog search in the OPAC. When the search results page first loads you should see messages about the services being queried: Searching OpenLibrary... Searching RecordedBoks... Searching OverDrive... Each should show a working "spinner" image while the queries are being performed. If you have valid OverDrive credentials you can try clicking through to the OverDrive search results page to confirm that the image is working on that page too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136487|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 136512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136512&action=edit Bug 31040: jsTree image being used outside of jsTree plugin This patch corrects OPAC templates which tried to use a jsTree image asset which is missing following the jsTree upgrade (see Bug 11873). Templates should use /images/spinner-small.gif instead. To test, apply the patch and enable OpenLibrarySearch and populate OverDrive and RecordedBooks preferences with credentials (they don't have to be valid). Perform a catalog search in the OPAC. When the search results page first loads you should see messages about the services being queried: Searching OpenLibrary... Searching RecordedBoks... Searching OverDrive... Each should show a working "spinner" image while the queries are being performed. If you have valid OverDrive credentials you can try clicking through to the OverDrive search results page to confirm that the image is working on that page too. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I don't have valid OverDrive credentials, so wasn't able to test accessing the search results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136512|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137047&action=edit Bug 31040: jsTree image being used outside of jsTree plugin This patch corrects OPAC templates which tried to use a jsTree image asset which is missing following the jsTree upgrade (see Bug 11873). Templates should use /images/spinner-small.gif instead. To test, apply the patch and enable OpenLibrarySearch and populate OverDrive and RecordedBooks preferences with credentials (they don't have to be valid). Perform a catalog search in the OPAC. When the search results page first loads you should see messages about the services being queried: Searching OpenLibrary... Searching RecordedBoks... Searching OverDrive... Each should show a working "spinner" image while the queries are being performed. If you have valid OverDrive credentials you can try clicking through to the OverDrive search results page to confirm that the image is working on that page too. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes OPAC templates release notes| |which had a missing | |"spinner" image when | |queries were being | |performed (such as for | |OpenLibrary, RecordedBooks, | |and OverDrive). Previously, | |they were using an image | |from the jsTree plugin - | |this was upgraded (see bug | |11873), and the plugin's | |folder structure was | |changed. Templates now use | |/images/spinner-small.gif | |instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org