[Bug 18982] New: selenium tests needs too many prerequisites
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 Bug ID: 18982 Summary: selenium tests needs too many prerequisites Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 18804 The script must create the default data to avoid the tests to fail. For instance itemtypes.rentalcharge must be 0, a default circ rule must exist. Let's create these data. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 [Bug 18804] Selenium tests are failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65261&action=edit Bug 18982: Use KOHA_INTRANET_URL instead of syspref staffClientBaseURL That way we do not need to set the syspref, we can define it setting an env var, like other tests. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65262&action=edit Bug 18982: category.categorycode must be uppercase Otherwise it is not selected in the dropdown list and the patron created does not belong to this category Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65263&action=edit Bug 18982: Create a specific itemtype for these tests No need to require rentalcharge=0 for all itemtypes, we create our own. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65264&action=edit Bug 18982: Create a circ rule for the data we created No need to have a default circ cule, we create one for the categorycode and itemtype we are going to use. The 3 checkouts will not be rejected (5 are allowed) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Skipping SO & QA, they are needed to make Jenkins happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Attachment #65261|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65262|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65263|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65264|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 65268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65268&action=edit Bug 18982: Use KOHA_INTRANET_URL instead of syspref staffClientBaseURL That way we do not need to set the syspref, we can define it setting an env var, like other tests. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Andrei <acovaliov@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 65269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65269&action=edit Bug 18982: category.categorycode must be uppercase Otherwise it is not selected in the dropdown list and the patron created does not belong to this category Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Andrei <acovaliov@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 65270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65270&action=edit Bug 18982: Create a specific itemtype for these tests No need to require rentalcharge=0 for all itemtypes, we create our own. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Andrei <acovaliov@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 65271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65271&action=edit Bug 18982: Create a circ rule for the data we created No need to have a default circ cule, we create one for the categorycode and itemtype we are going to use. The 3 checkouts will not be rejected (5 are allowed) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Andrei <acovaliov@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65282&action=edit Bug 18982: Remove data in the correct order To respect FK Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The last patch has been pushed to master for 17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I installed the module, but still seeing: ok 1 # skip Selenium::Remote::Driver is needed for selenium tests These patches have been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, 16.11.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #14)
Hm, I installed the module, but still seeing: ok 1 # skip Selenium::Remote::Driver is needed for selenium tests
What returns `pmversion Selenium::Remote::Driver`? You could also try to remove the eval in the SKIP block to know what is the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #17 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.16 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org