[Bug 38093] New: Bundles: Add MARC link options should also add a link in 462
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Bug ID: 38093 Summary: Bundles: Add MARC link options should also add a link in 462 Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37710 [Bug 37710] Remove the marc link when removing an item from a bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Bundle implementation in Bug 37996 does not implement marc representation of the relation between bundles and items they contain. Bug 29560 creates a link (773 in MARC21, 461 in UNIMARC) from the item in the bundle to the bundle itself. We also should also add a MARC link from the bundle to the item contained in the dedicated field (774 in MARC21, 462 in UNIMARC). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 172395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172395&action=edit Bug 38093: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 172396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172396&action=edit Bug 38093: Bundles: Add MARC link options should also add a link in 462 Bundle implementation in Bug 37996 does not implement marc representation of the relation between bundles and items they contain. Bug 29560 creates a link (773 in MARC21, 461 in UNIMARC) from the item in the bundle to the bundle itself. We also should also add a MARC link from the bundle to the item contained in the dedicated field (774 in MARC21, 462 in UNIMARC). TEST PLAN: 1 - Apply patches 2 - Create a bundle item (cf after for more info on this step if you are unfamiliar with bundles) 3 - Click on "manage bundle", fill with an existing barcode, click on Add marc link 4 - Click on MARC -> tab 7 (on marc21) and tab 4 on unimarc -> there should be a link in field 733 (marc21) or 462 (unimarc) 5 - Go back to the bundle and remove the item from the bundle. 6 - Click again on MARC -> precedent fields should now be empty Create a bundle : 1 - Create a new biblio/Edit an existing one, edit the field 000, the field 7 must be set to c-Collection. 2 - Go on the biblio and create a new item attached to the biblio 3 - You should see an icon "Manage bundle" on the item created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 172397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172397&action=edit Bug 38093: Bundles: Remove the link created in 462 when removing from the bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Thibault Keromnès <thibault.keromnes@univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibault.keromnes@univ-pari | |s8.fr Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Thibault Keromnès <thibault.keromnes@univ-paris8.fr> --- Tried both on KTD and a sandbox, ending with the same error : error: sha1 information is lacking or useless (Koha/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 38093: Bundles: Remove the link created in 462 when removing from the bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172396|0 |1 is obsolete| | --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 177573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177573&action=edit Bug 38093: Bundles: Add MARC link options should also add a link in 462 Bundle implementation in Bug 37996 does not implement marc representation of the relation between bundles and items they contain. Bug 29560 creates a link (773 in MARC21, 461 in UNIMARC) from the item in the bundle to the bundle itself. We also should also add a MARC link from the bundle to the item contained in the dedicated field (774 in MARC21, 462 in UNIMARC). TEST PLAN: 1 - Apply patches 2 - Create a bundle item (cf after for more info on this step if you are unfamiliar with bundles) 3 - Click on "manage bundle", fill with an existing barcode, click on Add marc link 4 - Click on MARC -> tab 7 (on marc21) and tab 4 on unimarc -> there should be a link in field 733 (marc21) or 462 (unimarc) 5 - Go back to the bundle and remove the item from the bundle. 6 - Click again on MARC -> precedent fields should now be empty Create a bundle : 1 - Create a new biblio/Edit an existing one, edit the field 000, the field 7 must be set to c-Collection. 2 - Go on the biblio and create a new item attached to the biblio 3 - You should see an icon "Manage bundle" on the item created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172397|0 |1 is obsolete| | --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 177574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177574&action=edit Bug 38093: Bundles: Remove the link created in 462 when removing from the bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- blocked: following dependencies leads Bug 37996 If I understand correctly, it shouldn't be in the need signoff queue because changes to Bug 37996 would likely invalidate testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |In Discussion CC| |arthur.suzuki@biblibre.com --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hi Victor, I've made some work to get things moving, I think this patch can no longer be considered as "BLOCKED" since the patch it was relying upon has been resolved as duplicate. I've removed the dependency to the duplicate and with minor changes to previous patches was able to apply that one. There is a small typo in the first patch which should be fixed this way : <pre> kohadev-koha@kohadevbox:koha(malles)$ git diff diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm index d8e378f47e4..579027d1b9b 100644 --- a/Koha/Biblio.pm +++ b/Koha/Biblio.pm @@ -2220,7 +2220,7 @@ sub link_marc_bundled_item { if ( ref( $params->{bundled_item} ) eq 'Koha::Item' ) { $bundled_item = $params->{bundled_item}; } else { - my $bundled_item = Koha::Items->find( $params->{host} ); + my $bundled_item = Koha::Items->find( $params->{bundled_item} ); } my $record = $self->metadata->record; </pre> Also the test plan has another typo (says 733 in step 4, it should be 774). Test plan may also document that 774 subfields 0,9 and t should be configured in the marc framework, and systempreference "EasyAnalyticalRecords" set to 1. Otherwise it may not work. I'm setting this patch to In Discussion because it needs some changes which I need to discuss a bit further with BibLibre's colleagues before submitting. Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 190961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190961&action=edit Bug 38093: Bundles: (QA follow-up) fix small error in parameter name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41535 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41535 [Bug 41535] UNIMARC fields used for Bundles are wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- This patch set is ready for signoff! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is at the end of quite a dependency tree in various states of testing. I think because of the ongoing work on these, it's currently not applying: Error: Apply failed: Cannot apply cleanly patches from bug 37710. Everything will be left dirty. Git command (git am -3 /tmp/oIZi3mtxMy/0001-190957.patch) failed: error: sha1 information is lacking or useless (t/db_dependent/Koha/Biblio.t). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172395|0 |1 is obsolete| | Attachment #177573|0 |1 is obsolete| | Attachment #177574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207738&action=edit Bug 38093: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 --- Comment #14 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207739&action=edit Bug 38093: Bundles: Add MARC link options should also add a link in 462 Bundle implementation in Bug 37996 does not implement marc representation of the relation between bundles and items they contain. Bug 29560 creates a link (773 in MARC21, 461 in UNIMARC) from the item in the bundle to the bundle itself. We also should also add a MARC link from the bundle to the item contained in the dedicated field (774 in MARC21, 462 in UNIMARC). TEST PLAN: 1 - Apply patches 2 - Create a bundle item (cf after for more info on this step if you are unfamiliar with bundles) 3 - Click on "manage bundle", fill with an existing barcode, click on Add marc link 4 - Click on MARC -> tab 7 (on marc21) and tab 4 on unimarc -> there should be a link in field 733 (marc21) or 462 (unimarc) 5 - Go back to the bundle and remove the item from the bundle. 6 - Click again on MARC -> precedent fields should now be empty Create a bundle : 1 - Create a new biblio/Edit an existing one, edit the field 000, the field 7 must be set to c-Collection. 2 - Go on the biblio and create a new item attached to the biblio 3 - You should see an icon "Manage bundle" on the item created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207740&action=edit Bug 38093: Bundles: Remove the link created in 462 when removing from the bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Comment on attachment 190961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190961 Bug 38093: Bundles: (QA follow-up) fix small error in parameter name
From 1ebe991d4527af39799928a82361ad533a2245b2 Mon Sep 17 00:00:00 2001 From: Arthur Suzuki <arthur.suzuki@biblibre.com> Date: Tue, 6 Jan 2026 20:46:21 +0000 Subject: [PATCH] Bug 38093: Bundles: (QA follow-up) fix small error in parameter name
--- Koha/Biblio.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm index d8e378f47e4..32d62048ef1 100644 --- a/Koha/Biblio.pm +++ b/Koha/Biblio.pm @@ -2171,7 +2171,6 @@ sub unlink_marc_host { C4::Biblio::ModBiblio( $record, $self->biblionumber ); }
- =head3 link_marc_host
$biblio->link_marc_host({ field => $link_field}); @@ -2220,11 +2219,12 @@ sub link_marc_bundled_item { if ( ref( $params->{bundled_item} ) eq 'Koha::Item' ) { $bundled_item = $params->{bundled_item}; } else { - my $bundled_item = Koha::Items->find( $params->{host} ); + my $bundled_item = Koha::Items->find( $params->{bundled_item} ); }
my $record = $self->metadata->record; my $tag = C4::Context->preference('marcflavour') eq 'UNIMARC' ? '462' : '774'; + # Remove fields that references the same itemnumber # to avoid duplicates my @fields = $record->field($tag); -- 2.39.5
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38093 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190961|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org