[Bug 14795] New: Batch record modification tool removes framework code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Bug ID: 14795 Summary: Batch record modification tool removes framework code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: pablo.bianchi@gmail.com QA Contact: testopia@bugs.koha-community.org Steps: - Create any template on Tools > Manage MARC modification templates - Go to Tools > Batch record modification - Apply modification to any biblionumber you choose. Result: The process removes frameworkcode, so Default framework is use. On MySQL table the column for eg changes from frameworkcode="BKS" to frameworkcode="". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Severity|normal |major --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This a major one and blocker for the 3.22 release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Status|NEW |ASSIGNED Depends on| |11395 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Actually it's in 3.20.x already, so raising again the severity. Lost of data possible! Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 [Bug 11395] Batch modifications for records -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ccing Chris as 3.20.x RM -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44849&action=edit Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44849|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44856&action=edit [SIGNED-OFF] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested framework is lost using tool without patch Problem gone with patch No qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44856|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44868&action=edit [PASSED QA] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested framework is lost using tool without patch Problem gone with patch No qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org