[Bug 19120] New: Order cancelled status is reset on basket open
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Bug ID: 19120 Summary: Order cancelled status is reset on basket open Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When a basket with a canceled order is opened again, the order status is changed to 'new'. See also bug 19024. To test: - Create a basket - Add orders to it - Cancel one of the orders - Close the basket - Check the status of your orders using the acquisition search, they should be ordered with the exception one being canceled - Open the basket again - Verify the order still shows as canceled - Leave the basket open and verify using the acquisition search, that the status of the canceled order is now 'new'. A canceled order status should always remain as canceled until we introduce an actual feature to reactivate canceled orders. Closing and reopening the basket should have no effect on the status of canceled orders. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19024 CC| |colin.campbell@ptfs-europe. | |com, | |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 66786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66786&action=edit Bug 19120: Add tests to reproduce the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS! -- This proves the test works. 3) run koha qa test tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 66787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66787&action=edit Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66786|0 |1 is obsolete| | --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 66908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66908&action=edit Bug 19120: Add tests to reproduce the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS! -- This proves the test works. 3) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66787|0 |1 is obsolete| | --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 66909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66909&action=edit Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 17172 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66908|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 67436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67436&action=edit Bug 19120: Add tests to reproduce the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS! -- This proves the test works. 3) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66909|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 67437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67437&action=edit Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org