[Bug 30454] New: Convert holds awaiting pickup tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 Bug ID: 30454 Summary: Convert holds awaiting pickup tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the holds awaiting pickup template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132956&action=edit Bug 30454: Convert holds awaiting pickup tabs to Bootstrap This patch updates the holds awaiting pickup page to replace jQueryUI tabs with Bootstrap tabs. A minor JavaScript change is required to work with the new HTML structure. To test you should have multiple holds for one library: Some which are waiting for less than the number of days specified in ReservesMaxPickUpDelay, some which are waiting longer. - Apply the patch and go to Circulation -> Holds awaiting pickup. - You should see two tabs: "Holds waiting" and "Holds waiting over..." - Confirm that the tabs look correct and work correctly. - Confirm that the "Cancel selected" buttons work correctly under each tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132956|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133483&action=edit Bug 30454: Convert holds awaiting pickup tabs to Bootstrap This patch updates the holds awaiting pickup page to replace jQueryUI tabs with Bootstrap tabs. A minor JavaScript change is required to work with the new HTML structure. To test you should have multiple holds for one library: Some which are waiting for less than the number of days specified in ReservesMaxPickUpDelay, some which are waiting longer. - Apply the patch and go to Circulation -> Holds awaiting pickup. - You should see two tabs: "Holds waiting" and "Holds waiting over..." - Confirm that the tabs look correct and work correctly. - Confirm that the "Cancel selected" buttons work correctly under each tab. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks great and works as expected.. being bold and going straight for QA again here. QA scripts are happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org