[Bug 11481] New: new reservation syspref HoldOnlyWhenAllItemsOnLoan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Bug ID: 11481 Summary: new reservation syspref HoldOnlyWhenAllItemsOnLoan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org This new syspref sets the following behavior about reserves : When enabled, placing hold is possible only if all the items potentially holdable of a record are on loan. By "potentially holdable", we mean these which can be reserved according to circulation rules and have neither notforloan, withdrawn, lost, nor damaged status. Test Plan : 1) Enable RequestOnOpac and HoldOnlyWhenAllItemsOnLoan sysprefs 2) Choose one borrower (patron1) to place holds : get his category, login and pasword. 3) Go to Administration/Circulation and fine rules. 4) in the ALL libraries table (selected by default) set a circulation rule for the borrower category adding an amount of holds in "Holds allowed" column For a beginning , you can set only one rule with itemtype as All or several rules with different item type. 5) In the pro interface, choose a record with some items : you can choose a notforloan status for one, set an itemtype with a circ rule without holds allowed for another etc. 6) Check out on your count as much items of this record as it's possible. Do not forget to change branch to checkout the items from their homebranch. 7) go to opac and search for the detailed record 8) You do not see the Place hold button yet : you must first authenticate yourself as patron1 to make it appear. Then you can pursue the Placing hold process as usual. 9) reconnect as admin and go to pro interface , search for the detailed record 10) click the Holds tab and enter patron1 in text box 11) the usual form appears : you can choose there the pickup location and select a specific item in the items table. 12) Now, check in one of the items and go back to opac detailed record 13) Even if you are already authentified (as patron1), the "Place hold" icon is no more visible (hold is no more possible) 14) reconnect as admin and go back in the pro interface to the detailed record 15) Enter patron1 again in patron textbox : the "Cannot place hold message" displayed with the following explanation : "All reservable items of the record must be on loan" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |koha@univ-lyon3.fr Assignee|oleonard@myacpl.org |koha@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 23974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23974&action=edit Bug-11481-HoldOnlyWhenAllItemsOnLoan-new-syspref.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11482 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Aurélie Fichot <aurelie.fichot@iepg.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aurelie.fichot@iepg.fr --- Comment #2 from Aurélie Fichot <aurelie.fichot@iepg.fr> --- I do the test plan but I always see the Place hold button... :-(((( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23974|0 |1 is obsolete| | --- Comment #3 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 24397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24397&action=edit Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref "Place hold" button works now as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #4 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- <h1>Something went wrong !</h1>Applying: Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Reserves.pm Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging opac/opac-detail.pl Auto-merging reserve/request.pl Failed to merge in the changes. Patch failed at 0001 Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11481 - new reservation syspref HoldOnlyWhenAllItemsOnLoan 24397 - Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24397|0 |1 is obsolete| | --- Comment #5 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 26112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26112&action=edit Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref patch rebased -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 michot <nmichot@voila.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nmichot@voila.fr --- Comment #6 from michot <nmichot@voila.fr> --- Tests done today on sandbox : It seems Ok when there is only one item type on the the same record : 1 item available + 1 item on a notforloan statu = Opac : no hold button (when patron is authentificated) = Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds ») 1 item On loan + 1 item on a notforloan statu = Opac : hold button (when patron is authentificated) = Staff : hold OK 1 item available + 1 item on a notforloan statu + 1 item lost = Opac : no hold button (when patron is authentificated) = Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds ») 1 item on a notforloan statu + 1 item lost = Opac : no hold button (when patron is authentificated) = Staff : No alert message ( with possibility to overstep) 1 item available in another library + 1 item on a notforloan statu = Opac : no hold button (when patron is authentificated) = Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds ») 1 item available in transfer + 1 item on a notforloan statu = Opac : no hold button (when patron is authentificated) = Staff : Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds ») When there is 2 different itemtypes on the same record, one of which with a circ rule without holds allowed : - 1 item available (with holds allowed) + 1 item available (with NO holds allowed) = Opac : no hold button (when patron is authentificated) = Staff : 2 Alert messages( with possibility to overstep) : one with wrong text « Cannot place hold : to many holds ») + one with good text « All reservable items of the record must be on loan » - 1 item on loan (with holds allowed) + 1 item available (with NO holds allowed) = Opac : no hold button (when patron is authentificated) ERROR : patron could hold cause the only item hold allowed is on loan = Staff : 2 Alert messages( with possibility to overstep) : one with wrong text « Cannot place hold : to many holds ») + one with good text « All reservable items of the record must be on loan » Conclusion : we don't sign off because of the last case -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- (In reply to michot from comment #6)
Tests done today on sandbox :
It seems Ok when there is only one item type on the the same record :
1 item available + 1 item on a notforloan statu = Opac : no hold button (when patron is authentificated) = Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds »)
1 item On loan + 1 item on a notforloan statu = Opac : hold button (when patron is authentificated) = Staff : hold OK
1 item available + 1 item on a notforloan statu + 1 item lost = Opac : no hold button (when patron is authentificated) = Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds »)
1 item on a notforloan statu + 1 item lost = Opac : no hold button (when patron is authentificated) = Staff : No alert message ( with possibility to overstep)
1 item available in another library + 1 item on a notforloan statu = Opac : no hold button (when patron is authentificated) = Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds »)
1 item available in transfer + 1 item on a notforloan statu = Opac : no hold button (when patron is authentificated) = Staff : Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds »)
When there is 2 different itemtypes on the same record, one of which with a circ rule without holds allowed : - 1 item available (with holds allowed) + 1 item available (with NO holds allowed) = Opac : no hold button (when patron is authentificated) = Staff : 2 Alert messages( with possibility to overstep) : one with wrong text « Cannot place hold : to many holds ») + one with good text « All reservable items of the record must be on loan »
- 1 item on loan (with holds allowed) + 1 item available (with NO holds allowed) = Opac : no hold button (when patron is authentificated) ERROR : patron could hold cause the only item hold allowed is on loan = Staff : 2 Alert messages( with possibility to overstep) : one with wrong text « Cannot place hold : to many holds ») + one with good text « All reservable items of the record must be on loan »
Conclusion : we don't sign off because of the last case
Can you give more details about the hold rules (hold for all libraries, ( rule for a specific library, hold policy for such library, holds policy by item ? ) and the level of itype (syspref item-level_itypes) you applied for your test because I don't get this error in my tests. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 --- Comment #8 from michot <nmichot@voila.fr> --- Sorry but I don't accede to any sandbox, so i can't look at the rules -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED --- Comment #9 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I drop this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9190 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org