[Bug 23396] New: Rancor fails to load: insert_copyright is not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Bug ID: 23396 Summary: Rancor fails to load: insert_copyright is not defined Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: carnold@dgiinc.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 91854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91854&action=edit Screenshot from Chrome The Advanced Editor fails to load on 19.05 with the error message: marc-editor.js:140 Uncaught ReferenceError: insert_copyright is not defined at marc-editor.js:140 at Object.execCb (require_19.0502000.js:29) at X.check (require_19.0502000.js:18) at X.<anonymous> (require_19.0502000.js:23) at require_19.0502000.js:8 at require_19.0502000.js:23 at y (require_19.0502000.js:7) at X.emit (require_19.0502000.js:23) at X.check (require_19.0502000.js:19) at X.<anonymous> (require_19.0502000.js:23) used Chrome and Firefox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Installation and upgrade | |(web-based installer) --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This bug only happened for me when starting with a blank database. I tested with 16.11.x and 18.11.x databases and didn't get the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91873&action=edit Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm To test: 1 - Back up your DB if you want to save it 2 - sudo koha-mysql kohadev DROP database koha_kohadev; CREATE database koha_kohadev; 3 - http://localhost:8081 4 - Go through the web installer 5 - Enable AdvancedCatalogingEditor 6 - Try to load it, fails with JS console error: insert_copyright is not defined 7 - Apply patch 8 - Repeat 9 - This time editor loads -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91873|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91886&action=edit Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm To test: 1 - Back up your DB if you want to save it 2 - sudo koha-mysql kohadev DROP database koha_kohadev; CREATE database koha_kohadev; 3 - http://localhost:8081 4 - Go through the web installer 5 - Enable AdvancedCatalogingEditor 6 - Try to load it, fails with JS console error: insert_copyright is not defined 7 - Apply patch 8 - Repeat 9 - This time editor loads Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we add an update database entry to fix this for existing installations? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #4)
Should we add an update database entry to fix this for existing installations?
I think we should. We already got people installing 19.05 for production use and we could just repeat the initial database update from introducing the feature with a check for data already being there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91886|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91937&action=edit Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm To test: 1 - Back up your DB if you want to save it 2 - sudo koha-mysql kohadev DROP database koha_kohadev; CREATE database koha_kohadev; 3 - http://localhost:8081 4 - Go through the web installer 5 - Enable AdvancedCatalogingEditor 6 - Try to load it, fails with JS console error: insert_copyright is not defined 7 - Apply patch 8 - Repeat 9 - This time editor loads Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91938&action=edit Bug 23396: (QA follow-up) Add atomic update New installs before the fix won't have the table populated, this patch adds a fix for that, including the shortcut added by bug 17178. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Depends on| |21411, 17178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 Since Bug 17178 is not in 19.05.x I have added a commit : Bug 23396: (19.05.x) remove toggle_keyboard comming from Bug 17178 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org