https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 143367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143367&action=edit Bug 32121: Show an alert when adding a checked out item to an item bundle When trying to add a checked out item to an item bundle, an alert message will show up, giving the user a chance to return the item immediately before adding it to the bundle Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Create a biblio with one item and check out this item. 3. Try to add the checked out item to the bundle You should see a message saying that the item is checked out. Next to this message should be a button "Check in and add to bundle". 4. Click on the button. There should be a message saying that the item was added to the bundle. 5. Close the modal window and verify that the item was correctly returned and added to the bundle -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Bug 32121 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146018&action=edit Bug 32121: (QA follow-up) Use error_code rather than key We semi-recently introduced error_code into our error object to allow for translation and code paths for different errors without having to rely on long description string matches. This QA follow-up converts the existing match and new 'key' fields introduced in this patchset to use the updated 'error_code' key. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry I didn't spot this earlier.. great piece of functionality; Had to do a minor rebase to get it to apply clean, nothing too scary. I added a follow-up to convert from 'key' to 'error_code' as that's the direction we're headed I believe. I also far prefer your construction of the result alerts.. makes my code look very amateurish! Regarding choice of 409 vs 400 i'm never sure which to use.. perhaps 409 for 'resolvable conflicts' that trigger the option to resend with a condition and 400 for unresolvable one's where we show a harder error and no inline resolution option? Finally.. tests.. I think we perhaps need some API tests to prevent regressions from creeping in with your addition of a new param on the endpoint?.. I'll leave that one for the QA person. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 [Bug 32802] Bundle handling JS should be moved to an asset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33025 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33025 [Bug 33025] Show an alert when adding a lost item to an item bundle -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146017|0 |1 is obsolete| | Attachment #146018|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148659&action=edit Bug 32121: Show an alert when adding a checked out item to an item bundle When trying to add a checked out item to an item bundle, an alert message will show up, giving the user a chance to return the item immediately before adding it to the bundle Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Create a biblio with one item and check out this item. 3. Try to add the checked out item to the bundle You should see a message saying that the item is checked out. Next to this message should be a button "Check in and add to bundle". 4. Click on the button. There should be a message saying that the item was added to the bundle. 5. Close the modal window and verify that the item was correctly returned and added to the bundle Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148659|0 |1 is obsolete| | Attachment #148660|0 |1 is obsolete| | Attachment #148664|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148667&action=edit Bug 32121: Show an alert when adding a checked out item to an item bundle When trying to add a checked out item to an item bundle, an alert message will show up, giving the user a chance to return the item immediately before adding it to the bundle Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Create a biblio with one item and check out this item. 3. Try to add the checked out item to the bundle You should see a message saying that the item is checked out. Next to this message should be a button "Check in and add to bundle". 4. Click on the button. There should be a message saying that the item was added to the bundle. 5. Close the modal window and verify that the item was correctly returned and added to the bundle Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148669&action=edit Bug 32121: (QA follow-up): Fix unit tests count Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33447 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 [Bug 33447] Add caching to Biblio->pickup_locations -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We've opted to upgrade this to bugfix and backport it now (some parts of it are needed for subsequent bugfixes that we want) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #14 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.