https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 122059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122059&action=edit Bug 28584: Remove hyphens from EAN when adding new record Add functionality to TransformMarcToKoha so that hyphens are removed from biblioitem tables "ean" column but EAN value in MARC record is not touched. To test: 1. Apply patch. 2. Create new record with EAN field(s) having hyphen(s) e.g. 74628-8972 3. Check records MARC details => EAN has hyphen 4. Check record from biblioitem table in database => EAN doesn't have hyphen(s) Prove t/db_dependent/Biblio/TransfornMarcToKoha.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Magnus Enger from comment #2)

But see the discussion on bug 6590. The conclusion there was to not remove the hyphens, I think.

I understood it only applied to ISBN and ISSN. Also from that bug comment 15 says:

In UNIMARC, ISBN field is supposed to contain ISBN as written on the book cover. ISBN without hyphens can be stored in EAN (073) field.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 --- Comment #5 from e.betemps <e.betemps@gmail.com> --- I'm sorry but I tested once again today and it doesn't work. The first test I did was on February the 4th, at noon. - when I ran the sandbox, Kyle M Hall's comment wasn't here - when I signed-off, I saw his comment I don't know what patch I used for my first test. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 --- Comment #7 from e.betemps <e.betemps@gmail.com> --- I followed the test plan : create a notice with values (with hyphen) in 073a I see the hyphen in the Mark preview (it's ok) but I also see it in my report (which displays the column 'ean' of the table 'biblioitems') -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130159|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130670&action=edit Bug 28584: Remove hyphens from EAN when adding new record Add functionality to TransformMarcToKoha so that hyphens are removed from biblioitem tables "ean" column but EAN value in MARC record is not touched. To test: 1. Apply patch. 2. Create new record with EAN field(s) having hyphen(s) e.g. 74628-8972 3. Check records MARC details => EAN has hyphen 4. Check record from biblioitem table in database => EAN doesn't have hyphen(s) Prove t/db_dependent/Biblio/TransfornMarcToKoha.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emmi, you said you use the EAN for matching so I wonder if removing the hyphen from the database column, but not from the MARC record will work? Could you explain your use case a little more? Right now this patch makes me a little uneasy as I feel like the information in the database and in the MARC record should match and this is an automatism that the library won't be able to control. In MARC21 024 is used to store EAN, but also a lot of other identifiers depending on indicator and $2: 024 - Other Standard Identifier (R) https://www.loc.gov/marc/bibliographic/bd024.html 0 - International Standard Recording Code 1 - Universal Product Code 2 - International Standard Music Number 3 - International Article Number 4 - Serial Item and Contribution Identifier 7 - Source specified in subfield $2 Source of the number or code is specified in subfield $2 (Source of number or code). 8 - Unspecified type of standard number or code So by doing this silently, we'll also be doing it for all of those numbers, some of which we can't tell what they might be ($2) -- You are receiving this mail because: You are watching all bug changes.