[Bug 33606] New: Access to ERM requires parameters => 'manage_sysprefs'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Bug ID: 33606 Summary: Access to ERM requires parameters => 'manage_sysprefs' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Since bug 33408 we are fetching sysprefs from svc/config/systempreferences, but this script requires parameters => 'manage_sysprefs' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 [Bug 33408] Fetch sysprefs from svc/config/systempreferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Severity|major |blocker Keywords| |rel_23_05_candidate --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is blocker for 23.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32968 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 [Bug 32968] Create granular permissions for ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32968 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 [Bug 32968] Create granular permissions for ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150204&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This looks like a reasonably approach to me.. very minor wonder if whether the path is right.. /erm/config or whether it should be more generalised as /config/erm or /config?module=erm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- On other minor wonder.. should we perhaps add a 'type' key.. so denote the config content type (yaml, csv, string etc).. Would that help in future for parsing the various different content we have in sysprefs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I feel like we either (a) refactor everything and do server-side rendering as we do now with Template::Toolkit, or (b) provide a way to fetch the module configuration, as the patch proposes. I think (a) is not doable or worth. So I pick (b). I generally agree with an endpoint like /config/:module_name for retrieving things. I'd prefer we come up with something more generic than just passing the allow-listed sysprefs. We could talk about allowed-to-use features like: { features: { packages: [ add, update, delete, list ] } } If we look at our current approach (C4::Auth) it is easy to spot that we also add information about the permissions the current user has (CAN_<permission>). I'm not sure about the data structure. We should just copy what other projects do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Example found in the wild: https://www.permify.co/post/implementing-role-based-access-control-in-vue-js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #6)
Example found in the wild:
https://www.permify.co/post/implementing-role-based-access-control-in-vue-js
Yes but this is "user.json", we are not going into that direction (and I don't think we should). Or maybe we should, but then we remove the 'config' idea and build a big structure with everything for every modules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- https://irc.koha-community.org/koha/2023-05-09#i_2485635 """ it could certainly be /config/erm i.e. constrained to specific modules and instead of exposing the sysprefs list enabled modules or components in terms of your solution, it is just a matter of naming things more generically, and consistently """ Please be explicit, I don't understand. I am exposing ERMModule and ERMProviders. Why should I make the code obscure and hide that behind an other config key? Having the syspref names in tt/vue to grep make things easy. If it's really important for you, I am suggesting /config/erm { enabled => 1|0, providers => ['local', 'ebsco'], } For now. Then we will add the permission list later (for bug 32968), and it could be something like: { enabled => 1|0, providers => ['local', 'ebsco'], permissions => ['agreements.write', 'eholdings.write'], etc. } Would that work for everybody? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think the user/permissions/permify approach is best left to bug 32986. We're mixing requirements here. As for configuration keys themselves.. I'm more torn now.. I can see both sides.. it's really nice to have consistency.. but should that consistency be permission names being consistent across DB/Controller/API/TT vs consistenct between different API endpoints. I like Jonathans suggestion (without permissions added).. but at the same time I can see as we move to more and more vue in the client we may just want to look cross module for preferences and then the overlapping keys could get confusing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- How about `/configurations` or `/settings` that returns an array of key:value pair objects... [ { 'ERMModule': true }, { 'ERMProviders': [ 'A', 'B', 'C' ] } ] and we could allow searching on key.. Or perhaps [ { id: 'ERMModule', value: true } { id: 'ERMProviders', value: [ 'A', 'B', 'C' ] } ] What's going to be easiest to use from code whilst also being easy to filter in the API? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Clearly different preferences have different security concerns.. perhaps we'd need a new field in the perferences table to denote 'public', 'staff', 'internal' or something to allow things like API keys to require a higher privilege to see on the API? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150204|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151276&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151277&action=edit Bug 33606: Mark the endpoint as experimental -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151276|0 |1 is obsolete| | Attachment #151277|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151333&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151334&action=edit Bug 33606: Mark the endpoint as experimental -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151333|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151350&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151334|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151351&action=edit Bug 33606: Mark the endpoint as experimental Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151352&action=edit Bug 33606: Fix settings Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32971 --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This fixes the issue. A non-superlibrarian user no longer requires parameters => 'manage_sysprefs' to properly access ERM, although the issues in bug 32971 remain. I want to come up with a better long-term solution but I can't think of one that doesn't imply rearranging how we handle permissions at a core level. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | Severity|blocker |major --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Removed from 23.05.00 blocker list, too late. Not a good idea to push such changes on release day... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - description: This resource returns a list of options needed for the ERM Vue app + description: This resource returns a list of options needed for the ERM Vue app. EXPERIMENTAL - DO NOT RELY on this, it is subject to change! Shouldnt we just extend this list and not change the two entries we just added? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151350|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152614&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151351|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152615&action=edit Bug 33606: Mark the endpoint as experimental Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151352|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152616&action=edit Bug 33606: Fix settings Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152617&action=edit Bug 33606: (QA follow-up) Cosmetic changes Even the POD name wasnt changed after copying :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Sorry... Please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152614|0 |1 is obsolete| | Attachment #152615|0 |1 is obsolete| | Attachment #152616|0 |1 is obsolete| | Attachment #152617|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153001&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153002&action=edit Bug 33606: Mark the endpoint as experimental Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153003&action=edit Bug 33606: Fix settings Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153004&action=edit Bug 33606: (QA follow-up) Cosmetic changes Even the POD name wasnt changed after copying :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 [Bug 33169] Improve vue breadcrumbs and left-hand menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Requires bug 33169 awaiting news there before pushing to 23.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #33 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Could this be backported to 22.11.xx? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Hi Laura, this will be backported to 22.11.x but not before it goes into 23.05. There's a bit of follow-up work needed for 33169 as well which is a dependency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 34830 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Frido, ping! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #37 from Fridolin Somers <fridolin.somers@biblibre.com> --- I propose to try this after this month imminent release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like one bug i fixes is that only superlibrarians can use the ERM in 23.05 right now (see bug 34830) - Are you worried about the size? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #39 from Fridolin Somers <fridolin.somers@biblibre.com> --- I would need advice on backport of 33169 since it contains FA 6 parts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #1)
This is blocker for 23.05
Love that comment, 2023-04-25... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #39)
I would need advice on backport of 33169 since it contains FA 6 parts
I pushed a branch to my repo, with 33169+33606. It should be tested. I've noticed some icons missing. I won't have more time (actually the energy) to spent in this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #41)
(In reply to Fridolin Somers from comment #39)
I would need advice on backport of 33169 since it contains FA 6 parts
I pushed a branch to my repo, with 33169+33606. It should be tested. I've noticed some icons missing.
I won't have more time (actually the energy) to spent in this.
https://gitlab.com/joubu/Koha/-/commits/bug_33606-23.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we have this backported now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #43)
Can we have this backported now?
Without this the ERM module is not usable in 23.05 - what is needed to resolve this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #44)
(In reply to Katrin Fischer from comment #43)
Can we have this backported now?
Without this the ERM module is not usable in 23.05 - what is needed to resolve this?
Test the branch I provided? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am going to test the 23.05 branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Why is there no test plan on this bug report? * Checked out the remote branch https://gitlab.com/joubu/Koha/-/commits/bug_33606-23.05 * Rebased on latest 23.05.x * yarn build & restart_all * ERMModule, ERMProviders EBSCO and Local activated * As superlibrarian * Verified all pages are accessible and look as expected * Fixed missing FA icons in navigation (see follow-up) * Create a user with limited permissions: only ERM, catatalogue On accessing the ERM module I see: Something went wrong: Error: Authorization failure. Missing required permission(s). * Added borrowers permission: same error * Added manage_sysprefs: same error I don't know if I tested wrong or if this needs more work. I'll attach my follow up patch for the icons to bug 33169. Jonathan, maybe you could add it to the branch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #47)
Why is there no test plan on this bug report?
* Checked out the remote branch https://gitlab.com/joubu/Koha/-/commits/bug_33606-23.05 * Rebased on latest 23.05.x * yarn build & restart_all * ERMModule, ERMProviders EBSCO and Local activated * As superlibrarian * Verified all pages are accessible and look as expected * Fixed missing FA icons in navigation (see follow-up) * Create a user with limited permissions: only ERM, catatalogue On accessing the ERM module I see: Something went wrong: Error: Authorization failure. Missing required permission(s). * Added borrowers permission: same error * Added manage_sysprefs: same error
I don't know if I tested wrong or if this needs more work. I'll attach my follow up patch for the icons to bug 33169. Jonathan, maybe you could add it to the branch?
It's getting 403 on /vendors. Add permission acquisition: vendors_manage. If you think it's a bug, open a separate bug report ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #49 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #48)
(In reply to Katrin Fischer from comment #47)
Why is there no test plan on this bug report?
* Checked out the remote branch https://gitlab.com/joubu/Koha/-/commits/bug_33606-23.05 * Rebased on latest 23.05.x * yarn build & restart_all * ERMModule, ERMProviders EBSCO and Local activated * As superlibrarian * Verified all pages are accessible and look as expected * Fixed missing FA icons in navigation (see follow-up) * Create a user with limited permissions: only ERM, catatalogue On accessing the ERM module I see: Something went wrong: Error: Authorization failure. Missing required permission(s). * Added borrowers permission: same error * Added manage_sysprefs: same error
I don't know if I tested wrong or if this needs more work. I'll attach my follow up patch for the icons to bug 33169. Jonathan, maybe you could add it to the branch?
It's getting 403 on /vendors. Add permission acquisition: vendors_manage. If you think it's a bug, open a separate bug report ;)
ie. certainly the same behaviour on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #49)
(In reply to Jonathan Druart from comment #48)
(In reply to Katrin Fischer from comment #47)
Why is there no test plan on this bug report?
* Checked out the remote branch https://gitlab.com/joubu/Koha/-/commits/bug_33606-23.05 * Rebased on latest 23.05.x * yarn build & restart_all * ERMModule, ERMProviders EBSCO and Local activated * As superlibrarian * Verified all pages are accessible and look as expected * Fixed missing FA icons in navigation (see follow-up) * Create a user with limited permissions: only ERM, catatalogue On accessing the ERM module I see: Something went wrong: Error: Authorization failure. Missing required permission(s). * Added borrowers permission: same error * Added manage_sysprefs: same error
I don't know if I tested wrong or if this needs more work. I'll attach my follow up patch for the icons to bug 33169. Jonathan, maybe you could add it to the branch?
It's getting 403 on /vendors. Add permission acquisition: vendors_manage. If you think it's a bug, open a separate bug report ;)
ie. certainly the same behaviour on master.
It's bug 32971. But I think vendor_manage is much better than needing manage_sysprefs. Adding vendor_manage fixed my problems and now my 'permission restricted' user can use the ERM module. How should we proceed, do you want to add my follow-up to your branch? Or should I try and attach the patch sets for 23.05 to both bugs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #51 from Fridolin Somers <fridolin.somers@biblibre.com> --- I think I get it. I've picked from branch https://gitlab.com/joubu/Koha/-/commits/bug_33606-23.05 : b702d1c6e7 Bug 33606: (QA follow-up) Cosmetic changes e89d5599e0 Bug 33606: Fix settings d0c2829f10 Bug 33606: Mark the endpoint as experimental 5078f9f4df Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app Display looks ok with superlibrarian and user with catalog+erm+vendor_manage Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #52 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks again for everyone helping ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #53 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Bug 33606 depends on bug 33169, which changed state. Bug 33169 Summary: Improve vue breadcrumbs and left-hand menu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42845 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org