[Bug 23479] New: Hold cancellation confirmation too generic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Bug ID: 23479 Summary: Hold cancellation confirmation too generic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The cancellation confirmation should include the item title and the name of the person the hold was for. It is too easy to click on the wrong cancel button, and there is no knowing if you clicked the right one. We should not only be confirming the cancel action, but the data that is being cancelled. This goes for all types of confirmations throughout Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 23815 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andriiverem@gmail.com Assignee|koha-bugs@lists.koha-commun |andriiverem@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 --- Comment #2 from Andrii Veremeienko <andriiverem@gmail.com> --- Created attachment 125991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125991&action=edit Bug 23479: Hold cancellation confirmation too generic Solution was to specify patron's name in format "<patron.firstname> <patron.surname> (<patron.cardnumber>)" and biblio's title in the hold cancellation message. e.g.: "Are you sure you want to cancel hold of Охрана окружающей среды в републике Беларусь for John Doe (12)?" How to test: 1. Go to the item search; 2. Search for the book you want to place hold for; 3. Select existing patron to place hold for him; 4. Place hold; 5. Go to koha/reserve/request.pl; 6. Click on "Cancel hold" button for hold from the list (red X icon on the grid); 7. Observe that text displayed on cancellation modal window contains patron's name and biblio's title; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- I would test, but there are not any sandboxes working any longer! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125991|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 125993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125993&action=edit Bug 23479: Hold cancellation confirmation too generic Solution was to specify patron's name in format "<patron.firstname> <patron.surname> (<patron.cardnumber>)" and biblio's title in the hold cancellation message. e.g.: "Are you sure you want to cancel hold of Охрана окружающей среды в републике Беларусь for John Doe (12)?" How to test: 1. Go to the item search; 2. Search for the book you want to place hold for; 3. Select existing patron to place hold for him; 4. Place hold; 5. Go to koha/reserve/request.pl; 6. Click on "Cancel hold" button for hold from the list (red X icon on the grid); 7. Observe that text displayed on cancellation modal window contains patron's name and biblio's title; Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |title and patron details to | |the confirmation message | |when cancelling a hold. | | | |For example: "Are you sure | |you want to cancel hold of | |Intermediate Perl / for | |Mary Burton | |(23529000651225)?" (title | |and patron are in bold) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 --- Comment #5 from David Nind <david@davidnind.com> --- Minor suggestion for the message - change "of" to "on". Example: Are you sure you want to cancel hold on Intermediate Perl / for Mary Burton (23529000651225)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but besides the small change David pointed out, there are a couple of smaller issues here: $("#cancellation-text").html(`Are you sure you want to cancel hold of <b>${biblio_title}</b> for <b>${borrower_name}</b>?`); At the moment, this message is not translatable. Please have a look at how to use _() to make sure that the strings are picked up for translation by our tools. the <b> mark-up is also not recommended as this will break the strings into pieces and leaves you with a single "for" to translate. That is really hard to get right without further context (at least in German it is :) ). Better to not highlight single parts of sentences like this. I believe we did have a rule about quotes... but I cannot find it :( The rule I remember was to use double quotes around JS, as languages like French need to be able to use single quotes in their translations and single quotes often broke things for them as for the translators it's not obvious when they are translating JS and need to escape. Please let me know if we can help you making these adjustments! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125993|0 |1 is obsolete| | --- Comment #7 from Andrii Veremeienko <andriiverem@gmail.com> --- Created attachment 126986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126986&action=edit Bug 23479: Hold cancellation confirmation too generic Solution was to specify patron's name in format <patron.firstname> <patron.surname> (<patron.cardnumber>)" and biblio's title in the hold cancellation message. e.g.: 'Are you sure you want to cancel hold of "Охрана окружающей среды в републике Беларусь" for "John Doe (12)"?' How to test: 1. Go to the item search; 2. Search for the book you want to place hold for; 3. Select existing patron to place hold for him; 4. Place hold; 5. Go to koha/reserve/request.pl; 6. Click on "Cancel hold" button for hold from the list (red X icon on the grid); 7. Observe that text displayed on cancellation modal window is very general and doesn't contains patron's name and biblio's title; 8. Apply patch; 9. Go through steps 1-6; 10. Observe that cancellation text contains patron's name and biblio's title; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #8 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 127003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127003&action=edit Title is missing from modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- The title is missing from the modal. See screenshot. Set to Failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- Works! I restarted services and refreshed schema after loading patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 127004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127004&action=edit Title IS showing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126986|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 127005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127005&action=edit Bug 23479: Hold cancellation confirmation too generic Solution was to specify patron's name in format <patron.firstname> <patron.surname> (<patron.cardnumber>)" and biblio's title in the hold cancellation message. e.g.: 'Are you sure you want to cancel hold of "Охрана окружающей среды в републике Беларусь" for "John Doe (12)"?' How to test: 1. Go to the item search; 2. Search for the book you want to place hold for; 3. Select existing patron to place hold for him; 4. Place hold; 5. Go to koha/reserve/request.pl; 6. Click on "Cancel hold" button for hold from the list (red X icon on the grid); 7. Observe that text displayed on cancellation modal window is very general and doesn't contains patron's name and biblio's title; 8. Apply patch; 9. Go through steps 1-6; 10. Observe that cancellation text contains patron's name and biblio's title; Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127005|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 127006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127006&action=edit Bug 23479: Hold cancellation confirmation too generic Solution was to specify patron's name in format <patron.firstname> <patron.surname> (<patron.cardnumber>)" and biblio's title in the hold cancellation message. e.g.: 'Are you sure you want to cancel hold of "Охрана окружающей среды в републике Беларусь" for "John Doe (12)"?' How to test: 1. Go to the item search; 2. Search for the book you want to place hold for; 3. Select existing patron to place hold for him; 4. Place hold; 5. Go to koha/reserve/request.pl; 6. Click on "Cancel hold" button for hold from the list (red X icon on the grid); 7. Observe that text displayed on cancellation modal window is very general and doesn't contains patron's name and biblio's title; 8. Apply patch; 9. Go through steps 1-6; 10. Observe that cancellation text contains patron's name and biblio's title; Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Christopher Brannon <cbrannon@cdalibrary.org> --- Maybe consider having title and name bold or stylized like other alerts for consistancy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 --- Comment #15 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Confirmed that title IS showing. I like the idea of making title and name bold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Barbara Johnson from comment #15)
Confirmed that title IS showing. I like the idea of making title and name bold.
It's just really bad for translations because we end up with single words like "for" that can have a multiple of meanings/translations in other languages. Using styling on single words "breaks" sentences into pieces right now. I am open for better solutions that keep things in context for translations while preserving the styling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but there is a little issue here. Maybe some variables are not reset? - Place multiple holds for different patrons on a record - Click on the X to cancel a single hold, verify the question has the correct information and abort with cancel. - Use the checkboxes to mark multiple holds for cancelling - Use the "Cancel selected" button - The confirmation will still ask about cancelling the hold for the perevious user, although you are cancelling multiple for different users. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org