http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13601 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7899 Blocks| |12072 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #2 from Marc Véron <veron@veron.ch> --- Note: Patch "Bug 13813 - Remove deprecated C4::Dates from opac/opac-showreviews.pl" does not depend from Bug 13601 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 36829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36829&action=edit Bug 13813 - Remove C4::Dates from C4/Items.pm This patch removes depraceted C4::Dates from C4/Items.pm To test: Apply patch To test: Add modify items. Checkout added item. Verify that item handling works as before. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 36831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36831&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 36835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36835&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from Koha/Borrower/Files.pm To test: Apply patch Make sure that uploading arbitrary files for a patron works as before (Set syspref EnableBorrowerFiles for testing ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 36839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36839&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from Koha/Misc/Files.pm To test: Apply patch Make sure that C4::Dates is not used in the code Set syspref AcqEnableFiles to enable Go to Home > Acquisitions > Invoices Find an invoice, go to Details, Manage Invoice files, make sure that uploading / displaying files works as before -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13601 --- Comment #12 from Marc Véron <veron@veron.ch> --- Note: Previous patches are independent from each other. More patches to come will need changes to Koha/DateUtils.pm (reason for dependency form Bug 13601 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36828|0 |1 is obsolete| | --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 36851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36851&action=edit Bug 13813 - Remove C4::Dates from members/readingrec.pl This patch removes depraceted C4::Dates from members/readingrec.pl To test: Apply patch Go to a patron's cirulation history Verify that circulation history behaves as before. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36829|0 |1 is obsolete| | --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 36857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36857&action=edit Bug 13813 - Remove C4::Dates from C4/Items.pm This patch removes depraceted C4::Dates from C4/Items.pm To test: Apply patch To test: Add modify items. Checkout added item. Verify that item handling works as before. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36850|0 |1 is obsolete| | --- Comment #18 from Marc Véron <veron@veron.ch> --- Created attachment 36859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36859&action=edit Bug 13813 - Remove C4::Dates from C4/Members.pm This patch removes C4::Dates from C4/Members.pm Note: This patch can be tested independently from other patches in this Bug, but it depends on patches from Bug 13601 To test: Make sure that patches from 13601 are applied Apply patch Check changes in code Make sure that following functionality works as before: - Add a patron - Renew patrons - Go to checkout page and create message for patron -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #20 from Marc Véron <veron@veron.ch> --- Created attachment 36863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36863&action=edit Bug 13813 - Remove C4::Dates from C4/Barcodes/hbyymmincr.pm To test: Set syspref autoBarcode to <branchcode>yymm0001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #22 from Marc Véron <veron@veron.ch> --- Created attachment 36865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36865&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from C4/Biblio.pm To test: Apply patch Verify that C4::Dates is not used in code. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #24 from Marc Véron <veron@veron.ch> --- Created attachment 36871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36871&action=edit Bug 13813 - Remove C4::Dates from C4/NewsChannels.pm To test: Apply patch Create some news for OPAC and staff client (Home > Tools > News) Verify that dates appear as appropriate Verify that Publicaten Date (Creation Date) and Expiration Date work as expected. Note: Inconsistency in wording for creation date / publication date should be managed in separate Bug 13834 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #26 from Marc Véron <veron@veron.ch> --- Created attachment 36878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36878&action=edit Bug 13813 - Remove C4::Dates from C4/Suggestions.pm To test: Apply patch Go to Home > Acquisitions > Suggestions management Verify in "Filter by" that filter works for Suggestion information / dates -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #28 from Marc Véron <veron@veron.ch> --- Created attachment 36880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36880&action=edit Bug 13813 - Remove C4::Dates from members/printinvoice.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a transaction Verify that the date displays correctly on the invoice. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #30 from Marc Véron <veron@veron.ch> --- Created attachment 36882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36882&action=edit Bug 13813 - Remove C4::Dates from circ/bookcount.pl To test: Apply patch Search a biblio with items that are or have been checked out Go to "Items" (moredetail.pl) Locate "Total checkouts" of an item and click 'View item's checkout hsitory' Verify date and time in column "Last seen" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #32 from Marc Véron <veron@veron.ch> --- Created attachment 36884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36884&action=edit Bug 13813 - Remove C4::Dates from members/guarantor_search.pl To test: Edit a patron's detail Add or modify guarantor information Do a search in popup "Search for guarantor" Verify that dates ob birth display correctly in list -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #34 from Marc Véron <veron@veron.ch> --- Created attachment 36886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36886&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-messaging.pl To test: Apply patch Verify that C4::Dates is not used in code -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #36 from Marc Véron <veron@veron.ch> --- Created attachment 36888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36888&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-ratings.pl To test: Apply patch Verify that C4::Dates is not used in code -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36889|0 |1 is obsolete| | --- Comment #38 from Marc Véron <veron@veron.ch> --- Created attachment 36890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36890&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-search-history.pl To test: Apply patch Verify that C4::Dates is not used in code Enable display of search history in OPAC (syspref EnableOpacSearchHistory) Diesplay search history in OPAC, should behave as before -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #40 from Marc Véron <veron@veron.ch> --- Created attachment 36893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36893&action=edit Bug 13813 - Remove C4::Dates from patroncards/members-search.pl To test: Apply patch In staffclient go to Home > Tools > Patron card creator Create new batch or edit existing one Click button "Add Item(s)and perform a search in pop-up "Patron search" (patroncards/members-search.pl) Verify that dates in column "Expires on" display correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #42 from Marc Véron <veron@veron.ch> --- Created attachment 36895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36895&action=edit Bug 13813 - Remove C4::Dates from circ/waitingreserves.pl To test: Go to Home > Circulation > Holds awaiting pickup (Circulation Rports - Holds awaiting pickup) Verify that date in page title appears correcty -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #44 from Marc Véron <veron@veron.ch> --- Created attachment 36897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36897&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode.pl To test: Set syspref autoBarcode to <year>-001, <year>-002 and <branchcode>yymm001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #46 from Marc Véron <veron@veron.ch> --- Created attachment 36899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36899&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/dateaccessioned.pl To test: Apply patch Edit an item Verifiy that autofilling date in d - Date acquired works as before. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36890|0 |1 is obsolete| | --- Comment #48 from Marc Véron <veron@veron.ch> --- Created attachment 36901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36901&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-search-history.pl To test: Apply patch Verify that C4::Dates is not used in code Go to ome > Tools > Logs Display logs with from and to dates Verify that search range behaves as expected. ' (Note: In table 'XXXX lines found', date and time always appear as timestamp as before) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36884|0 |1 is obsolete| | --- Comment #51 from Marc Véron <veron@veron.ch> --- Comment on attachment 36884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36884 Bug 13813 - Remove C4::Dates from members/guarantor_search.pl Obsoleted because no longer necessary. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37227|0 |1 is obsolete| | --- Comment #53 from Marc Véron <veron@veron.ch> --- Comment on attachment 37227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37227 Bug 13813 - Remove C4::Dates from reserve/request.pl Obsoleted because of merge conflicts. Will add new patch later. /MV -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #55 from Jonathan Druart <jonathan.druart@biblibre.com> --- Minor since I suppose it existed before: FAIL cataloguing/value_builder/dateaccessioned.pl FAIL forbidden patterns forbidden pattern: tab char (line 54) FAIL members/moremember.pl FAIL forbidden patterns forbidden pattern: tab char (line 136) FAIL C4/Barcodes/hbyymmincr.pm FAIL forbidden patterns forbidden pattern: tab char (line 76) forbidden pattern: tab char (line 106) FAIL C4/Barcodes/annual.pm FAIL forbidden patterns forbidden pattern: tab char (line 84) forbidden pattern: tab char (line 63) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 46) forbidden pattern: tab char (line 52) FAIL C4/Items.pm FAIL forbidden patterns forbidden pattern: trailing space char (line 650) FAIL members/readingrec.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 81) Could you explain why you replaced - my $rsstimestamp = C4::Dates->new($result->{datereviewed},"iso"); - my $rsstimestamp_output = $rsstimestamp->output("rfc822"); - $result->{timestamp} = $rsstimestamp_output; + $result->{timestamp} = strftime("%Y-%m-%dT%H:%M:%S-00:00", gmtime); and - $datereceived = C4::Dates->output('iso') unless $datereceived; + $datereceived = output_pref({ dt=>DateTime->now(), dateonly=>1, otputpref=>'iso' }) unless $datereceived; I would use Koha::DateUtils everywhere. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36831|0 |1 is obsolete| | --- Comment #61 from Marc Véron <veron@veron.ch> --- Created attachment 37730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37730&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat) / MV -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37730|0 |1 is obsolete| | --- Comment #63 from Marc Véron <veron@veron.ch> --- Created attachment 37732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37732&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), See comment #57 / MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37730|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37736|0 |1 is obsolete| | --- Comment #66 from Marc Véron <veron@veron.ch> --- Created attachment 37737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37737&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), see comment #57/ MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36898|0 |1 is obsolete| | --- Comment #68 from Marc Véron <veron@veron.ch> --- Created attachment 37748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37748&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode_manual.pl To test: Apply patch Set the plugin for 952$p (or UNIMARC equivalent to items.barcode) for one of your frameworks to barcode_manual.pl instead of barcode.pl Set syspref autoBarcode to <year>-001, <year>-002 and <branchcode>yymm001 Edit items or add item, verify that barcodes are filled in as appropriate by clicking on the value builder link (...) (Note: Description of barcode_manual.pl in Bug 8524) Amended following comment #58 /MV -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36855|0 |1 is obsolete| | --- Comment #70 from Marc Véron <veron@veron.ch> --- Created attachment 37753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37753&action=edit Bug 13813 - Remove C4::Dates from members/readingrec.pl This patch removes depraceted C4::Dates from members/readingrec.pl To test: Apply patch Go to a patron's cirulation history Verify that circulation history behaves as before. Amended following comment #58 /MV -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36859|0 |1 is obsolete| | --- Comment #72 from Marc Véron <veron@veron.ch> --- Created attachment 37757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37757&action=edit Bug 13813 - Remove C4::Dates from C4/Members.pm This patch removes C4::Dates from C4/Members.pm Note: This patch can be tested independently from other patches in this Bug, but it depends on patches from Bug 13601 To test: Make sure that patches from 13601 are applied Apply patch Check changes in code Make sure that following functionality works as before: - Add a patron - Renew patrons - Go to checkout page and create message for patron Amended following comment #58 / MV There is one more DateTime->now() left on line 1825, this is not related to my changes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36863|0 |1 is obsolete| | --- Comment #74 from Marc Véron <veron@veron.ch> --- Created attachment 37763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37763&action=edit Bug 13813 - Remove C4::Dates from C4/Barcodes/hbyymmincr.pm To test: Set syspref autoBarcode to <branchcode>yymm0001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 /mv -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36885|0 |1 is obsolete| | --- Comment #76 from Marc Véron <veron@veron.ch> --- Created attachment 37765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37765&action=edit Bug 13813 - Remove C4::Dates from members/moremember.pl To test: Apply patch Go to a patron's Details page (moremember.pl) Verify that dates display correctly (birth date, registration, espiration, manual restriction with date) Amended following comment #58 /mv -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36897|0 |1 is obsolete| | --- Comment #78 from Marc Véron <veron@veron.ch> --- Created attachment 37767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37767&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode.pl To test: Set syspref autoBarcode to <year>-001, <year>-002 and <branchcode>yymm001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 /mv -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37737|0 |1 is obsolete| | --- Comment #80 from Marc Véron <veron@veron.ch> --- Created attachment 37770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37770&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), see comment #57/ MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV Amended following comment #58 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #82 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37810&action=edit temporary tests Marc, If I am not wrong, these tests reflect what you are doing in the patches. If you have a look, you will see there are some mistakes. For instance output_pref( { dt => dt_from_string($iso), dateformat => 'iso', dateonly => 1 } ); won't return the same as C4::Dates->new( $iso, 'iso' )->output("iso"); But output_pref( { dt => dt_from_string({ dt => $iso, dateformat => 'iso' }), dateformat => 'iso', dateonly => 1 } ); will :) You should try to list exhaustively all existing patterns of C4::Dates you will replace and try to find their correct replacements. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37753|0 |1 is obsolete| | --- Comment #84 from Marc Véron <veron@veron.ch> --- Created attachment 37835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37835&action=edit Bug 13813 - Remove C4::Dates from members/readingrec.pl This patch removes depraceted C4::Dates from members/readingrec.pl To test: Apply patch Go to a patron's cirulation history Verify that circulation history behaves as before. Amended following comment #58 /MV Amended to fix output_pref (dateonly added) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37835|0 |1 is obsolete| | --- Comment #86 from Marc Véron <veron@veron.ch> --- Created attachment 37840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37840&action=edit Bug 13813 - Remove C4::Dates from members/readingrec.pl This patch removes depraceted C4::Dates from members/readingrec.pl To test: Apply patch Go to a patron's cirulation history Verify that circulation history behaves as before. Amended following comment #58 /MV Amended to fix output_pref (dateonly added) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37841|0 |1 is obsolete| | --- Comment #88 from Marc Véron <veron@veron.ch> --- Created attachment 37842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37842&action=edit Bug 13813 - Remove C4::Dates from members/printfeercpt.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a payment transaction ("Payment, thanks") Verify that the date displays correctly on the receipt. Amended for proper input for dt_from_string - (is 'iso') -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #90 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #82)

Created attachment 37810 [details] temporary tests

Marc, If I am not wrong, these tests reflect what you are doing in the patches. If you have a look, you will see there are some mistakes. (...) You should try to list exhaustively all existing patterns of C4::Dates you will replace and try to find their correct replacements.

Jonathan, Thank you very much for your help, your advice and for the idea with the test file. I used it as a base to go systematically through all attachments (and amended some of them). I tested the patches one by one in the staff client as well and hope now that this first patch set is really ready for sign-off. Marc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36827|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37853&action=edit Bug 13813 - Remove deprecated C4::Dates from opac/opac-showreviews.pl To test: This patch removes C4::Dates from opac/opac-showreviews.pl and treats the RSS time stamps the same way as in opac/opac-search.pl To test: - Enable display of 'Recent comments' in OPAC (Syspref OpacShowRecentComments) - In OPAC, go to Home > Recent comments - Test RSS feed - Apply patch - Test RSS feed again, it should work as before Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36835|0 |1 is obsolete| | --- Comment #96 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37855&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from Koha/Borrower/Files.pm To test: Apply patch Make sure that uploading arbitrary files for a patron works as before (Set syspref EnableBorrowerFiles for testing ) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36845|0 |1 is obsolete| | --- Comment #98 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37857&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from tags/list.pl To test: Apply patch Verify in code that C4::Dates is not necessary in tags/list.pl Set sysprefs to TagsEnabled and TagsModeration Got to Home > Tools > Tags In table of tags, click on a Term You should get a page Home > Tools > Tags > Results for [Term] Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36865|0 |1 is obsolete| | --- Comment #100 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37859&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from C4/Biblio.pm To test: Apply patch Verify that C4::Dates is not used in code. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36871|0 |1 is obsolete| | --- Comment #102 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37861&action=edit Bug 13813 - Remove C4::Dates from C4/NewsChannels.pm To test: Apply patch Create some news for OPAC and staff client (Home > Tools > News) Verify that dates appear as appropriate Verify that Publicaten Date (Creation Date) and Expiration Date work as expected. Note: Inconsistency in wording for creation date / publication date should be managed in separate Bug 13834 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36879|0 |1 is obsolete| | --- Comment #104 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37863&action=edit Bug 13813 - Remove C4::Dates from C4/VirtualShelves/Page.pm To test: Apply patch In staff client, go to Home > Lists Verify that list of lists displays as before In OPAC, go to Lists Verify that Public and Private Lists display as before Note: 'dateadded' is not displayed in lists of lists. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36883|0 |1 is obsolete| | --- Comment #106 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37865&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from members/notices.pl To test: Apply patch Verify that C4::Dates is not used in members/notices.pl Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36887|0 |1 is obsolete| | --- Comment #108 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37867&action=edit Remove superfluous use 'C4::Dates' from opac/opac-privacy.pl To test: Apply patch Verify that C4::Dates is not used in code http://bugs.koha-community.org/show_bug.cgi?id=13813 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36892|0 |1 is obsolete| | --- Comment #110 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37869&action=edit Bug 13813 - Remove C4::Dates from opac/opac-user.pl To test: Apply patch Manually restrict a patron (with end date) Check in to OPAC with this patron's username/password Verify that message about restrictions displays restriction date correctly in tab "Your summary" (opac-user.pl) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36901|0 |1 is obsolete| | --- Comment #112 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37871&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-search-history.pl To test: Apply patch Verify that C4::Dates is not used in code Go to ome > Tools > Logs Display logs with from and to dates Verify that search range behaves as expected. ' (Note: In table 'XXXX lines found', date and time always appear as timestamp as before) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37746|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37873&action=edit Bug 13813 - Remove C4::Dates from circ/circ/transferstoreceive.pl To test: Go to Home > Circulation > Transfers to your library (Circulation Reports - Transfers to receive) Verify that date in page title appears correcty Amendend following comment #58 /MV Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37749|0 |1 is obsolete| | --- Comment #116 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37875&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/dateaccessioned.pl To test: Apply patch Edit an item Verifiy that autofilling date in d - Date acquired works as before. Amended following comment #58 /MV Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37757|0 |1 is obsolete| | --- Comment #118 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37877&action=edit Bug 13813 - Remove C4::Dates from C4/Members.pm This patch removes C4::Dates from C4/Members.pm Note: This patch can be tested independently from other patches in this Bug, but it depends on patches from Bug 13601 To test: Make sure that patches from 13601 are applied Apply patch Check changes in code Make sure that following functionality works as before: - Add a patron - Renew patrons - Go to checkout page and create message for patron Amended following comment #58 / MV There is one more DateTime->now() left on line 1825, this is not related to my changes. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37763|0 |1 is obsolete| | --- Comment #120 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37879&action=edit Bug 13813 - Remove C4::Dates from C4/Barcodes/hbyymmincr.pm To test: Set syspref autoBarcode to <branchcode>yymm0001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 /mv Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37765|0 |1 is obsolete| | --- Comment #122 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37881&action=edit Bug 13813 - Remove C4::Dates from members/moremember.pl To test: Apply patch Go to a patron's Details page (moremember.pl) Verify that dates display correctly (birth date, registration, espiration, manual restriction with date) Amended following comment #58 /mv Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37768|0 |1 is obsolete| | --- Comment #124 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37883&action=edit Bug 13813 - Remove C4::Dates from PDF templates in acquisitions To test: Apply patch In Acquisitions, go to a vendor's "Basket grouping" Find a basket and print order Change PDF templates using syspref OrderPdfFormat and test for - English 2-page - English 3-page - French 3-page - German 2-page Amended following comment #58 /MV Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37828|0 |1 is obsolete| | --- Comment #126 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37885&action=edit Bug 13813 - Remove C4::Dates from circ/waitingreserves.pl To test: Go to Home > Circulation > Holds awaiting pickup (Circulation Rports - Holds awaiting pickup) Verify that date in page title appears correcty Amended following comment #58 Changed output_pref to format 'iso' Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37842|0 |1 is obsolete| | --- Comment #128 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37887&action=edit Bug 13813 - Remove C4::Dates from members/printfeercpt.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a payment transaction ("Payment, thanks") Verify that the date displays correctly on the receipt. Amended for proper input for dt_from_string - (is 'iso') Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #130 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37889&action=edit Bug 13813 - (follow-up) Remove C4::Dates from C4/Members.pm message_date_formatted is only used once in the template. Previous patch does not formatted correctly the date (was in iso). The easier for me was to use the KohaDates TT plugin Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #132 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37891&action=edit Bug 13813: Fix compilation errors Bareword "dt_from_string" not allowed while "strict subs" in use Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #136 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #135)

Something else: I did not try but... C4::Dates was (is) very efficient to format a date from an iso date. Now we have to call dt_from_string and output_pref. Maybe we should introduce a new subroutine without calls to DateTime to do this job.

% more t.pl use C4::Dates qw(format_date); my $iso_date = '2015-04-10 09:30:03'; for ( 1 .. 10000 ) { format_date($iso_date); } % time perl t.pl perl t.pl 0.78s user 0.01s system 99% cpu 0.795 total % time perl t.pl perl t.pl 0.74s user 0.01s system 99% cpu 0.749 total % time perl t.pl perl t.pl 0.71s user 0.02s system 99% cpu 0.735 total % more t.pl use Koha::DateUtils; my $iso_date = '2015-04-10 09:30:03'; for ( 1 .. 10000 ) { output_pref({ dt => dt_from_string( $iso_date, 'iso' ), dateonly => 1 }); } % time perl t.pl perl t.pl 2.40s user 0.02s system 100% cpu 2.424 total % time perl t.pl perl t.pl 2.42s user 0.02s system 99% cpu 2.442 total % time perl t.pl perl t.pl 2.43s user 0.01s system 100% cpu 2.439 total -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #138 from Marc Véron <veron@veron.ch> --- Patches still apply on current master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #140 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The number of patches this report touches does not justify the trivial patch status imo btw.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Large patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #144 from Marc Véron <veron@veron.ch> --- Still applies. Still blocks Bug 12072: New dateformat dd.mm.yyyy -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #146 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Marc: Why do you add MARC::Record in Acquisition.pm? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #148 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #146)

Marc: Why do you add MARC::Record in Acquisition.pm?

It's a bad merge conflict, in the local branch I have, there is only -use C4::Dates qw(format_date format_date_in_iso); use MARC::Record; Now there is use C4::Dates qw(format_date format_date_in_iso); +use MARC::Record; It should be -use C4::Dates qw(format_date format_date_in_iso); -use MARC::Record; :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #151 from Marc Véron <veron@veron.ch> --- Created attachment 42052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42052&action=edit Bug 13813 - [Follow-up] Remove C4::Dates from C4/Acquisition.pm Fix badly merged lines in C4/Acquisition.pm See comments #146-149 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #153 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marc Véron from comment #152)

Hi Marcel,

Thanks a lot for QAing. I really appreciate.

Question: Can we remove the 'problematic' patches from this huge patch set and then do a second round (maybe with a new bug number) after the 'unproblematic' patches have been pushed?

Marc

It seems to that your corrections should not be that hard or time consuming. I would favor to reduce the number of patches here. There is no particular need to add a patch for each module or script. But of course, I have no objection if you move some patches elsewhere. Please set back to SO if you are ready.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37887|0 |1 is obsolete| | --- Comment #155 from Marc Véron <veron@veron.ch> --- Comment on attachment 37887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37887 Bug 13813 - Remove C4::Dates from members/printfeercpt.pl Removed - will be done in "second round" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37864|0 |1 is obsolete| | --- Comment #157 from Marc Véron <veron@veron.ch> --- Comment on attachment 37864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37864 Bug 13813 - Remove C4::Dates from circ/bookcount.pl Removed - will be done in "second round" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37863|0 |1 is obsolete| | --- Comment #159 from Marc Véron <veron@veron.ch> --- Comment on attachment 37863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37863 Bug 13813 - Remove C4::Dates from C4/VirtualShelves/Page.pm Removed - Will be done in "second round" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37889|0 |1 is obsolete| | --- Comment #161 from Marc Véron <veron@veron.ch> --- Comment on attachment 37889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37889 Bug 13813 - (follow-up) Remove C4::Dates from C4/Members.pm Removed - will be done in "second round" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37888|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37854|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37860|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37871|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37886|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #163 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42274&action=edit Bug 13813: Remove deprecated module C4::Dates from system Test plan: See Bugzilla. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #165 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Second QA round: circ/transferstoreceive.pl - show_date => format_date(C4::Dates->today('iso')), + show_date => output_pref({ dt => dt_from_string, dateonly => 1 }), No iso? Probably I did not catch this one in the first round :) circ/waitingreserves.pl - show_date => format_date(C4::Dates->today('iso')), + show_date => output_pref({ dt => dt_from_string, dateonly => 1 }), Same. members/printinvoice.pl You did still include this line, as marked in the "first round". FQA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42274|0 |1 is obsolete| | --- Comment #167 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42292&action=edit Bug 13813: Remove deprecated module C4::Dates from system Test plan: See Bugzilla. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #169 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42294&action=edit Bug 13813: [QA Follow-up] Fix some tabs for qa tools FAIL C4/Barcodes/annual.pm FAIL forbidden patterns forbidden pattern: tab char (line 86) forbidden pattern: tab char (line 51) FAIL C4/Barcodes/hbyymmincr.pm FAIL forbidden patterns forbidden pattern: tab char (line 108) forbidden pattern: tab char (line 78) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14870 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14873 -- You are receiving this mail because: You are watching all bug changes.