http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12909 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31553|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31568&action=edit [SIGNED OFF] Bug 12913 - wrong inventory results when notforloan filter is not used In inventory tool, there is a test on scanned items notforloan value : if the value is not one of authorized values, the inventory results displays the problem "Change item status". The bug is that if notforloan filter is not used, the notforloan values array is not filled and so all scanned items are marked with this problem. Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Check the authorized value category has at least value '0' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' and notforloan=9 - Delete new value created above, for example '9' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZZ' - Check 'Compare barcodes list to results' - Submit => without patch, you get 2 results with problem 'Change item status' even for item with notforloan=0 => with patch, you get 1 result with 'Change item status' on item with notforloan=9 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I haven't tried the patch, but at a glance it might be trying to fix the wrong part of inventory.pl. This is the section of code that probably needs to be changed: # If we have scanned items with a non-matching notforloan value if (none { $item->{'notforloancode'} eq $_ } @notforloans) { $item->{problem} = 'changestatus'; push @items_with_problems, { %$item }; } If you're not using the "Not for loans" filter, @notforloans should be empty. Likewise, if your item isn't "Not for loan", $item->{'notforloancode'} should be false. Thus, this if statement should always be true if you're not using "Not for loans" and the item is not not for loan (ie is available). So I think all we need here is to wrap this with a "if (@notforloans)" test. I might take a look at this after I finish filing another Inventory bug report... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #5 from Marc Véron <veron@veron.ch> --- Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes.