[Bug 12802] New: Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Bug ID: 12802 Summary: Sent notices using several email addresses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org At the moment, the only place where a library can sent several emails to 1 patron is the overdue_notices.pl script. The mechanism will be extended to all notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31058&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31059&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9043 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch depends on bug 9043 for the multiple-select jQuery plugin (multivalued syspref). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31132&action=edit Bug 12802: FIX use the first valid email address if noemail is needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Koha Team AMU <koha.aixmarseille@gmail.com> --- This patch doesn't apply in a sandbox : The sandbox you've requested is not ready. Some problems occurred applying patches from bug 12802: <h1>Something went wrong !</h1>Applying: Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 12802 - Sent notices using several email addresses 31058 - Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress 31059 - Bug 12802: Sent notices using several email addresses 31132 - Bug 12802: FIX use the first valid email address if noemail is needed Apply? [(y)es, (n)o, (i)nteractive] Patch left in tmpBug-12802-DB-changes---Set-type-multiple-for-AutoE-2MpQeS.patch . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31058|0 |1 is obsolete| | Attachment #31059|0 |1 is obsolete| | Attachment #31132|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31382&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31383&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31384&action=edit Bug 12802: FIX use the first valid email address if noemail is needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Koha Team AMU from comment #5)
This patch doesn't apply in a sandbox :
These patches depend on another bug report. Moreover the sandboxes don't have cronjobs defined, so it's not possible to test notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31833&action=edit Bug 12802: Fix call in C4::Letters Reproduce on a production server (perl 5.10), not on my local instance (perl 5.18). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch set needs more work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31382|0 |1 is obsolete| | Attachment #31383|0 |1 is obsolete| | Attachment #31384|0 |1 is obsolete| | Attachment #31833|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33864&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33865&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33866&action=edit Bug 12802: FIX use the first valid email address if noemail is needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33867&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch set fixes conflicts with bug 9530. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #17 from Brendan Gallagher <brendan@bywatersolutions.com> --- Jonathan - I got a merge CONFLICT on the updatedatabase.pl part. After I fix the updatedatabase.pl part - I git-bz apply --continue and get this.. Auto-merging t/db_dependent/Members.t CONFLICT (content): Merge conflict in t/db_dependent/Members.t Auto-merging t/db_dependent/Letters.t Auto-merging opac/opac-shareshelf.pl Auto-merging opac/opac-memberentry.pl Auto-merging misc/cronjobs/overdue_notices.pl Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Auto-merging C4/Message.pm CONFLICT (content): Merge conflict in C4/Message.pm Auto-merging C4/Members.pm Auto-merging C4/Letters.pm Can you rebase for me? Send me IRC ping (or @later) and I will test once you have rebased. *Also note I do see the depends on 9043. But 9043 is already pushed to master ( so I think I don't need to also include 9043 patch - that is correct right? ) Let me know if I am wrong here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33864|0 |1 is obsolete| | Attachment #33865|0 |1 is obsolete| | Attachment #33866|0 |1 is obsolete| | Attachment #33867|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35890&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35891&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35892&action=edit Bug 12802: FIX use the first valid email address if noemail is needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35893&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Brendan Gallagher from comment #17)
Jonathan - Can you rebase for me? Send me IRC ping (or @later) and I will test once you have rebased.
Done :)
*Also note I do see the depends on 9043. But 9043 is already pushed to master ( so I think I don't need to also include 9043 patch - that is correct right? ) Let me know if I am wrong here.
Yes, if it is pushed to master, don't care of the dependency. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Brendan Gallagher <brendan@bywatersolutions.com> --- Hello Jonathan I run this through the qa script and find errors. Global symbol "$to_address" requires explicit package name BEGIN failed--compilation aborted Compilation failed in require That happens in multiple spots. I did remember to run updatadatebase and I have all dependencies. If this is something that I don't have right - just let me know. Thanks, Brendan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35890|0 |1 is obsolete| | Attachment #35891|0 |1 is obsolete| | Attachment #35892|0 |1 is obsolete| | Attachment #35893|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35926&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35927&action=edit Bug 12802: Sent notices using several email addresses -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35928&action=edit Bug 12802: FIX use the first valid email address if noemail is needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35929&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35930&action=edit Bug 12802: Fix QA script issues FAIL C4/Reserves.pm FAIL pod Spurious =cut command in file C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Brendan Gallagher from comment #23)
Hello Jonathan
I run this through the qa script and find errors.
Global symbol "$to_address" requires explicit package name BEGIN failed--compilation aborted Compilation failed in require
Sorry about that, I did not launch the qa script before submitting :-/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #30 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #29)
(In reply to Brendan Gallagher from comment #23)
Hello Jonathan
I run this through the qa script and find errors.
Global symbol "$to_address" requires explicit package name BEGIN failed--compilation aborted Compilation failed in require
Sorry about that, I did not launch the qa script before submitting :-/
Excellent - all pass now. Running some email tests tonight. Will not have time to finish. Since it is late enough, I was thinking I would set a cronjob to test that, since I will see result in the morning (10:30pm here now). -Brendan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35926|0 |1 is obsolete| | --- Comment #31 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36055&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35927|0 |1 is obsolete| | --- Comment #32 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36056&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35928|0 |1 is obsolete| | --- Comment #33 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36057&action=edit Bug 12802: FIX use the first valid email address if noemail is needed Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35929|0 |1 is obsolete| | --- Comment #34 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36058&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35930|0 |1 is obsolete| | --- Comment #35 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36059&action=edit Bug 12802: Fix QA script issues FAIL C4/Reserves.pm FAIL pod Spurious =cut command in file C4/Reserves.pm Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This seems to make some tests fail: t/db_dependent/Reserves.t: not ok 29 - patron notified when item set to waiting # Failed test 'patron notified when item set to waiting' # at t/db_dependent/Reserves.t line 348. # got: '4' # expected: '5' not ok 30 - patron not notified a second time (bug 11445) # Failed test 'patron not notified a second time (bug 11445)' # at t/db_dependent/Reserves.t line 353. # got: '4' # expected: '5' C4::Context->userenv not defined! at /home/katrin/kohaclone/C4/Items.pm line 2275. t/db_dependent/Letter.t: ok 69 - AutoEmailPrimaryAddress=OFF, EnqueueLetter used the patron email address if no to_address is given in parameter DBD::mysql::db selectcol_arrayref failed: Unknown column 'OFF' in 'field list' at /home/katrin/kohaclone/C4/Members.pm line 1569. DBD::mysql::db selectcol_arrayref failed: Unknown column 'OFF' in 'field list' at /home/katrin/kohaclone/C4/Members.pm line 1569. # Looks like you planned 76 tests but ran 69. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #37 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 39762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39762&action=edit Bug 12802: Fix tests in Letters.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #38 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 39770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39770&action=edit Bug 12802: EnqueueLetter must retrieve at least an email (for print messages). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #39 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- The two patches I've attached fix the tests in Letters.t and Reserves.t I'm putting this back in Signed Off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Matthias Meusburger from comment #38)
Created attachment 39770 [details] [review] Bug 12802: EnqueueLetter must retrieve at least an email (for print messages).
Could you explain this patch please? The tests pass without it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@biblibre.co |matthias.meusburger@biblibr |m |e.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #41 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Letters.t tests are ok without the patch, but Reserves.t are not. (cf http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802#c36 ). This is because when sending a print message, if the email address is not gathered, this loop in C4::Letters::EnqueueLetter is never entered: for my $to_address ( @to_addresses ) { $rs->create({ ... } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Matthias Meusburger from comment #41)
Letters.t tests are ok without the patch, but Reserves.t are not. (cf http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802#c36 ).
This is because when sending a print message, if the email address is not gathered, this loop in C4::Letters::EnqueueLetter is never entered:
for my $to_address ( @to_addresses ) { $rs->create({ ... }
The to_addresses should only be populated for email. Otherwise if the patron does not have an email defined, the print/sms/phone/whatever letters won't be sent. Actually there is something wrong, but it should be fixed cleanly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39770|0 |1 is obsolete| | --- Comment #43 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 40167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40167&action=edit Bug 12802: Fix tests in Reserves.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #44 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This new patch fixes the problem by making separate calls for email based messages and others. Altough not ideal, this is much cleaner than before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12532 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Conflicts in both first and second patch, please rebase! Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 12802: Sent notices using several email addresses Using index info to reconstruct a base tree... M C4/Branch.pm M C4/Letters.pm M C4/Members.pm M C4/Message.pm M C4/Reserves.pm M misc/cronjobs/overdue_notices.pl M opac/opac-memberentry.pl M opac/opac-shareshelf.pl M t/db_dependent/Letters.t M t/db_dependent/Members.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Members.t Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging opac/opac-shareshelf.pl Auto-merging opac/opac-memberentry.pl Auto-merging misc/cronjobs/overdue_notices.pl Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Auto-merging C4/Message.pm Auto-merging C4/Members.pm Auto-merging C4/Letters.pm Auto-merging C4/Branch.pm Failed to merge in the changes. Patch failed at 0001 Bug 12802: Sent notices using several email addresses The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12802-Sent-notices-using-several-email-address-C2M_Ge.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36055|0 |1 is obsolete| | --- Comment #46 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45476&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36056|0 |1 is obsolete| | --- Comment #47 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45477&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36057|0 |1 is obsolete| | --- Comment #48 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45478&action=edit Bug 12802: FIX use the first valid email address if noemail is needed Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36058|0 |1 is obsolete| | --- Comment #49 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45479&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36059|0 |1 is obsolete| | --- Comment #50 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45480&action=edit Bug 12802: Fix QA script issues FAIL C4/Reserves.pm FAIL pod Spurious =cut command in file C4/Reserves.pm Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39762|0 |1 is obsolete| | --- Comment #51 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45481&action=edit Bug 12802: Fix tests in Letters.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40167|0 |1 is obsolete| | --- Comment #52 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45482&action=edit Bug 12802: Fix tests in Reserves.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org