[Bug 17334] New: members-update.pl should show timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Bug ID: 17334 Summary: members-update.pl should show timestamp Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In the management of patron updates, it seems logical that the requests should show the timestamp of when the request was placed. Yes, you can look this up in a report, but this should be a basic feature of managing requests. Ideally, it should show on the same line as the patron name. Probably something like "Requested: 2016-09-05" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59297&action=edit Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Test plan: 1.Log into OPAC and click on Lists->Your Lists->your personal details 2. Change/add a value in that form 3. Select the 'Submit update request' 4. Log into the Koha staff interface, then go to the url: cgi-bin/koha/members/members-update.pl 5. You will see near the top of each box containing a pending request the following are displayed: surname, firstname, patron category, branch, and cardnumber but no timestamp. 6. Apply this patch 7. Repeat steps 1,2, 3, 4 8. You will now see timestamp in the format "Requested: YYYY-MM-DD HH:MM:SS" next to each patrons details near the top of each pending request box. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59297|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59379&action=edit [SIGNED-OFF] Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Test plan: 1.Log into OPAC and click on Lists->Your Lists->your personal details 2. Change/add a value in that form 3. Select the 'Submit update request' 4. Log into the Koha staff interface, then go to the url: cgi-bin/koha/members/members-update.pl 5. You will see near the top of each box containing a pending request the following are displayed: surname, firstname, patron category, branch, and cardnumber but no timestamp. 6. Apply this patch 7. Repeat steps 1,2, 3, 4 8. You will now see timestamp in the format "Requested: YYYY-MM-DD HH:MM:SS" next to each patrons details near the top of each pending request box. NOTE: TT variable is excessive. I'll let QA tweak. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (in reply to comment 2 by M.Tompsett) I have altered the formatting of the date so that it does not show time, i.e. it is displayed in the format: DD/MM/YY I assume this is what you were referring to when saying that TT variable was excessive? But before I attach my new commit to this bug, I would like to ask if you are happy with the time being displayed being the UTC rather than the localtime? The issue is that the timestamp of the member modification request is stored as UTC in the database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 59379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59379 [SIGNED-OFF] Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Review of attachment 59379: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17334&attachment=59379) ----------------------------------------------------------------- This is what I was talking about. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt @@ +79,4 @@
<div id="pending_updates"> [% FOREACH pm IN PendingModifications %] [% SET borrowernumber = pm.borrowernumber %] + [% SET timestamp = pm.timestamp %]
This is overkill, because... @@ +79,5 @@
<div id="pending_updates"> [% FOREACH pm IN PendingModifications %] [% SET borrowernumber = pm.borrowernumber %] + [% SET timestamp = pm.timestamp %] + <h3><a href="#panel_modify_[% pm.borrowernumber %]">[% borrowers.$borrowernumber.surname %][% IF ( borrowers.$borrowernumber.firstname ) %], [% borrowers.$borrowernumber.firstname %][% END %] - [% Categories.GetName( borrowers.$borrowernumber.categorycode ) %] ([% Branches.GetName( borrowers.$borrowernumber.branchcode ) %]) ([% borrowers.$borrowernumber.cardnumber %]) Requested: [% timestamp %]</a></h3>
You only use it here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Alex Buckley from comment #3)
But before I attach my new commit to this bug...
No need. Let QA do their job. If they are fine with it. Let it go. If not, they'll tweak it and push it through. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59379|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59574&action=edit Bug 17334: Format the date according to the system preference - Use KohaDates TT plugin to format the date correctly - Do not use a temporary variable - Replace: patron's info Requested: Datetime with patron's info - Requested on Datetime -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59574|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59575&action=edit Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Test plan: 1.Log into OPAC and click on Lists->Your Lists->your personal details 2. Change/add a value in that form 3. Select the 'Submit update request' 4. Log into the Koha staff interface, then go to the url: cgi-bin/koha/members/members-update.pl 5. You will see near the top of each box containing a pending request the following are displayed: surname, firstname, patron category, branch, and cardnumber but no timestamp. 6. Apply this patch 7. Repeat steps 1,2, 3, 4 8. You will now see timestamp in the format "Requested: YYYY-MM-DD HH:MM:SS" next to each patrons details near the top of each pending request box. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59576&action=edit Bug 17334: Format the date according to the system preference - Use KohaDates TT plugin to format the date correctly - Do not use a temporary variable - Replace: patron's info Requested: Datetime with patron's info - Requested on Datetime -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd like to get a signoff on the second patch. Is the display better? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59589&action=edit Bug 17334 - Second update following QA feedback This commit contains the following changes: 1. Implemented the use of KohaDates TT plugin to format the date correctly 2. Removed the use of the temporary timestamp variable 3. Changed the date text to: patron's info - Requested on Datetime -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (in reply to Jonathan Druart) Sorry I realised you have made all of the neccisary changes and so to remove my second patch ( Bug 17334 - Second update following QA feedback) can I just set it to obsolete? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I am still learning bugzilla and didn't realise your patch contained the necessary changes. so sorry about that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59576|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 59658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59658&action=edit [SIGNED-OFF] Bug 17334: Format the date according to the system preference - Use KohaDates TT plugin to format the date correctly - Do not use a temporary variable - Replace: patron's info Requested: Datetime with patron's info - Requested on Datetime Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59575|0 |1 is obsolete| | Attachment #59658|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59677&action=edit Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Test plan: 1.Log into OPAC and click on Lists->Your Lists->your personal details 2. Change/add a value in that form 3. Select the 'Submit update request' 4. Log into the Koha staff interface, then go to the url: cgi-bin/koha/members/members-update.pl 5. You will see near the top of each box containing a pending request the following are displayed: surname, firstname, patron category, branch, and cardnumber but no timestamp. 6. Apply this patch 7. Repeat steps 1,2, 3, 4 8. You will now see timestamp in the format "Requested: YYYY-MM-DD HH:MM:SS" next to each patrons details near the top of each pending request box. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59678&action=edit Bug 17334: Format the date according to the system preference - Use KohaDates TT plugin to format the date correctly - Do not use a temporary variable - Replace: patron's info Requested: Datetime with patron's info - Requested on Datetime Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #18 from Kelly McElligott <kelly@bywatersolutions.com> --- Could this be used when a Patron makes a purchase suggestion also? A library has mentioned that they would love to see the time in addition to the date on purchase suggestions made through the OPAC? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #19 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Kelly McElligott from comment #18)
Could this be used when a Patron makes a purchase suggestion also? A library has mentioned that they would love to see the time in addition to the date on purchase suggestions made through the OPAC?
Thanks!
That is a separate matter. A new bug should be submitted for that feature. :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org