[Bug 21505] New: Box around 'Additional fields' does not contain the fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Bug ID: 21505 Summary: Box around 'Additional fields' does not contain the fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Created attachment 80147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80147&action=edit Additional fields box When you have additional fields in your subscription, the 'Additional fields' title appears in a blue box, but the fields themselves are outside the box.(See attached screen capture) To reproduce: 1) Go to Serials 2) Click on 'Add subscription fields' 3) Click on 'New fields' 4) Fill in the form and click 'Save' 5) Search for a subscription 6) Click on the title to see the subscription detail page 7) In the 'Information' tab, there is the 'Additional fields' title in its box followed by the additional field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Maybe also change the 'New fields' for 'New field'. All the 'New ...' buttons are singular, and we only add one field at a time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Depends on| |21519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21519 [Bug 21519] Switch two-column templates to Bootstrap grid: Serials -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21519 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21519 [Bug 21519] Switch two-column templates to Bootstrap grid: Serials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21523 [Bug 21523] Switch two-column templates to Bootstrap grid: Serials part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80303&action=edit Bug 21505: Box around 'Additional fields' does not contain the fields This patch modifies the subscription detail page markup to eliminate a confusing bordered <legend> tag. It is replaced with an <hr> to delineate the sections and an <h3> tag to serve as the heading. To test, apply the patch and regenerate the staff client CSS. - Configure one or more additional subscription fields. - View the detail page for a subscription and confirm that the "Additional fields" section is clearly labeled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Caroline Cyr La Rose from comment #1)
Maybe also change the 'New fields' for 'New field'. All the 'New ...' buttons are singular, and we only add one field at a time.
I created Bug 21531 for this issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80303|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 80392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80392&action=edit Bug 21505: Box around 'Additional fields' does not contain the fields This patch modifies the subscription detail page markup to eliminate a confusing bordered <legend> tag. It is replaced with an <hr> to delineate the sections and an <h3> tag to serve as the heading. To test, apply the patch and regenerate the staff client CSS. - Configure one or more additional subscription fields. - View the detail page for a subscription and confirm that the "Additional fields" section is clearly labeled. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like this much better, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80392|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80423&action=edit Bug 21505: Box around 'Additional fields' does not contain the fields This patch modifies the subscription detail page markup to eliminate a confusing bordered <legend> tag. It is replaced with an <hr> to delineate the sections and an <h3> tag to serve as the heading. To test, apply the patch and regenerate the staff client CSS. - Configure one or more additional subscription fields. - View the detail page for a subscription and confirm that the "Additional fields" section is clearly labeled. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Bug 21505 depends on bug 21523, which changed state. Bug 21523 Summary: Switch two-column templates to Bootstrap grid: Serials part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21523 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Caused by bug 21523 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ignore that.. the error is present in 18.05.x series too.. backporting now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21505 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not to change display in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org