[Bug 35717] New: Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Bug ID: 35717 Summary: Add an ordernumber column to suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org This is bug 28844 reworked with the relationship defined in the reverse way. There can be multiple suggestions for the same title currently (the check for duplicate suggestions includes the suggestedby field in the search, so only a single patron is prevented from requesting the same book twice) While we can order only from a single suggestion, bug 19358 and 31632 seek to allow linking multiple suggestions to an order, I believe we need to define the relationship this way now, to allow for future changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160576&action=edit Bug 35717: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160577&action=edit Bug 35717: DBIC schema changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160578&action=edit Bug 35717: Add link between suggestions and orders Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160579&action=edit Bug 35717: Remove GetSuggestionInfoFromBiblionumber Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160580&action=edit Bug 35717: Replace GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160581&action=edit Bug 35717: Remove GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160582&action=edit Bug 35717: Adjust other calls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160583&action=edit Bug 35717: Tidy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28844 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #9 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Test plan: 1 - apply patch, reset_all 2 - create purchase suggestion 3 - accept purchase suggestion 4 - create and receive order from suggestion 5 - confirm that notices were generated as suggestion is accepted, ordered, received 6 - confirm that order number is present in suggestions data Anything else I need to check here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #10 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Test plan: 1 - apply patch, reset_all 2 - create purchase suggestion 3 - accept purchase suggestion 4 - create and receive order from suggestion 5 - confirm that notices were generated as suggestion is accepted, ordered, received 6 - confirm that order number is present in suggestions data 7 - submit a second suggestion, accept it, create order from it 8 - cancel order from suggestion, confirm suggestion status reverts from "Ordered" to "Accepted" and order number is removed from suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Hi these patches applied, I'm getting an error when attempting to receive an order tied to a suggestion. It looks like maybe an undefined basket number? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #11)
Hi these patches applied, I'm getting an error when attempting to receive an order tied to a suggestion. It looks like maybe an undefined basket number?
I don't recreate this. Did you updatedatabase after applying the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #13 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Lucas Gass from comment #12)
(In reply to Andrew Fuerste-Henry from comment #11)
Hi these patches applied, I'm getting an error when attempting to receive an order tied to a suggestion. It looks like maybe an undefined basket number?
I don't recreate this. Did you updatedatabase after applying the patch?
I'm getting this error on a sandbox that was provisioned with the patch applied from the start. My understanding is that inherently includes an updatedatabase, and I can see via SQL that the suggestions table *does* include the ordernumber field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add an ordernumber column |Link suggestions to orders |to suggestions |by adding ordernumber to | |suggestions table --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #11)
Hi these patches applied, I'm getting an error when attempting to receive an order tied to a suggestion. It looks like maybe an undefined basket number?
Was the suggestion created before or after applying the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #15 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #14)
(In reply to Andrew Fuerste-Henry from comment #11)
Hi these patches applied, I'm getting an error when attempting to receive an order tied to a suggestion. It looks like maybe an undefined basket number?
Was the suggestion created before or after applying the patch?
After. I tested this on a sandbox with the patch applied from creation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I guess that was wishful thinking. I hope Nick will have time to have a look soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160576|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164834&action=edit Bug 35717: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160577|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164835&action=edit Bug 35717: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160578|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164836&action=edit Bug 35717: Add link between suggestions and orders Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160579|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164837&action=edit Bug 35717: Remove GetSuggestionInfoFromBiblionumber Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160580|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164838&action=edit Bug 35717: Replace GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160581|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164839&action=edit Bug 35717: Remove GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160582|0 |1 is obsolete| | --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164840&action=edit Bug 35717: Adjust other calls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31632 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- And bug 31632? Can we maybe all discuss and move toward a single direction at the same time?... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |tomascohen@gmail.com --- Comment #25 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I'm looking at this one. Had to recreate a patch and some patches are in the wrong order? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160583|0 |1 is obsolete| | Attachment #164834|0 |1 is obsolete| | Attachment #164835|0 |1 is obsolete| | Attachment #164836|0 |1 is obsolete| | Attachment #164837|0 |1 is obsolete| | Attachment #164838|0 |1 is obsolete| | Attachment #164839|0 |1 is obsolete| | Attachment #164840|0 |1 is obsolete| | --- Comment #26 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172871&action=edit Bug 35717: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #27 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172872&action=edit Bug 35717: Add link between suggestions and orders Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #28 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172873&action=edit Bug 35717: Remove GetSuggestionInfoFromBiblionumber Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #29 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172874&action=edit Bug 35717: Replace GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #30 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172875&action=edit Bug 35717: Remove GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #31 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172876&action=edit Bug 35717: DBIC schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #32 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172877&action=edit Bug 35717: Adjust other calls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #33 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172878&action=edit Bug 35717: (QA follow-up) ->suggestions() always returns a resultset This patch acknowledges the fact a one to many relationship always returns an iterator (even an empty one) so there's no point in having a codepath for it not returning a resultset. The tests are simplified for readability too. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #34 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #24)
And bug 31632? Can we maybe all discuss and move toward a single direction at the same time?...
Aleisha and Nick are on the same page. I'll take a look at that one after this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #35 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172899&action=edit Bug 35717: Fix typo in basket.tt This patch fixes a stray `%]` displaying in basket.pl when the order is linked to a suggestion. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #36 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172900&action=edit Bug 35717: Fix rebase issue after bug 34478 Some code was introduced and the block setting the `ordernumber` for the suggestion when creating an order from a suggestion got located before the actual order is created, and as such the suggestion got is ordernumber set as NULL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #37 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172901&action=edit Bug 35717: JS fixes Bug 37018 added validation to queries and `{"in":...}` is no longer valid. `{"-in":...}` is so this patch tweaks that. The previous patch fixes actual linking orders to suggestions. But not having orders linked highlighted the code explode because an empty array evaluates to `true` in Javascript. This patch fixes that too. The links generated by this patchset also get their components correctly escaped. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #38 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- This was already signed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have just started to review the code here. 1) Migration I notice that there is no migration script for existing suggestions. You remove GetSuggestionFromBiblionumber and replace it with a lookup by ordernumber, but this will be empty for all existing suggestions after update. I hope I didn't miss it, but there seems to be no fallback. For the users this means they won't receive an AVAILABLE notice once the suggestion is received. For the people working in ACQ they will no longer be able to tell which old orders have been ordered from suggestions. How do we deal with that? Joubu and I had discussed that at length on bug 28844. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patches don't include any test plans and Andrew's test plan is great, but missing something: -1 - Create at least 2 suggestions 0 - Create order from one of the suggestions > 1 - apply patch, reset_all > 2 - create purchase suggestion > 3 - accept purchase suggestion > 4 - create and receive order from suggestion > 5 - confirm that notices were generated as suggestion is accepted, ordered, > received > 6 - confirm that order number is present in suggestions data 7 - Confirm the old order from suggestion * displays suggestor still and switches to suggestion status to AVAILABLE when received -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Depends on| |31632 --- Comment #41 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- This needs to be rebased on top of bug 31632. Are you planning on coming back to this, Nick? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 [Bug 31632] Add ability to manually link orders to suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org