[Bug 35154] New: Convert StaffLoginInstructions system preference to additional contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Bug ID: 35154 Summary: Convert StaffLoginInstructions system preference to additional contents Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org Depends on: 31383, 35153 Blocks: 26050 Building on 22318, the StaffLoginInstructions system preference should be converted to an HTML customization option. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 [Bug 31383] Additional contents: We need a parent and child table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35153 [Bug 35153] Convert IntranetmainUserblock system preference to additional contents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159178&action=edit Bug 35154: Convert StaffLoginInstructions system preference to additional contents This patch moves the StaffLoginInstructions system preference into HTML customizations, making it possible to have language-specific content. To test you should have some content in the StaffLoginInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from StaffLoginInstructions is now stored there. - The HTML customization entry form should offer StaffLoginInstructions as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the StaffLoginInstructions HTML customization and add unique content to the "fr-FR" tab. - View the staff interface login page. You should see the content you added to the StaffLoginInstructions HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "StaffLoginInstructions." It should return no results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159178|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 159616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159616&action=edit Bug 35154: Convert StaffLoginInstructions system preference to additional contents This patch moves the StaffLoginInstructions system preference into HTML customizations, making it possible to have language-specific content. To test you should have some content in the StaffLoginInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from StaffLoginInstructions is now stored there. - The HTML customization entry form should offer StaffLoginInstructions as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the StaffLoginInstructions HTML customization and add unique content to the "fr-FR" tab. - View the staff interface login page. You should see the content you added to the StaffLoginInstructions HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "StaffLoginInstructions." It should return no results. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Something I noticed before applying the patch (so not related to this bug), is that bullet points don't display correctly on the login screen if you have these in StaffLoginInstructions. But unordered lists do. This is the same after the change in this bug. 2. Translations since 23.11 (after .po files now in separate l10n repository) - quick instructions for KTD: . Before starting up KTD, cd misc/translator/po: . git checkout master . git reset --hard origin/master . git pull . When in KTD, after it has started successfully (used es-ES here): . gulp po:update --lang es-ES . Install language: koha-translate --install es-ES --dev kohadev . To reset everything: . your koha clone - as normal: git checkout master, git branch -D bzXXXXX, git reset --hard origin/master . the l10n repository (change to misc/translator/po): . git checkout master (you should already be on master for the l10n repository, so normally not necessary) . git status (check that there are no stray files or directories, remove them if required) . git reset --hard origin/master . Remove the installed language: koha-translate --remove es-ES --dev kohadev . reset_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159616|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160252&action=edit Bug 35154: Convert StaffLoginInstructions system preference to additional contents This patch moves the StaffLoginInstructions system preference into HTML customizations, making it possible to have language-specific content. To test you should have some content in the StaffLoginInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from StaffLoginInstructions is now stored there. - The HTML customization entry form should offer StaffLoginInstructions as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the StaffLoginInstructions HTML customization and add unique content to the "fr-FR" tab. - View the staff interface login page. You should see the content you added to the StaffLoginInstructions HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "StaffLoginInstructions." It should return no results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We have an unresolved dependency with bug 35153 in NSO here. Moving to BLOCKED; please unlock! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Depends on|31383, 35153 |35152 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 [Bug 31383] Additional contents: We need a parent and child table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35152 [Bug 35152] Convert RoutingListNote system preference to additional contents https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35153 [Bug 35153] Convert IntranetmainUserblock system preference to additional contents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160252|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168012&action=edit Bug 35154: Convert StaffLoginInstructions system preference to additional contents This patch moves the StaffLoginInstructions system preference into HTML customizations, making it possible to have language-specific content. To test you should have some content in the StaffLoginInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from StaffLoginInstructions is now stored there. - The HTML customization entry form should offer StaffLoginInstructions as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the StaffLoginInstructions HTML customization and add unique content to the "fr-FR" tab. - View the staff interface login page. You should see the content you added to the StaffLoginInstructions HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "StaffLoginInstructions." It should return no results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The dependent bug 35152 is in Signed off. Moving to BLOCKED. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168012|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170718&action=edit Bug 35154: Convert StaffLoginInstructions system preference to additional contents This patch moves the StaffLoginInstructions system preference into HTML customizations, making it possible to have language-specific content. To test you should have some content in the StaffLoginInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from StaffLoginInstructions is now stored there. - The HTML customization entry form should offer StaffLoginInstructions as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the StaffLoginInstructions HTML customization and add unique content to the "fr-FR" tab. - View the staff interface login page. You should see the content you added to the StaffLoginInstructions HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "StaffLoginInstructions." It should return no results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170718|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176393&action=edit Bug 35154: Convert StaffLoginInstructions system preference to additional contents This patch moves the StaffLoginInstructions system preference into HTML customizations, making it possible to have language-specific content. To test you should have some content in the StaffLoginInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from StaffLoginInstructions is now stored there. - The HTML customization entry form should offer StaffLoginInstructions as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the StaffLoginInstructions HTML customization and add unique content to the "fr-FR" tab. - View the staff interface login page. You should see the content you added to the StaffLoginInstructions HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "StaffLoginInstructions." It should return no results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Depends on|35152 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35152 [Bug 35152] Convert RoutingListNote system preference to additional contents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement moves the release notes| |StaffLoginInstructions | |system preference into HTML | |customizations, making it | |possible to have | |language-specific content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1101 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org