[Bug 18045] New: Reserves.t can fail because of caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Bug ID: 18045 Summary: Reserves.t can fail because of caching issues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13113 [Bug 13113] Prevent juvenile/children from reserving ageRestricted material -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59858&action=edit Bug 18045: Fix Reserves.t tests - caching issues If the cache has to be cleaned when marc structure is updated. Before this patch, if the age restriction was not mapped, Reserves.t failed with: Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 523. Test plan: Just confirm that the tests still pass and that the changes make sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17737 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59858|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59868&action=edit Bug 18045: Fix Reserves.t tests - caching issues If the cache has to be cleaned when marc structure is updated. Before this patch, if the age restriction was not mapped, Reserves.t failed with: Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 523. Test plan: Just confirm that the tests still pass and that the changes make sense. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> It seems that only removing the key MarcSubfieldStructure- should be enough, but it does not hurt either to remove those four keys. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59868|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 60255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60255&action=edit Bug 18045: Fix Reserves.t tests - caching issues If the cache has to be cleaned when marc structure is updated. Before this patch, if the age restriction was not mapped, Reserves.t failed with: Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 523. Test plan: Just confirm that the tests still pass and that the changes make sense. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> It seems that only removing the key MarcSubfieldStructure- should be enough, but it does not hurt either to remove those four keys. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org