[Bug 25015] New: Staff with Edit Items permission Currently Can Not Edit Items attached to a Fast Add Framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Bug ID: 25015 Summary: Staff with Edit Items permission Currently Can Not Edit Items attached to a Fast Add Framework Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If a staff has the permission has only the permission in Cataloging to "Edit Items" currently, they can't edit items attached to a Fast Add bib. What should the change be? Does a staff member need to have Fast Cataloging and Edit Items to be able to Edit Items attached to a Fast Added Bib? And if that is the case, the bug lies with the fact the staff member doesn't know that this bib is a Fast Add bib- the Edit option should not be visible to staff that only have "edit items" and not "Fast Cataloging" Or Is it a library's understanding that the permission "Edit Items" allows All Items can be edited even the items attached to Fast Add Biblios? And if that is the case, then the change lies with how the permissions are coded in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 --- Comment #1 from Kelly McElligott <kelly@bywatersolutions.com> --- Working with a specific library that stumbled upon this bug, they feel that the staff member with edit Items permission should be able to edit any items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Still true on master as of 7/2/21. This is not correct. Someone with Edit Items should be able to edit items on a Fast Add bib regardless of whether or not they have fast_cataloging permission. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Chris Rowlands <chris.rowlands6@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.rowlands6@nhs.net --- Comment #3 from Chris Rowlands <chris.rowlands6@nhs.net> --- This has cropped up for us recently as well. I think our libraries were also expecting that edit_items wouldn't be blocked by an unchecked fast_cataloguing permission. However, you can still edit these blocked items if you use the batch modification feature on the record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Eileen Chandler <echandler@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echandler@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 179611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179611&action=edit Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and add_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Version|19.05 |Main Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179611|0 |1 is obsolete| | --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 179612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179612&action=edit Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and edit_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179612|0 |1 is obsolete| | --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179896&action=edit Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and edit_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179896|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 181152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181152&action=edit Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and edit_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 181153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181153&action=edit Bug 25015: (QA follow-up) Slide together We do not need 1 or 0 here btw. We just check for true. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff with Edit Items |Staff with 'Edit Iitems' |permission Currently Can |permission currently can |Not Edit Items attached to |not edit Items attached to |a Fast Add Framework |a fast add framework --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Marcel, added your missing sign-off line to the first patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Whoooo dirty bug ;) This permission check already exists in addbiblio.pm : my $userflags = $frameworkcode eq 'FA' ? [ 'fast_cataloging', 'edit_catalogue' ] : 'edit_catalogue'; Maybe we need a common method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org