[Bug 32218] New: Rephrase: Allow OPAC access to users from this domain to login with this identity provider.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Bug ID: 32218 Summary: Rephrase: Allow OPAC access to users from this domain to login with this identity provider. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Found while translating: koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:204 Allow OPAC access to users from this domain to login with this identity provider. Maybe this was meant? Allow users of this domain to log into the OPAC using this identity provider. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Certainly sounds like a good rephrase to me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is another, similar one: koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:212 Allow staff access to users from this domain to login with this identity provider. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Koha Training Catalyst <koha-training@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 --- Comment #3 from Koha Training Catalyst <koha-training@catalyst.net.nz> --- Created attachment 169618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169618&action=edit Bug 32218: Update string grammer in identity-providers.tt Adiministration>Identity Providers>New identity provider under allow OPAC the language string was updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 169623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169623&action=edit Bug 32218: Update string grammar in identity-providers.tt Adiministration>Identity Providers>New identity provider under allow OPAC the language string was updated. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169618|0 |1 is obsolete| | Attachment #169623|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 169624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169624&action=edit Bug 32218: Update string grammar in identity-providers.tt Adiministration>Identity Providers>New identity provider under allow OPAC the language string was updated. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169624|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169765&action=edit Bug 32218: Update string grammar in identity-providers.tt Adiministration > Identity Providers > New identity provider under allow OPAC the language string was updated. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA'd by RM. String change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz, | |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like I got confused with bug 8855 somehow and falsely attributed this patch to Jennifer Sutton in the commit and pushed it. I sincerely apologize for that confusion. Aleisha or Wainui, do you know who wrote this patch and if they would like to be attributed? I think a revert would not fix in git history, but happy to do it if you think it would be the right thing to do. Also open to other suggestions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This patch was written by Michael Nixon. I did show him how to 'take credit' for the fix but since he hasn't followed the steps maybe he doesn't mind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Aleisha Amohia from comment #9)
This patch was written by Michael Nixon. I did show him how to 'take credit' for the fix but since he hasn't followed the steps maybe he doesn't mind.
Should we leave as is? I am not sure if a revert/re-push (with the original email) won't make statistics more confusing, but happy to do it if you think we should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I think it's okay to leave as-is, no need to create extra weirdness/work for yourself. Thank you though! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, | |release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org