[Bug 31405] New: Set focus for cursor to setSpec input when adding a new OAI set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Bug ID: 31405 Summary: Set focus for cursor to setSpec input when adding a new OAI set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When adding a new OAI set from administration, the focus/cursor should be in the first field of the entry form: setSpec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146177&action=edit Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146177|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146267&action=edit Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- In other places we only set the focus when adding and but when editing? Should we do that here to? See Bug 31410. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150133&action=edit dBug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #3)
In other places we only set the focus when adding and but when editing? Should we do that here to?
See Bug 31410.
I changed the patch to not set the focus on the description when an existing set is edited. This is to avoid accidental changes and matches behavior on other pages, as Lucas has pointed out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146267|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 150134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150134&action=edit Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #150133|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Comment on attachment 150133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150133 dBug 31405: Set focus for cursor to setSpec input when adding a new OAI set Managed to double up the patches as I amended the patch title - from "dBug 31405: ..." to "Bug 31405: ...". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150134|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150397&action=edit Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.14 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danyonsewell@catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.06,22.05.14 |23.05.00,22.11.06,22.05.14, released in| |21.11.22 --- Comment #12 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Backported to 21.11.x for upcoming 21.11.22 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org