[Bug 18110] New: Adds FR to the syspref AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Bug ID: 18110 Summary: Adds FR to the syspref AddressFormat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #1 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60176&action=edit Add a field FR to the syspref AddressFormat Testplan 1 - Apply 2 - Check there is a field FR in the syspref AddressFormat -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60176|0 |1 is obsolete| | --- Comment #2 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60214&action=edit Add a field FR to the syspref AddressFormat Testplan 1 - Apply 2 - Check there is a field FR in the syspref AddressFormat -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60214|0 |1 is obsolete| | --- Comment #3 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60215&action=edit Add a field FR to the syspref AddressFormat Testplan 1 - Apply patch 2 - Check if there is a field FR in the syspref AddressFormat, enable it 3 - Create a new borrower and check the order of the fields for the address 4 - Check if it's address appears in a propper manner -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #4 from Marc Véron <veron@veron.ch> --- Hi Babtiste, the patch adds a line ('LoadSearchHistoryToTheFirstLoggedUser',.... to installer/data/mysql/sysprefs.sql (Line 237) It seems to me that it is not related to this Bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #5 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60426&action=edit BUG 18110 : Removed a wrong syspref from code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #6 from Marc Véron <veron@veron.ch> --- On the patron's detail page, street number goes on a separate line, something like 11 rue de Bâle instead of 11 rue de Bâle I think the code should go inside the li element in member-display-address-style-fr.inc (maybe at other places as well?) You have something like: [% IF streetnumber %] [% streetnumber %][% END %] [%IF roadtype_desc %] [% roadtype_desc %][% END %] <li class="patronaddress1">[% address %] </li> I think it should be something like: <li class="patronaddress1"> [% IF streetnumber %] [% streetnumber %][% END %] [%IF roadtype_desc %] [% roadtype_desc %][% END %] [% address %] </li> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #7 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Hi, Are you sure you tested the newest version of the patch ? I remember I corrected at last a part of the problem Could you try again and send me the exact test plan you applied to get this bug ? I tried to make a new branch from master and apply the patch on a new branch : I can't reproduce it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 60657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60657&action=edit Screenshot with patch The streetnumber displays above the street (see screenshots at the left), I would expect them on the same line. 4554 Library Rd. instead of 4554 Library Rd. Editing the main address (Link below "Gender") displays some stray HTML (screenshots right). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #9 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Hi ! Did you reapply the patch ? I mean I can't reproduce your problem again, and I think I have corrected it, and by reapplying it on the master I can't reproduce it again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #10 from Marc Véron <veron@veron.ch> --- Yes, I applied the patch. I think it is in member-display-address-style-fr.inc: The patch is as follows: (...) [% IF ( address ) %] [% SET roadtype_desc = '' %] [% IF streettype %] [% SET roadtype_desc = AuthorisedValues.GetByCode('ROADTYPE', streettype) %] [% END %] [% IF streetnumber %] [% streetnumber %][% END %] [%IF roadtype_desc %] [% roadtype_desc %][% END %] <li class="patronaddress1">[% address %] </li> [% END %] (...) If I change it to the following, the address displays OK: (...) [% IF ( address ) %] [% SET roadtype_desc = '' %] [% IF streettype %] [% SET roadtype_desc = AuthorisedValues.GetByCode('ROADTYPE', streettype) %] [% END %] <li class="patronaddress1"> [% IF streetnumber %] [% streetnumber %][% END %] [%IF roadtype_desc %] [% roadtype_desc %][% END %] [% address %] </li> [% END %] (...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #11 from Marc Véron <veron@veron.ch> --- Additionally, member-main-address-style-fr.inc line 1 misses an opening < : fieldset class="rows" id="memberentry_mainaddress"> instead of: <fieldset class="rows" id="memberentry_mainaddress"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #12 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60689&action=edit Bug 16034 - DBRev 16.12.00.010 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60689|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #13 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60690&action=edit BUG 18110 : Modified the adresses in order to fit the french standards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60690|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #14 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60694&action=edit BUG 18110 : Correct display and syspref AddFormat Add a field FR to the syspref AddressFormat Testplan 1 - Apply patch 2 - Check if there is a field FR in the syspref AddressFormat, enable it 3 - Create a new borrower and check the order of the fields for the address 4 - Check if it's address appears in a propper manner 27/02/17 : Fixed the display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60694|0 |1 is obsolete| | --- Comment #15 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60695&action=edit BUG 18110 : Correct display and syspref AddFormat Add a field FR to the syspref AddressFormat Testplan 1 - Apply patch 2 - Check if there is a field FR in the syspref AddressFormat, enable it 3 - Create a new borrower and check the order of the fields for the address 4 - Check if it's address appears in a propper manner 27/02/17 : Fixed the display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60426|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #16 from Marc Véron <veron@veron.ch> --- I'm really sorry, but there is still a problem with koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-fr.inc The streetnumber still does not display on the same line as the address. Your code reads (line 7 and following): <li> [% IF streetnumber %] [% streetnumber %][% END %] [%IF roadtype_desc %] [% roadtype_desc %][% END %] </li> <li class="patronaddress1">[% address %] </li> It should be: <li class="patronaddress1"> [% IF streetnumber %] [% streetnumber %][% END %] [%IF roadtype_desc %] [% roadtype_desc %][% END %] [% address %] </li> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #17 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Hi ! Do you think we should have everything printed on the same line ? I wasn't sure it would we best way to display the address, but is ok, I'll change it again ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #18 from Marc Véron <veron@veron.ch> --- Hi Baptiste, Yes, I think that number, street and address should display on the same line. See: https://fr.wikipedia.org/wiki/Adresse_postale#Recommandations_de_La_Poste (...) numéro dans la voie (éventuellement suivi d’un complément de numéro tel bis, ter, quater, etc.), immédiatement suivi du type de voie (rue, avenue, etc.) et du nom de celle-ci (...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr Status|Needs Signoff |Failed QA --- Comment #19 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- There is a problem when b.streettype is used, address 1 : 1 - is displayed on separate line at : http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/circ/circulation.pl?... http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/members/moremember.p... Furthermore, streettype is not displayed at all on some pages : For example : http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/members/boraccount.p... Other point : streetnumber nor streettype are not displayed here : http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/members/member-passw... but I guess these should be filled in another bugzilla ticket). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #20 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 61610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61610&action=edit BUG 18110: Corrected display address format - minor changes on address format - corrected member-password so that steetnumber is given to the template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Baptiste <baptiste.wojtkowski@biblibre.com> --- I corrected the display of streetnumber in this ticket, I don't think it's necessary to open a new ticket just for one code line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #22 from Marc Véron <veron@veron.ch> --- Hi Babtiste, Changes work fine, but please have a look at Alternate address as well, streetnumber is on a separate line and street type is after address. See: member-display-alt-address-style-fr.inc Marc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60657|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #23 from Marc Véron <veron@veron.ch> --- Sorry, I was wrong in my comment #16. I just found out that the addres line starts with an unwanted space character in member-display-address-style-fr.inc lines 8/9: [% IF streetnumber %] [% streetnumber %][% END %] [%IF roadtype_desc %] [% roadtype_desc %][% END %] The space characters after the IFs should move before the ENDs, otherwise the line will begin wit a blank. This is what I mean: [% IF streetnumber %][% streetnumber %] [% END %] [%IF roadtype_desc %][% roadtype_desc %] [% END %] BTW: Will be the same for member-display-alt-address-style-fr.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #24 from Marc Véron <veron@veron.ch> --- Sorry, one more unwanted space at the beginning of a line: [% IF ( city ) %]<li class="patroncity"> [%IF (zipcode ) %][% zipcode %] [% END %][% city %][% IF ( state ) ...should be: [% IF ( city ) %] <li class="patroncity">[%IF (zipcode ) %][% zipcode %] [% END %][% city %][% IF ( state ) Otherwise you get a space before the line with zipcode, city etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18335 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #25 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 61639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61639&action=edit BUG 18810: Removed unwanted spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #26 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #22)
Hi Babtiste,
Changes work fine, but please have a look at Alternate address as well, streetnumber is on a separate line and street type is after address.
See: member-display-alt-address-style-fr.inc
Marc
Hi Babtiste, With Alternate address, I get: Alternate address 777 Royale rue 75002 Paris France I would expect 777 rue Royale -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60695|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 61650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61650&action=edit BUG 18110 : Correct display and syspref AddFormat Add a field FR to the syspref AddressFormat Testplan 1 - Apply patch 2 - Check if there is a field FR in the syspref AddressFormat, enable it 3 - Create a new borrower and check the order of the fields for the address 4 - Check if it's address appears in a propper manner 27/02/17 : Fixed the display Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61610|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 61651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61651&action=edit BUG 18110: Corrected display address format - minor changes on address format - corrected member-password so that steetnumber is given to the template Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61639|0 |1 is obsolete| | --- Comment #29 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 61652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61652&action=edit BUG 18810: Removed unwanted spaces https://bugs.koha-community.org/show_bug.cgi?id=18110 Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #30 from Marc Véron <veron@veron.ch> --- Problem described in Comment #26 is not yet fixed. Followup patch follows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #31 from Marc Véron <veron@veron.ch> --- Created attachment 61656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61656&action=edit Bug 18110: Folllowup to fix alternative address and add missing class This patch fixes the display of alternative address (streetnumber, streettype and address on same line, see comment #22, and it adds missing class patronaddress1 to main address display. To test: - Create / edit a customer to have streetnumber, streettype and address in both main address and alternate address - Switch syspref addressformat ot French style - Verify that both main address and alternate address display as expected on patron's detail page (street number, street type and address on same line) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #32 from Marc Véron <veron@veron.ch> --- Switching back to NSO for followup patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Do not forget the update DB entry. And commit messages has to start with 'Bug xxxxx', not 'BUG xxxxx' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #34 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 61796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61796&action=edit Bug 18110: Update addressFormat in atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #35 from Marc Véron <veron@veron.ch> --- Hi Babtiste - My followup patch would need a sign-off (See comment #32) - Atomic update produces an sql error, UPDATE sytax seems to be wrong. Did you test it? Marc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61656|0 |1 is obsolete| | --- Comment #36 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62651&action=edit Bug 18110: Folllowup to fix alternative address and add missing class This patch fixes the display of alternative address (streetnumber, streettype and address on same line, see comment #22, and it adds missing class patronaddress1 to main address display. To test: - Create / edit a customer to have streetnumber, streettype and address in both main address and alternate address - Switch syspref addressformat ot French style - Verify that both main address and alternate address display as expected on patron's detail page (street number, street type and address on same line) Works as expected. Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61796|0 |1 is obsolete| | --- Comment #37 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62652&action=edit Bug 18110: Update addressFormat in atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #38 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Sorry, syntax was wrong, I understood the error message as: your base is already full but everything is ok. I tested and signed off you patch, I just need the atomic update to be tested and signed off and I think we are done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62652|0 |1 is obsolete| | --- Comment #39 from Marc Véron <veron@veron.ch> --- Created attachment 62664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62664&action=edit Bug 18110: Update addressFormat in atomicupdate Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61650|0 |1 is obsolete| | Attachment #61651|0 |1 is obsolete| | Attachment #61652|0 |1 is obsolete| | Attachment #62651|0 |1 is obsolete| | Attachment #62664|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62740&action=edit Bug 18110: Add a field FR to the syspref AddressFormat Add a field FR to the syspref AddressFormat Testplan 1 - Apply patch 2 - Check if there is a field FR in the syspref AddressFormat, enable it 3 - Create a new borrower and check the order of the fields for the address 4 - Check if it's address appears in a propper manner 27/02/17 : Fixed the display Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62741&action=edit Bug 18110: Corrected display address format - minor changes on address format - corrected member-password so that steetnumber is given to the template Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62742&action=edit Bug 18110: Removed unwanted spaces Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62743&action=edit Bug 18110: Folllowup to fix alternative address and add missing class This patch fixes the display of alternative address (streetnumber, streettype and address on same line, see comment #22, and it adds missing class patronaddress1 to main address display. To test: - Create / edit a customer to have streetnumber, streettype and address in both main address and alternate address - Switch syspref addressformat ot French style - Verify that both main address and alternate address display as expected on patron's detail page (street number, street type and address on same line) Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62744&action=edit Bug 18110: Update addressFormat in atomicupdate Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62745&action=edit Bug 18110: Do not update value for existing installs Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Baptiste, Marc, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25069 [Bug 25069] AddressFormat="fr" behavior is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 [Bug 25070] Include files to display address and contact must be refactored -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org