[Bug 27410] New: Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Bug ID: 27410 Summary: Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Inputs of type="number" need updating to adhere to ACC2 in intranet-tmpl/prog/en/modules/members/maninvoice.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Blocks| |26962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 [Bug 26962] Koha notice/slips/receipts should print in true black (#000000) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26962 |26926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 [Bug 26926] Update all occurrences of <input type="number"> to apply ACC2 coding guideline https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 [Bug 26962] Koha notice/slips/receipts should print in true black (#000000) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mazen.i.khallaf@gmail.com Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |mazen.i.khallaf@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 --- Comment #1 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Created attachment 115394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115394&action=edit Bug 27410: Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/maninvoice.tt 2. Search for instances of 'input type="number"' 3. If none are found then patch was successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- There is more to do when converting a "type='number'" input: If present, the "step," "max," and "min" attributes should be removed too. They are invalid if applied to a standard text input. Example errors from the w3c validator: Error: Attribute step not allowed on element input at this point. Error: Attribute min not allowed on element input at this point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115394|0 |1 is obsolete| | --- Comment #3 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Created attachment 115471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115471&action=edit Bug 27410: Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/maninvoice.tt 2. Search for instances of 'input type="number"' 3. If none are found then patch was successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I didn't predict this when I was testing before: The regex validating the modified field doesn't allow for currency-formatted values like "1.00" because of the dot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115471|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115551&action=edit Bug 27410: Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/maninvoice.tt 2. Search for instances of 'input type="number"' 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115553&action=edit Bug 27410: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual invoice "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mazen.i.khallaf@gmail.com |koha-bugs@lists.koha-commun | |ity.org CC|mazen.i.khallaf@gmail.com | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115551|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 117012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117012&action=edit Bug 27410: Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/maninvoice.tt 2. Search for instances of 'input type="number"' 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115553|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 117013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117013&action=edit Bug 27410: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual invoice "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117013|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117700&action=edit Bug 27410: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual invoice "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am personally very happy about these changes because we had to maintain them as local changes for a long time :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117012|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117705&action=edit Bug 27410: Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/maninvoice.tt 2. Search for instances of 'input type="number"' 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117700|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117706&action=edit Bug 27410: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual invoice "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've dediced not pushed to 20.11.x changes for ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #14)
I've dediced not pushed to 20.11.x changes for ACC2
Why not? These are very atomic and accessibility fixes are really more bug fixes than enhancements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #15)
(In reply to Fridolin Somers from comment #14)
I've dediced not pushed to 20.11.x changes for ACC2
Why not? These are very atomic and accessibility fixes are really more bug fixes than enhancements.
Ah OK. I'll try to find time to pick them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28168 [Bug 28168] Manual invoice form pre-fills Amount field with invalid number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid@gmail.com --- Comment #17 from Peter Vashchuk <stalkernoid@gmail.com> --- Patch 117706 "Bug 27410: (follow-up) Updates to accommodate currency entry" doesn't take into consideration regional settings: inputmode="decimal" pattern="^\d+(\.\d{2})?$" this never will let comma-separated values to pass (in Finland, for example, coma is used as separator), i.e. "0,00" won't pass. Also there is another requirement from librarians - to have field completely empty if it's 0, so they could just paste amount (as they usually do) without the need to clear the field first. And anyway if you save the form with 0.00 value, it won't accept it saying "Debit amount passed is not positive" so in my opinion there's no point to preset it with zeroes to begin with. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 --- Comment #18 from Peter Vashchuk <stalkernoid@gmail.com> --- Let's continue discussion in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28168 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org