http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25824&action=edit Bug 11878 - Eliminate use of deprecated jQuery .toggle() method usage jQuery's .toggle() method can no longer be used to trigger a pair of specified functions. .toggle() can only be used to change the visibility of an element. This patch fixes a few places in Koha where the deprecated functionality was used. To test, apply the patch and clear your browser cache. - View the system preferences page in the staff client. Clicking a heading ("Appearance" under OPAC preferences, for instance) should collapse that section. Clicking again should expand it. - View the MARC detail page for a record in the OPAC. Clicking the "view plain" link should display the plain MARC view. Clicking the "view labeled" view should return to the original view. Test in both prog and bootstrap themes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 --- Comment #3 from wajasu <matted-34813@mypacks.net> --- Did a qucik search to see if other .toggle usage was present, and got these results, so if they don't need to be addressed, we could change the status to signed off, otherwise things will wait for further followup patches. It may depend on the jquery update only needing to be done for OPAC. 12:45:28 {bug11878 %} ~/prj/kohaclone$ find . -name "*.js" -exec grep -Hn ".toggle()" {} \; Some places where toggle is in our source tree after the 1st patch applied: ./koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.js:1814: this.options.toggle && this.toggle() ./koha-tmpl/opac-tmpl/bootstrap/js/script.js:54: $(".menu-collapse").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/pages/batchMod.js:15: $("#itemst td:nth-child("+valCookie[i]+"),#itemst th:nth-child("+valCookie[i]+")").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/pages/batchMod.js:29: $("#itemst td:nth-child("+hide+"),#itemst th:nth-child("+hide+")").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/pages/batchMod.js:65: $("#itemst td:nth-child("+show+"),#itemst th:nth-child("+show+")").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/acq.js:863: $("#plan td:nth-child("+hide+"),#plan th:nth-child("+hide+")").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/acq.js:872: $("#plan td:nth-child("+show+"),#plan th:nth-child("+show+")").toggle(); -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 25841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25841&action=edit [Signed-off] Bug 11878 - Eliminate use of deprecated jQuery .toggle() method usage jQuery's .toggle() method can no longer be used to trigger a pair of specified functions. .toggle() can only be used to change the visibility of an element. This patch fixes a few places in Koha where the deprecated functionality was used. To test, apply the patch and clear your browser cache. - View the system preferences page in the staff client. Clicking a heading ("Appearance" under OPAC preferences, for instance) should collapse that section. Clicking again should expand it. - View the MARC detail page for a record in the OPAC. Clicking the "view plain" link should display the plain MARC view. Clicking the "view labeled" view should return to the original view. Test in both prog and bootstrap themes. Signed-off-by: wajasu <matted-34813@mypacks.net> Followed test plan. Works fine. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.