[Bug 26795] New: Remove the use of jquery.checkboxes plugin from ILL pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Bug ID: 26795 Summary: Remove the use of jquery.checkboxes plugin from ILL pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: aleisha@catalyst.net.nz, amit.gupta@informaticsglobal.com, amitddng135@gmail.com, katrin.fischer@bsz-bw.de, lucas@bywatersolutions.com, testopia@bugs.koha-community.org Blocks: 26006 Two ill request pages include the jquery.checkboxes plugin but do not use them. The include should be removed. - intranet-tmpl/prog/en/modules/ill/ill-requests.tt - intranet-tmpl/prog/en/modules/members/ill-requests.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112261&action=edit Bug 26795: Remove the use of jquery.checkboxes plugin from ILL pages This patch removes the inclusion of the jquery.checkboxes plugin from two staff interface ILL pages where the plugin is unused. To test you need at least one patron with some ILL requests. - Apply the patch and locate a patron with ILL requests. - Click the "ILL requests history" tab. - Confirm that the table of requests has no checkboxes. - Choose "Ill requests" from the "More" menu in the header. - Confirm that the table of requests has no checkboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 [Bug 26806] Remove the jquery.checkboxes plugin from the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112261|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 112769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112769&action=edit Bug 26795: Remove the use of jquery.checkboxes plugin from ILL pages This patch removes the inclusion of the jquery.checkboxes plugin from two staff interface ILL pages where the plugin is unused. To test you need at least one patron with some ILL requests. - Apply the patch and locate a patron with ILL requests. - Click the "ILL requests history" tab. - Confirm that the table of requests has no checkboxes. - Choose "Ill requests" from the "More" menu in the header. - Confirm that the table of requests has no checkboxes. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes: See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758#c3 for how to setup ILL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112769|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112770&action=edit Bug 26795: Remove the use of jquery.checkboxes plugin from ILL pages This patch removes the inclusion of the jquery.checkboxes plugin from two staff interface ILL pages where the plugin is unused. To test you need at least one patron with some ILL requests. - Apply the patch and locate a patron with ILL requests. - Click the "ILL requests history" tab. - Confirm that the table of requests has no checkboxes. - Choose "Ill requests" from the "More" menu in the header. - Confirm that the table of requests has no checkboxes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org