[Bug 21095] New: Tests should expect ccodes facets now (since we have ccode facets)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Bug ID: 21095 Summary: Tests should expect ccodes facets now (since we have ccode facets) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Since bug 18322 added ccode facets to zebra we should expect to get them in tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18322 Assignee|chris@bigballofwax.co.nz |nick@bywatersolutions.com CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 [Bug 18322] Add facets for ccode to zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77146&action=edit Bug 21095: Add ccode facets info to tests To test: 1 - prove -v t/db_dependent/Search.t 2 - Koha asks "Why am I getting these crazy facets!?!" 3 - Apply patch 4 - prove -v t/db_dependent/Search.t 5 - Koha purrs (tests pass) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77146|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77151&action=edit Bug 21095: Add ccode facets info to tests To test: 1 - prove -v t/db_dependent/Search.t 2 - Koha asks "Why am I getting these crazy facets!?!" 3 - Apply patch 4 - prove -v t/db_dependent/Search.t 5 - Koha purrs (tests pass) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Going straight to Passed QA, works as described.. sorry Nick, muppet moment on my part there ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Bug 21095 depends on bug 18322, which changed state. Bug 18322 Summary: Add facets for ccode to zebra https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Depends on bug 18322 which is not being backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org