[Bug 15987] New: Acq module fails with undefined subroutine &main::GetCurrency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Bug ID: 15987 Summary: Acq module fails with undefined subroutine &main::GetCurrency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart@bugs.koha-community.org Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 15084 Acq module fails with undefined subroutine &main::GetCurrency Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48724&action=edit Bug 15987: Fix undefined subroutine &main::GetCurrency in acqui-home.pl Bug 15987 and bug 15049 were competing the push to master status at the same time. Bug 15987 removed the GetCurrency status and bug 15049 reintrocuced one occurrence of this subroutine. Test plan: Confirm that the test plan for 15049 still passes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48725&action=edit Bug 15987: Fix undefined subroutine &main::GetCurrency in opac-account-pay Bug 15987 and bug 11622 were competing the push to master status at the same time. Bug 15987 removed the GetCurrency status and bug 11622 reintroduced one occurrence of this subroutine. Test plan: Confirm that the test plan for 11622 still passes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11622, 15049 Severity|enhancement |blocker Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 [Bug 15049] Add warning about "No active currency" to Acquisitions start page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2)
Created attachment 48725 [details] [review] Bug 15987: Fix undefined subroutine &main::GetCurrency in opac-account-pay
Bug 15987 and bug 11622 were competing the push to master status at the same time. Bug 15987 removed the GetCurrency status and bug 11622 reintroduced one occurrence of this subroutine.
Test plan: Confirm that the test plan for 11622 still passes.
Jonathan, I added a qa followup to bug 15084 that fixes the same issues. Do you think it would be better to close this bug, or to revert my patch and push this bug through the community process? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, the acq start page seems to be ok now in master, but I failed to test the paypal related page. It asks for a module that I seem to be missing? I was not able to fix that right away. [Mon Mar 07 23:16:02.290772 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] AH01215: Can't locate URL/Encode.pm in @INC (you may need to install the URL::Encode module) (@INC contains: /home/katrin/kohaclone /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: http://localhost/cgi-bin/koha/opac-account.pl [Mon Mar 07 23:16:02.290880 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] AH01215: BEGIN failed--compilation aborted at /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: http://localhost/cgi-bin/koha/opac-account.pl [Mon Mar 07 23:16:02.291551 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] End of script output before headers: opac-account-pay.pl, referer: http://localhost/cgi-bin/koha/opac-account.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #3)
(In reply to Jonathan Druart from comment #2)
Created attachment 48725 [details] [review] [review] Bug 15987: Fix undefined subroutine &main::GetCurrency in opac-account-pay
Bug 15987 and bug 11622 were competing the push to master status at the same time. Bug 15987 removed the GetCurrency status and bug 11622 reintroduced one occurrence of this subroutine.
Test plan: Confirm that the test plan for 11622 still passes.
Jonathan, I added a qa followup to bug 15084 that fixes the same issues. Do you think it would be better to close this bug, or to revert my patch and push this bug through the community process?
If you tested the paypal stuff, I am fine with your patch (I have not tested it!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #4)
Hm, the acq start page seems to be ok now in master, but I failed to test the paypal related page.
It asks for a module that I seem to be missing? I was not able to fix that right away.
[Mon Mar 07 23:16:02.290772 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] AH01215: Can't locate URL/Encode.pm in @INC (you may need to install the URL::Encode module) (@INC contains: /home/katrin/kohaclone /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: http://localhost/cgi-bin/koha/opac-account.pl [Mon Mar 07 23:16:02.290880 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] AH01215: BEGIN failed--compilation aborted at /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: http://localhost/cgi-bin/koha/opac-account.pl [Mon Mar 07 23:16:02.291551 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] End of script output before headers: opac-account-pay.pl, referer: http://localhost/cgi-bin/koha/opac-account.pl
URL::Encode does not seem to be packaged in our repo. See the original bug report for the discussion about this module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org