https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168777&action=edit Bug 37309: Improve Delete and Modify items links on the biblio detail page The way the "Delete selected items" and "Modify selected items" links are build on the bibliographic detail page is not nice. We could do better, for instance using a proper form element instead of building an URL. Test plan: Go to the detail page of a bibliographic record which has several items. In the items table check some checkboxes and play with "select all", "clear all" and the action buttons. Notice that everything works as before. Minor UI regression that must be fixed: there are CSS rules that cause problem. When the action links are displayed or hidden the table is moving up and down. I think the problematic rules are: .btn { padding: 6px 12px; font-size: 12px; } It makes the UI better if I remove them but still get the bumping issue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168777|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168797&action=edit Bug 37309: Improve Delete and Modify items links on the biblio detail page The way the "Delete selected items" and "Modify selected items" links are build on the bibliographic detail page is not nice. We could do better, for instance using a proper form element instead of building an URL. Test plan: Go to the detail page of a bibliographic record which has several items. In the items table check some checkboxes and play with "select all", "clear all" and the action buttons. Notice that everything works as before. Minor UI regression that must be fixed: there are CSS rules that cause problem. When the action links are displayed or hidden the table is moving up and down. I think the problematic rules are: .btn { padding: 6px 12px; font-size: 12px; } It makes the UI better if I remove them but still get the bumping issue. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Thanks a lot, Owen. I found some bugs retesting this however. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168802&action=edit Bug 37309: Clear itemnumbers array before 'select all' Otherwise the same itemnumber can appear several times in the array. It could be moved to its own bug but this is only code cleaning it seems, there is no impact on the UX -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168797|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168845&action=edit Bug 37309: Improve Delete and Modify items links on the biblio detail page The way the "Delete selected items" and "Modify selected items" links are build on the bibliographic detail page is not nice. We could do better, for instance using a proper form element instead of building an URL. Test plan: Go to the detail page of a bibliographic record which has several items. In the items table check some checkboxes and play with "select all", "clear all" and the action buttons. Notice that everything works as before. Minor UI regression that must be fixed: there are CSS rules that cause problem. When the action links are displayed or hidden the table is moving up and down. I think the problematic rules are: .btn { padding: 6px 12px; font-size: 12px; } It makes the UI better if I remove them but still get the bumping issue. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168799|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168847&action=edit Bug 37309: Fix behaviour when SeparateHoldings is in use Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168848|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170307&action=edit Bug 37309: Clear itemnumbers array before 'select all' Otherwise the same itemnumber can appear several times in the array. It could be moved to its own bug but this is only code cleaning it seems, there is no impact on the UX Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170309&action=edit Bug 37309: Adjustment for 33526 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Passing QA, we have Owen and Pedro stamps already. Also it will prevent further conflicts with bug 20411. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA Keywords| |RM_priority Summary|Improve Delete and Modify |Improve delete and modify |items links on the biblio |items links on the |detail page |bibliographic detail page --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this makes the tests fail, I am not sure why yet, but can you please check: prove -v xt/find-missing-op-in-forms.t xt/find-missing-op-in-forms.t .. 1..1 not ok 1 - The <form> in the following files are missing it's corresponding op parameter, or op does not start with 'cud-' (see bug 34478) # Failed test 'The <form> in the following files are missing it's corresponding op parameter, or op does not start with 'cud-' (see bug 34478)' # at xt/find-missing-op-in-forms.t line 43. # got: '1' # expected: '0' # $VAR1 = 'koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc:59,69'; # Looks like you failed 1 test of 1. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement improves release notes| |the way batch operation | |controls are dynamically | |generated when the user | |checks one or more | |checkboxes under the | |holdings tab on the | |bibliographic detail page. | |The markup has also been | |updated in order to improve | |consistency in the way the | |controls are styled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.