[Bug 28926] New: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Bug ID: 28926 Summary: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org CC: mtj@kohaaloha.com this bug updates cpanfile for Mojolicious::Plugin::OpenAPI v2.16 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 124256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124256&action=edit Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 to test... - apply patch - build package - confirm in about.pl that minimum versions are updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28800 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- On a ktd:stretch root@kohadevbox:koha(master)$ pmvers Mojolicious::Plugin::OpenAPI 2.16 root@kohadevbox:koha(master)$ pmvers Mojolicious 8.12 root@kohadevbox:koha(master)$ pmvers JSON::Validator 3.14 root@kohadevbox:koha(master)$ pmvers YAML::XS 0.76 root@kohadevbox:koha(master)$ apt-cache policy libjson-validator-perl libjson-validator-perl: Installed: 3.25+dfsg-1+koha3 Candidate: 3.25+dfsg-1+koha3 Version table: *** 3.25+dfsg-1+koha3 500 500 http://debian.koha-community.org/koha-staging dev/main amd64 Packages 100 /var/lib/dpkg/status 0.92+dfsg-1 500 500 http://httpredir.debian.org/debian stretch/main amd64 Packages Why is JSON::Validator 3.14? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #2)
Why is JSON::Validator 3.14?
From IRC: mtj> Joubu: re your question on bz 28926, the package should really be called libjson-validator-perl_3.25+really3.14
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 126438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126438&action=edit Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 to test... - apply patch - build package - confirm in about.pl that minimum versions are updated Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #2)
root@kohadevbox:koha(master)$ apt-cache policy libjson-validator-perl libjson-validator-perl: Installed: 3.25+dfsg-1+koha3 Candidate: 3.25+dfsg-1+koha3 Version table: *** 3.25+dfsg-1+koha3 500 500 http://debian.koha-community.org/koha-staging dev/main amd64 Packages 100 /var/lib/dpkg/status 0.92+dfsg-1 500 500 http://httpredir.debian.org/debian stretch/main amd64 Packages
Why is JSON::Validator 3.14?
the package name has now been updated/corrected to handle deb12 $ apt-cache policy libjson-validator-perl libjson-validator-perl: Installed: 4.99.1+really3.14-koha3 Candidate: 4.99.1+really3.14-koha3 Version table: *** 4.99.1+really3.14-koha3 500 500 http://debian.koha-community.org/koha 20.11/main amd64 Packages 100 /var/lib/dpkg/status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #5)
Pushed to master for 21.11, thanks to everybody involved!
hi, can we get this can be backported thru to 19.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate CC| |fridolin.somers@biblibre.co | |m, | |nick@bywatersolutions.com, | |victor@tuxayo.net, | |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Mason James from comment #7)
(In reply to Jonathan Druart from comment #5)
Pushed to master for 21.11, thanks to everybody involved!
hi, can we get this can be backported thru to 19.11?
CCing RMaints for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- What minimal testing is needed? Must we build packages locally and install? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- IIUC if something goes wrong so will the CI image. And the API tests will catch that so I guess we can backport without worry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |andrew@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.08 released in| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #12 from wainuiwitikapark@catalyst.net.nz --- I will wait until this is pushed to 20.11.x to backport it to 19.11.x.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I have the following conflict with 20.11.x <<<<<<< HEAD requires 'YAML', '0.71'; requires 'YAML::Syck', '0.71'; ||||||| parent of 81ce0e2db5 (Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16) requires 'YAML::XS', '0.67'; ======= requires 'YAML::XS', '0.76';
> 81ce0e2db5 (Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16)
This diff3 conflictstyle tells that 20.11.x has YAML and YAML::Syck which on the next Koha versions were replaced by YAML::XS. Should I just add YAML::XS 0.76 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #14 from Mason James <mtj@kohaaloha.com> --- (In reply to Victor Grousset/tuxayo from comment #13)
I have the following conflict with 20.11.x
<<<<<<< HEAD requires 'YAML', '0.71'; requires 'YAML::Syck', '0.71'; ||||||| parent of 81ce0e2db5 (Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16) requires 'YAML::XS', '0.67'; ======= requires 'YAML::XS', '0.76';
>> 81ce0e2db5 (Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16)
This diff3 conflictstyle tells that 20.11.x has YAML and YAML::Syck which on the next Koha versions were replaced by YAML::XS.
Should I just add YAML::XS 0.76 ?
lets attempt to add this patch without any YAML::* updates first if problems occue with CI testing, we can add 27673 and 22824, or revert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.08 |21.11.00,21.05.08,20.11.15 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
lets attempt to add this patch without any YAML::* updates first
Thanks, it works! :) Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.08,20.11.15 |21.11.00,21.05.08,20.11.15, released in| |19.11.26 Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #16 from wainuiwitikapark@catalyst.net.nz --- Backported to 19.11.x for 19.11.26 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.08,20.11.15, |21.11.00,21.05.08,20.11.15 released in|19.11.26 | --- Comment #17 from wainuiwitikapark@catalyst.net.nz --- Build is failing on 19.11.x, so patch doesn't apply. Please supply a 19.11 patch if you require me to backport it to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31588 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org