[Bug 35535] New: Candcel hold -button does not work in pop-up (Hold found, item is already waiting)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Bug ID: 35535 Summary: Candcel hold -button does not work in pop-up (Hold found, item is already waiting) Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: minna.kivinen@hamk.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When you check in an item having awaiting hold there comes a pop-up window. There is a button saying Cancel hold. This button does not do anything. (you are able to cancel the hold from other hold windows) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Minna Kivinen <minna.kivinen@hamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Candcel hold -button does |Cancel hold -button does |not work in pop-up (Hold |not work in pop-up (Hold |found, item is already |found, item is already |waiting) |waiting) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- This will happen if there are no authorised values in the category HOLD_CANCELLATION, because no select input element will be rendered in this case so the javascript code references an undefined element. This could be made more robust by adding a default reason if the element is missing: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 2abde7f9c5..92a375531e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -1562,7 +1562,8 @@ this.form.submit(); }); $('.cancel-hold').on("click",function(e){ - let cancel_reason = document.getElementById('cancellation-reason').value; + const r = document.getElementById('cancellation-reason'); + let cancel_reason = r ? r.value : 'Manually cancelled'; this.form.cancel_reserve.value = 1; this.form.cancel_reason.value = cancel_reason; this.form.submit(); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Keywords| |RM_priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- We can just not pass NULL and use a blank/empty value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161072&action=edit Bug 35535: Do not pass value of NULL on returns.tt when cancelling hold To test: 1. APPLY PATCH 2. Check in an item having awaiting hold there comes a pop-up window. There is a button saying Cancel hold. 3. Cancel the hold without giving a reason. 4. Check that the hold has been properly canceled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- (In reply to Lucas Gass from comment #3)
Created attachment 161072 [details] [review] Bug 35535: Do not pass value of NULL on returns.tt when cancelling hold
To test: 1. APPLY PATCH 2. Check in an item having awaiting hold there comes a pop-up window. There is a button saying Cancel hold. 3. Cancel the hold without giving a reason. 4. Check that the hold has been properly canceled.
Noting that the case in which this manifests is when there are no authorized values defined for the category of HOLD_CANCELLATION - so delete those before you test this (if you have some defined) :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- With the patch applied and no values in HOLD_CANCELLATION authorized value, when I go to cancel the hold: - There is no cancellation reason dropdown list before the cancel hold button - I can't escape out of the pop-up modal window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #5)
With the patch applied and no values in HOLD_CANCELLATION authorized value, when I go to cancel the hold: - There is no cancellation reason dropdown list before the cancel hold button - I can't escape out of the pop-up modal window
Thanks David, it looks like that happens with or without the patch but let's fix it all here. New patch incoming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161072|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161112&action=edit Bug 35535: Allow for cancellation of holds with or without a reason TO TEST: 1. APPLY PATCH 2. Have at least 1 HOLD_CANCELLATION auth value. 3. Check in a waiting hold and make sure you can cancel a hold when selecting the reason. 4. Also try a cancelling this hold without giving a reason. 5. Delete all HOLD_CANCELLATION auth values. 6. Try checking in another hold, there should be no dropdown for choosing a reason. 7. The hold should cancel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161112|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161113&action=edit Bug 35535: Allow for cancellation of holds with or without a reason TO TEST: 1. APPLY PATCH 2. Have at least 1 HOLD_CANCELLATION auth value. 3. Check in a waiting hold and make sure you can cancel a hold when selecting the reason. 4. Also try a cancelling this hold without giving a reason. 5. Delete all HOLD_CANCELLATION auth values. 6. Try checking in another hold, there should be no dropdown for choosing a reason. 7. The hold should cancel. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Brenda <bowens@washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bowens@washoecounty.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161113|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161449&action=edit Bug 35535: Allow for cancellation of holds with or without a reason TO TEST: 1. Have a waiting hold on a particular barcode 2. Have at least 1 HOLD_CANCELLATION auth value 3. Check in the barcode and try to cancel the hold on the modal while selecting a reason. => SUCCESS: You can cancel a hold when selecting a reason. 4. Repeat 1-3 but not selecting any reason. => SUCCESS: Hold cancelled correctly. 5. Delete all HOLD_CANCELLATION auth values. 6. Repeat Try 1-3 => SUCCESS: No reason displayed => FAIL: Cancelling does nothing. There's an error in the browser inspector 7. Apply this patch 8. Repeat 1-3 => SUCCESS: No reason displayed => SUCCESS: Cancelling works 9. Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit: amended the test plan to make it clearer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> ---
Edit: amended the test plan to make it clearer
Thanks, Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #13 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- *** Bug 36050 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hello all, can this fix please be backported to 23.05.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org