https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #53)

Katrin, Could you have a look at the 4 patches please? They should not introduce any regression. I am wondering if we should not add a confirmation box as the button will sent an email. I also think that the button should not be displayed if the vendor does not have any email address defined, don't you think?

Hi Jonathan, thx for the follow-ups! I will test them later, but they all look good to me and make sense. I was modeling this from the way we send e-mails for claims. I am not against a confirmation box, I can try to take a look at how this is done on other pages. Arguments for showing the button: The user gets an informative message, that they need to edit a vendor contact in order to make it work. Also: I am not sure how to achieve hiding it correctly :( The logic here is not as simple as checking for an email address in the vendor, as there can be multiple contacts and the SendAlerts give priority to the one that is acqprimary and has the right option checked (Take a look at the SQL in SendAlerts). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.