[Bug 9105] New: Moving Z3950 search code to Breeding.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Bug ID: 9105 Summary: Moving Z3950 search code to Breeding.pm Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: m.de.rooy@rijksmuseum.nl Reporter: m.de.rooy@rijksmuseum.nl CC: m.de.rooy@rijksmuseum.nl In order to realize the goals in bug 6536, this patch first moves the z3950 search code in acquisition and cataloging to one place, the Breeding module. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13589&action=edit Patch for 9105 As a first step in realizing the goals of report 6536 (Z3950 Search improvements), this patch moves identical code in acquisition and cataloging to module level. A followup deals with formatting. Note that this patch should not change any behavior. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13590&action=edit Followup for 9105 Remove some debug warnings, fix indentation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- TEST PLAN: Just check some z3950 searches without this patch and with this patch. There should be no behavior changes. Note that the patch touches two places: Cataloging/Z3950 Search and Acquisition, open a basket, add a line with From an external source. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6536 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13589|0 |1 is obsolete| | Attachment #13590|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13593&action=edit Bug 9105: Move Z3950 search code to Breeding module As a first step in realizing the goals of report 6536 (Z3950 Search improvements), this patch moves identical code in acquisition and cataloging to module level. A followup deals with formatting. Note that this patch should not change any behavior. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I did not find any regression -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13594&action=edit Bug 9105: Housekeeping followup Remove some debug warnings, fix indentation Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Great work Marcel! Another SO is welcomed :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13625&action=edit Second (housekeeping) patch Removing some unused variables. Restoring timeout parameter that was only used in cataloging. Small adjustment at the end of the while loop with template vars. Discovered while doing so, that the paging feature needs some further corrections; will propose a patch under a separate report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13625|0 |1 is obsolete| | --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 13625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13625 Second (housekeeping) patch Still see something. Please wait.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13626&action=edit Bug 9105: Second housekeeping followup Removing some unused variables. Restoring timeout parameter that was only used in cataloging. Restoring copyrightdate and editionstatement in row data for template. Small adjustment at the end of the while loop with template vars. Discovered while doing so, that the paging feature needs some further corrections; will propose a patch under a separate report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #6)
Another SO is welcomed :)
Thanks Jonathan for your signing off as Unimarc user. Although moving the code now not really relates to marc flavour, another marc21 signoff is welcome. For future QA it would be better not to squash the three patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13593|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13936&action=edit [SIGNED-OFF] Bug 9105: Move Z3950 search code to Breeding module As a first step in realizing the goals of report 6536 (Z3950 Search improvements), this patch moves identical code in acquisition and cataloging to module level. A followup deals with formatting. Note that this patch should not change any behavior. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I did not find any regression Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13594|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13937&action=edit [SIGNED-OFF] Bug 9105: Housekeeping followup Remove some debug warnings, fix indentation Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13626|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13938&action=edit [SIGNED-OFF] Bug 9105: Second housekeeping followup Removing some unused variables. Restoring timeout parameter that was only used in cataloging. Restoring copyrightdate and editionstatement in row data for template. Small adjustment at the end of the while loop with template vars. Discovered while doing so, that the paging feature needs some further corrections; will propose a patch under a separate report. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com Patch complexity|--- |Medium patch --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- MARC21 user here, looks good to me! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Patch complexity|Medium patch |Small patch QA Contact| |paul.poulain@biblibre.com Severity|enhancement |normal --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * not really an enhancement, changing to "normal" bugfix * koha-qa.pl is OK * I've grepped the moved subs and checked there is a use C4::Breeding instead of C4::Z3950 passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13936|0 |1 is obsolete| | Attachment #13937|0 |1 is obsolete| | Attachment #13938|0 |1 is obsolete| | --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14230&action=edit Bug 9105: Move Z3950 search code to Breeding module As a first step in realizing the goals of report 6536 (Z3950 Search improvements), this patch moves identical code in acquisition and cataloging to module level. A followup deals with formatting. Note that this patch should not change any behavior. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I did not find any regression Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14231&action=edit Bug 9105: Housekeeping followup Remove some debug warnings, fix indentation Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14232&action=edit Bug 9105: Second housekeeping followup Removing some unused variables. Restoring timeout parameter that was only used in cataloging. Restoring copyrightdate and editionstatement in row data for template. Small adjustment at the end of the while loop with template vars. Discovered while doing so, that the paging feature needs some further corrections; will propose a patch under a separate report. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. There is, however, a problem: we do not destroy the ZOOM connection or recordset. A follow-up destroying those would be greatly appreciated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #19)
This patch has been pushed to master.
There is, however, a problem: we do not destroy the ZOOM connection or recordset. A follow-up destroying those would be greatly appreciated.
Patch forthcoming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 14450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14450&action=edit Followup for closing connections Housekeeping: close the results sets and connections from Z3950 searches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14450|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14701&action=edit [SIGNED-OFF] 9105: Followup for closing Zoom connections Housekeeping: close the results sets and connections from Z3950 searches. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14701|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15222&action=edit 9105: Followup for closing Zoom connections Housekeeping: close the results sets and connections from Z3950 searches. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No regression found, all tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|paul.poulain@biblibre.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 8886 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org