[Bug 21783] New: Reindent admin/columns_settings.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Bug ID: 21783 Summary: Reindent admin/columns_settings.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org admin/columns_settings.tt was created with two-space indentation, but coding guidelines require 4. This patch will reindent the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82045&action=edit Bug 21783: Reindent admin/columns_settings.tt This patch reindents admin/columns_settings.tt to use four spaces instead of two for indentation, following coding guidelines. To test, apply the patch and compare the file to master using the -w flag to ignore whitespace. The only changes should appear where lines were added during indentation. Go to Admin -> Columns settings and confirm that everything works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82045|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86789&action=edit Bug 21783: Reindent admin/columns_settings.tt This patch reindents admin/columns_settings.tt to use four spaces instead of two for indentation, following coding guidelines. To test, apply the patch and compare the file to master using the -w flag to ignore whitespace. The only changes should appear where lines were added during indentation. Go to Admin -> Columns settings and confirm that everything works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86789|0 |1 is obsolete| | --- Comment #3 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 88241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88241&action=edit Bug 21783: Reindent admin/columns_settings.tt This patch reindents admin/columns_settings.tt to use four spaces instead of two for indentation, following coding guidelines. To test, apply the patch and compare the file to master using the -w flag to ignore whitespace. The only changes should appear where lines were added during indentation. Go to Admin -> Columns settings and confirm that everything works correctly. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88241|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88288&action=edit Bug 21783: Reindent admin/columns_settings.tt This patch reindents admin/columns_settings.tt to use four spaces instead of two for indentation, following coding guidelines. To test, apply the patch and compare the file to master using the -w flag to ignore whitespace. The only changes should appear where lines were added during indentation. Go to Admin -> Columns settings and confirm that everything works correctly. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org