[Bug 22545] New: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Bug ID: 22545 Summary: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: johanna.raisa@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org Target Milestone: --- When using AggressiveMatchOnISBN or AggressiveMatchOnISSN preferences instead of UseQueryParser the search for duplicates fails. ES don't give any results, it seems that the problem is the query string. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi --- Comment #1 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 86778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86778&action=edit Elastic fix for matching records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #2 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Bug 22545: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES TEST PLAN: - Use Elastic as search engine - Turn off UseQueryParser systempreference - Turn on AggressiveMatchOnISBN systempreference - Stage records with ISBN rule - See that there are no matches - Apply the patch - Stage records again - See that matches are found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #3 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- How does the fix work? The patch commit doesn't explain it, could you add a short description there, too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #4 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Joonas Kylmälä from comment #3)
How does the fix work? The patch commit doesn't explain it, could you add a short description there, too.
When using Elastic the get_matches uses the same search terms as query parser since the Elastic CCL support is lacking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #5 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- What about fixing this part of Elasticsearch CCL support in Koha? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #6 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Joonas Kylmälä from comment #5)
What about fixing this part of Elasticsearch CCL support in Koha?
Yes, that would be the ideal situation. Librarians have learned to search from Zebra with CCL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23322 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- I went about this in a different way on Bug 23322, rather than enabling QueryParser solution I fixed the Non-QP solution Can you check if the patch there solves your issue and makes sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It would be great to get an answer to the above Johanna, I'm very interested to know whether this bug is resolved for you with that alternative implementation or whether we still need to work here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #9 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Nick Clemens from comment #7)
I went about this in a different way on Bug 23322, rather than enabling QueryParser solution I fixed the Non-QP solution
Can you check if the patch there solves your issue and makes sense?
I tested this and it solves my bug, awesome! Your solution makes more sense than mine. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Changing this to a duplicate of bug 23322 then. *** This bug has been marked as a duplicate of bug 23322 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org