[Bug 13036] New: Exclude control columns from sorting on catalog detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Bug ID: 13036 Summary: Exclude control columns from sorting on catalog detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org On the catalog detail page the first column (of checkboxes) and the last column ("Edit") are sortable. They should be excluded from sorting because sorting them is useless. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Exclude control columns |Exclude control columns |from sorting on catalog |from sorting on staff |detail page |client catalog detail page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32038&action=edit Bug 13036 - Exclude control columns from sorting on staff client catalog detail page The checkbox and "edit" column in the table of holdings on the staff client detail page should be excluded from sorting since there is no useful data to sort. This patch does so. To test, view the detail page for a title which has multiple items. Confirm that sorting works correctly. Test under the following conditions: - with the StaffDetailItemSelection system preference enabled and disabled. - as users who do and do not have cataloging item edit privileges -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32038|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32752&action=edit Bug 13036 - Exclude control columns from sorting on staff client catalog detail page The checkbox and "edit" column in the table of holdings on the staff client detail page should be excluded from sorting since there is no useful data to sort. This patch does so. To test, view the detail page for a title which has multiple items. Confirm that sorting works correctly. Test under the following conditions: - with the StaffDetailItemSelection system preference enabled and disabled. - as users who do and do not have cataloging item edit privileges Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32752|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32768&action=edit [PASSED QA] Bug 13036 - Exclude control columns from sorting on staff client catalog detail page The checkbox and "edit" column in the table of holdings on the staff client detail page should be excluded from sorting since there is no useful data to sort. This patch does so. To test, view the detail page for a title which has multiple items. Confirm that sorting works correctly. Test under the following conditions: - with the StaffDetailItemSelection system preference enabled and disabled. - as users who do and do not have cataloging item edit privileges Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as desrcibed, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org