[Bug 21497] New: Correctly format dates for ILL requests in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Bug ID: 21497 Summary: Correctly format dates for ILL requests in OPAC Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de In the OPAC the dates for ill requests are shown unformatted. Dates shoudl be displayed according to the datefomat system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|16.11 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80076&action=edit Bug 21497: Correctly format dates for ILL requests in OPAC This patch updates the opac ILL template to use the $KohaDates plugin for displaying dates. Also updated: - Added "title-string" sorting to allow for correct sorting of dates in the table of requests. - Corrected capitalization as per our capitalization rules. - Added self-closing / to inputs as per coding guidelines. To test, apply the patch and log in to the OPAC as a user who has multiple outstanding ILL requests. - In the table of ILL requests, the "Request placed" and "Last updated" dates should be formatted according to your system's dateformat preference. - Sorting of those columns should work correctly. - View a request and confirm that "Request placed" and "Last updated" dates in this view are also formatted correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80076|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80650&action=edit Bug 21497: Correctly format dates for ILL requests in OPAC This patch updates the opac ILL template to use the $KohaDates plugin for displaying dates. Also updated: - Added "title-string" sorting to allow for correct sorting of dates in the table of requests. - Corrected capitalization as per our capitalization rules. - Added self-closing / to inputs as per coding guidelines. To test, apply the patch and log in to the OPAC as a user who has multiple outstanding ILL requests. - In the table of ILL requests, the "Request placed" and "Last updated" dates should be formatted according to your system's dateformat preference. - Sorting of those columns should work correctly. - View a request and confirm that "Request placed" and "Last updated" dates in this view are also formatted correctly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80650|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80734&action=edit Bug 21497: Correctly format dates for ILL requests in OPAC This patch updates the opac ILL template to use the $KohaDates plugin for displaying dates. Also updated: - Added "title-string" sorting to allow for correct sorting of dates in the table of requests. - Corrected capitalization as per our capitalization rules. - Added self-closing / to inputs as per coding guidelines. To test, apply the patch and log in to the OPAC as a user who has multiple outstanding ILL requests. - In the table of ILL requests, the "Request placed" and "Last updated" dates should be formatted according to your system's dateformat preference. - Sorting of those columns should work correctly. - View a request and confirm that "Request placed" and "Last updated" dates in this view are also formatted correctly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Correctly format dates for |Dates should be correctly |ILL requests in OPAC |formatted for ILL requests | |in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.13 Only pushed date formatting, not string change to avoid translation change. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org