[Bug 25534] New: Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Bug ID: 25534 Summary: Add ability to send an email specifying a reason when canceling a hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105034&action=edit Bug 25534: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105035&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold, not the reason pulldown appears. 8) Select a reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete you authorised values, not the feature is disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105036&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105034|0 |1 is obsolete| | Attachment #105035|0 |1 is obsolete| | Attachment #105036|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105077&action=edit Bug 25534: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105078&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105079&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- On request.pl, the notice doesn't send if you cancel the hold using the big red X button. This is the more obvious way to cancel a hold, so if it doesn't send a notice then folks are going to get confused. Additionally, I've got "<<reserves.cancellation_reason>>" in my notice and it's putting in the authorised value code rather than the description, which is no good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Also need to account for cancelation via pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #7)
On request.pl, the notice doesn't send if you cancel the hold using the big red X button. This is the more obvious way to cancel a hold, so if it doesn't send a notice then folks are going to get confused.
Will fix.
Additionally, I've got "<<reserves.cancellation_reason>>" in my notice and it's putting in the authorised value code rather than the description, which is no good.
I should have specified a TT sample notice in the test plan. Will fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105105&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105106&action=edit Bug 25534: Add reason to pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105077|0 |1 is obsolete| | Attachment #105078|0 |1 is obsolete| | Attachment #105079|0 |1 is obsolete| | Attachment #105105|0 |1 is obsolete| | Attachment #105106|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105108&action=edit Bug 25534: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105109&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', [% hold.cancellation_reason %], 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105110&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105111&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105112&action=edit Bug 25534: Add reason to pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105108|0 |1 is obsolete| | Attachment #105109|0 |1 is obsolete| | Attachment #105110|0 |1 is obsolete| | Attachment #105111|0 |1 is obsolete| | Attachment #105112|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105113&action=edit Bug 25534: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105114&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105115&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105116&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105117&action=edit Bug 25534: Add reason to pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105113|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 105118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105118&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105114|0 |1 is obsolete| | --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 105119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105119&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105115|0 |1 is obsolete| | --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 105120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105120&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105116|0 |1 is obsolete| | --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 105121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105121&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105117|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 105122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105122&action=edit Bug 25534: Add reason to pendingreserves.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105118|0 |1 is obsolete| | --- Comment #27 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 105147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105147&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105119|0 |1 is obsolete| | --- Comment #28 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 105148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105148&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105120|0 |1 is obsolete| | --- Comment #29 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 105149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105149&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105121|0 |1 is obsolete| | --- Comment #30 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 105150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105150&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105122|0 |1 is obsolete| | --- Comment #31 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 105151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105151&action=edit Bug 25534: Add reason to pendingreserves.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches no longer apply cleanly, please rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105147|0 |1 is obsolete| | Attachment #105148|0 |1 is obsolete| | Attachment #105149|0 |1 is obsolete| | Attachment #105150|0 |1 is obsolete| | Attachment #105151|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108476&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108476|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108477&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108478&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108479&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108480&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108481&action=edit Bug 25534: Add reason to pendingreserves.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Doing a first review here: 1) QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc FAIL filters missing_filter at line 36 ( <select name="rank-request" class="rank-request" data-hold-id="[% hold.reserve_id %]">) missing_filter at line 38 ( <input type="hidden" name="rank-request" class="rank-request" value="[% hold.priority | html %]" data-hold-id="[% hold.reserve_id %]">) missing_filter at line 39 ( <select name="rank-request" class="rank-request" disabled="disabled" data-hold-id="[% hold.reserve_id %]">) 2) Unit tests There are changes on the ModReserveCancelAll and Hold:cancel methods. Can we please get some tests for the new behavior? 3) Docs Maybe it would be worth mentioning that this allows to store a cancellation reason in the documentation? (Bug title + description for release notes). Currently only the email functionality is mentioned, but we also have an interesting db change. 4) Constants for translation? + var REASON_LABEL = _("Reason: "); I believe this is not really needed here as the Javascript code is in a tt file and not js. Not a blocker, but was wondering. 5) Sample notice Could we please create a nice sample notice for this? I think it would make using the feature easier on new installations especially since the TT syntax is still a little hard to figure out. As an existing notice also triggers activation, we can't add for existing installations. 6) Authorised value We should add the authorised value to ease use of the feature. I believe this would be save for existing and new installations? Please also add a nice description to the template on what the category is used for (See: /cgi-bin/koha/admin/authorised_values.pl) 7) GUI reserve.pl I think it would be nice if the cancellation reason only activated once a "del" was selected. Otherwise people might expect it to do something without that or expect it to also work when they cancel using "X". moremember.pl/circulation.pl I think for context we should add "Cancellation reason:" here before the pull down too. Why pendingreserves, but not holds queue? pendingreserves: I'd remove the bold and add : (only one string to translate for translators :) ) 8) Possible enhancements I wonder if it would be nice to move the pull downs to a modal dialog later. So it will always show when you decide to cancel something. It would add an additional click, but libraries can opt-in to use the feature and might like the 'confirmation' step that reminds of setting the reason? It also might be nice to haven option to 'not send an email' in some cases. At the moment I think it's always or never? A checkbox for 'send email' might do the job and could be selected/preselected depending on library choice. Overall no big issues - works well! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to send an |Add ability to send an |email specifying a reason |email specifying a reason |when canceling a hold |and store the reason when | |canceling a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds new column release notes| |cancellation_reason to | |holds tables, used to store | |new AV value | |CANCELLATION_REASON. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108477|0 |1 is obsolete| | Attachment #108478|0 |1 is obsolete| | Attachment #108479|0 |1 is obsolete| | Attachment #108480|0 |1 is obsolete| | Attachment #108481|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108746&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108747&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108748&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108749&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108750&action=edit Bug 25534: Add reason to pendingreserves.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108751&action=edit Bug 25534: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108752&action=edit Bug 25534: (QA follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108753&action=edit Bug 25534: (QA follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108754&action=edit Bug 25534: (QA follow-up) Add sample notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108755&action=edit Bug 25534: (QA follow-up) Add label to reason pulldown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108756&action=edit Bug 25534: (QA follow-up) Add AV category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108757&action=edit Bug 25534: (QA follow-up) Add colon to label on pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #39)
Doing a first review here:
1) QA script:
Fixed!
2) Unit tests
Fixed!
3) Docs
Maybe it would be worth mentioning that this allows to store a cancellation reason in the documentation? (Bug title + description for release notes). Currently only the email functionality is mentioned, but we also have an interesting db change.
Added! Feel free to change them, I wasn't sure what I should add really.
4) Constants for translation?
+ var REASON_LABEL = _("Reason: ");
I believe this is not really needed here as the Javascript code is in a tt file and not js. Not a blocker, but was wondering.
I see that model being followed on many templates, added for consistency.
5) Sample notice
Sample notice added!
6) Authorised value
I've added the AV category, but no values. I suppose we could add values for new installations, but I don't think we'd want them for existing installs being upgraded. Let me know what you think.
7) GUI
reserve.pl I think it would be nice if the cancellation reason only activated once a "del" was selected. Otherwise people might expect it to do something without that or expect it to also work when they cancel using "X".
It *does* work when canceling using the "X"! For that reason it is not hidden. If you think it's simpler to not allow a reason when using the X and have it hidden unless one of the pulldowns is marked "del" I can make that change too.
moremember.pl/circulation.pl I think for context we should add "Cancellation reason:" here before the pull down too.
Done!
Why pendingreserves, but not holds queue?
Pending reserves has a cancellation function already while the holds queue does not.
pendingreserves: I'd remove the bold and add : (only one string to translate for translators :) )
Done! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, thx for the follow-ups!
5) Sample notice
Sample notice added!
Can you please also include the translated installers (the .sql files)? We still use them at the moment and not sure when we can get rid of them all yet (for example UNIMARC still needs some work)
6) Authorised value
I've added the AV category, but no values. I suppose we could add values for new installations, but I don't think we'd want them for existing installs being upgraded. Let me know what you think.
Agree!
7) GUI
reserve.pl I think it would be nice if the cancellation reason only activated once a "del" was selected. Otherwise people might expect it to do something without that or expect it to also work when they cancel using "X".
It *does* work when canceling using the "X"! For that reason it is not hidden. If you think it's simpler to not allow a reason when using the X and have it hidden unless one of the pulldowns is marked "del" I can make that change too.
I'll test, but then we should leave as is! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108805&action=edit Bug 25534: (QA follow-up) Add default values for new AV category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108806&action=edit Bug 25534: (QA follow-up) Add sample notices for translators -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Adds new column |This feature allows to give release notes|cancellation_reason to |a reason on cancelling a |holds tables, used to store |hold and to send an email |new AV value |to the patron with the |CANCELLATION_REASON. |information. In order to | |achieve this it adds a new | |column cancellation_reason | |to the reserves and | |old_reserves tables, used | |to store the value form the | |new authorised value | |category | |CANCELLATION_REASON. The | |new notice uses the code | |HOLD_CANCELLATION. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26281 [Bug 26281] Add cancellation reason to holds history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108746|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108891&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108747|0 |1 is obsolete| | --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108892&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108748|0 |1 is obsolete| | --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108893&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108749|0 |1 is obsolete| | --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108894&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108750|0 |1 is obsolete| | --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108895&action=edit Bug 25534: Add reason to pendingreserves.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108751|0 |1 is obsolete| | --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108896&action=edit Bug 25534: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108752|0 |1 is obsolete| | --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108897&action=edit Bug 25534: (QA follow-up) Fix typo Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108753|0 |1 is obsolete| | --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108898&action=edit Bug 25534: (QA follow-up) Unit tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108754|0 |1 is obsolete| | --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108899&action=edit Bug 25534: (QA follow-up) Add sample notice Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108755|0 |1 is obsolete| | --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108900&action=edit Bug 25534: (QA follow-up) Add label to reason pulldown Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108756|0 |1 is obsolete| | --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108901&action=edit Bug 25534: (QA follow-up) Add AV category Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108757|0 |1 is obsolete| | --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108902&action=edit Bug 25534: (QA follow-up) Add colon to label on pendingreserves.pl Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108805|0 |1 is obsolete| | --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108903&action=edit Bug 25534: (QA follow-up) Add default values for new AV category Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108806|0 |1 is obsolete| | --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108904&action=edit Bug 25534: (QA follow-up) Add sample notices for translators Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Why do we have the dropdown list with the reason list at the bottom of this table: https://snipboard.io/i0RrM2.jpg Would not it make sense to have it in the confirmation popup (moved to a modal)? 2. Should not we have the cancellation reason displayed in the "Holds history" view? /cgi-bin/koha/members/holdshistory.pl?borrowernumber=51 3. POD for Koha::Hold->cancel needs to be adjusted 4. de-DE/optional/auth_val.sql contains twice the same insert statements 5. Tests must use build_sample_item (see bug 26250) I will attach a follow-up for 5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108977&action=edit Bug 25534: Use build_sample_item in tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #70)
1. Why do we have the dropdown list with the reason list at the bottom of this table: https://snipboard.io/i0RrM2.jpg Would not it make sense to have it in the confirmation popup (moved to a modal)?
That would make sense to me, but I had not marked it as a blocker (see comment#39)
2. Should not we have the cancellation reason displayed in the "Holds history" view? /cgi-bin/koha/members/holdshistory.pl?borrowernumber=51
I have filed a new bug for this, I think we could easily deal with it separately: Bug 26281 - Add cancellation reason to holds history
3. POD for Koha::Hold->cancel needs to be adjusted
4. de-DE/optional/auth_val.sql contains twice the same insert statements
Oops, thx for catching that.
5. Tests must use build_sample_item (see bug 26250)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108985&action=edit Bug 25534: (QA follow-up) Update Koha::Hold::cancel POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108986&action=edit Bug 25534: (QA follow-up) Removed doubled insert statements in de-DE/optional/auth_val.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about the popup Kyle? I don't think it makes sense to have the dropdown list alone at the bottom at the table. It's not obvious at all that it will be used when the red cross is clicked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #75)
What about the popup Kyle? I don't think it makes sense to have the dropdown list alone at the bottom at the table. It's not obvious at all that it will be used when the red cross is clicked.
I'll take a look and see what I can do! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108990&action=edit Bug 25534: (QA follow-up) Use modal for cancel links, hide reason unless priority is set to 'del' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We don't add the 2 HOLD_CANCELLATION AVs for existing installations, is that expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also wondering, is that ok to send the HOLD_CANCELLATION email to the patron without their agreement? I mean, there is no way for them to stop it if they wish. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #78)
We don't add the 2 HOLD_CANCELLATION AVs for existing installations, is that expected?
That is expected, we don't want to change the behavior of existing installations. If you think we should, I can add that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #81 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #79)
Also wondering, is that ok to send the HOLD_CANCELLATION email to the patron without their agreement? I mean, there is no way for them to stop it if they wish.
We send other emails without an agreement. I think like this is one of a very few that shouldn't be opt out, just as you wouldn't be able to opt out of emails from a store that was sending you a cancellation notice for your order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yup, I am inclined to push as it. We will open follow-up bug reports if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #83 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #81)
(In reply to Jonathan Druart from comment #79)
Also wondering, is that ok to send the HOLD_CANCELLATION email to the patron without their agreement? I mean, there is no way for them to stop it if they wish.
We send other emails without an agreement. I think like this is one of a very few that shouldn't be opt out, just as you wouldn't be able to opt out of emails from a store that was sending you a cancellation notice for your order.
I think it would be a nice enhancement actually - sending emails without agreement can be quite problematic in some contexts. This is an optional feature now, but it's one of the reasons I filed bug 26282. We could also think of making it depending on the holds pickup notice being checked, but a separate option might be better long term. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #85 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #84)
(In reply to Kyle M Hall from comment #81)
(In reply to Jonathan Druart from comment #79)
Also wondering, is that ok to send the HOLD_CANCELLATION email to the patron without their agreement? I mean, there is no way for them to stop it if they wish.
We send other emails without an agreement. I think like this is one of a very few that shouldn't be opt out, just as you wouldn't be able to opt out of emails from a store that was sending you a cancellation notice for your order.
I think it would be a nice enhancement actually - sending emails without agreement can be quite problematic in some contexts. This is an optional feature now, but it's one of the reasons I filed bug 26282. We could also think of making it depending on the holds pickup notice being checked, but a separate option might be better long term.
Without bug 26281 it's not optional. On new install the AVs will get created and clicking the cancel link with a reason will send an email. Does it mean we must implement 26281 for 20.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #86 from Kyle M Hall <kyle@bywatersolutions.com> ---
Without bug 26281 it's not optional. On new install the AVs will get created and clicking the cancel link with a reason will send an email. Does it mean we must implement 26281 for 20.11?
I see no reason not to! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #87 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #86)
Without bug 26281 it's not optional. On new install the AVs will get created and clicking the cancel link with a reason will send an email. Does it mean we must implement 26281 for 20.11?
I see no reason not to!
I actually meant bug 26282. Can you then provide a patch please? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #88 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20453 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #89 from Aleisha Amohia <aleisha@catalyst.net.nz> --- *** Bug 20453 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12656 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #90 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114026&action=edit Bug 25534: Add missing td in tfoot in pendingreserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114026|0 |1 is obsolete| | --- Comment #91 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114027&action=edit Bug 25534: Add missing td in tfoot in pendingreserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27103 [Bug 27103] Adding a hold cancellation reason should not always send a notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26282 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Summary|Add ability to send an |Add ability to specifying |email specifying a reason |and store a reason when |and store the reason when |cancelling a hold |canceling a hold | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This feature allows to give |This new feature adds an release notes|a reason on cancelling a |option to allow staff to |hold and to send an email |add a reason for |to the patron with the |cancellation when |information. In order to |cancelling a hold. |achieve this it adds a new | |column cancellation_reason |The new |to the reserves and |'CANCELLATION_REASON' |old_reserves tables, used |authorized value is used to |to store the value form the |provide a configurable pick |new authorised value |list of reasons. |category | |CANCELLATION_REASON. The |Optionally, the library may |new notice uses the code |choose to define a |HOLD_CANCELLATION. |'HOLD_CANCELLATION' notice | |which will be sent whenever | |a cancellation reason is | |assigned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug description and text for release notes updated to reflect the removal of the sample notice by bug 27103. Full functionality will be restored with bug 26281 and the 21.11.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #91)
Created attachment 114027 [details] [review] Bug 25534: Add missing td in tfoot in pendingreserves
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #94 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114788&action=edit Bug 25534: (QA follow-up 2) Add default values for new AV category Fix wrong conflict resolution -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27331 --- Comment #96 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #95)
Created attachment 114788 [details] [review] Bug 25534: (QA follow-up 2) Add default values for new AV category
Fix wrong conflict resolution
Moved to bug 27331. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #97 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- The Template Toolkit notice example given above had the wrong authorised value category value. This will work: [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'HOLD_CANCELLATION', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "YOUR_CODE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 [Bug 29007] Prompt for reason when cancelling waiting hold via popup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154 [Bug 29154] Add hold cancellation reason to Holds Awaiting Pickup page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org