[Bug 8989] New: Availability facet needs an id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 Priority: P5 - low Change sponsored?: --- Bug ID: 8989 Assignee: oleonard@myacpl.org Summary: Availability facet needs an id Severity: enhancement Classification: Unclassified OS: All Reporter: gaetan.boisson@biblibre.com Hardware: All Status: NEW Version: unspecified Component: Templates Product: Koha Facets in search results (both in the staff interface and in the opac) have ids for css styling, except for the availability facet. It would be useful to have one, especially since this feature seems to have been broken for a while and this would allow us to hide it. Ideally i think we could hide it in the default css in the same patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13146&action=edit Bug 8989 - Availability facet needs an id This patch adds an id to the <li> which contains the "limit to available" facet in the OPAC and staff client. To test, add custom CSS for the staff client and OPAC to hide the id "availability_facet" and confirm that the link is no longer visible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I didn't add anything to the default CSS because as far as I can tell the limit to available feature isn't working perfectly but is working. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 --- Comment #3 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Created attachment 13233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13233&action=edit [SIGNED-OFF] Bug 8989 - Availability facet needs an id This patch adds an id to the <li> which contains the "limit to available" facet in the OPAC and staff client. To test, add custom CSS for the staff client and OPAC to hide the id "availability_facet" and confirm that the link is no longer visible. Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Works as advertised! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13146|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 13233 [details] [SIGNED-OFF] Bug 8989 - Availability facet needs an id Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
tested working, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to 9ace63b 'Bug 9001: Remove Zebraqueue_daemon') a665277 Bug 8989 - Availability facet needs an id - koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc - koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc * koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc OK * koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |3.10 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org