[Bug 8307] New: Set a value for items when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Priority: P5 - low Change sponsored?: --- Bug ID: 8307 Assignee: koha-bugs@lists.koha-community.org Summary: Set a value for items when receiving Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart@biblibre.com Hardware: All Status: NEW Version: unspecified Component: Acquisitions Product: Koha If the system preference AcqCreateItem is "Create an item when ordering", we would like to set a value for items. For example you could define status for the field items.notforloan (995$o for UNIMARC) with 4 = On order, 5: On treatment. Then, it would be great to fill the item field 995$o with "5". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10472&action=edit Bug 8307: Set a value for items when ordering If items are created when ordering, this patch allows to add a value for a field. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemStatusWhenReceived : set "995$o=5" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Alexandre Lengereau <alexandre.lengereau@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.lengereau@biblibr | |e.com --- Comment #2 from Alexandre Lengereau <alexandre.lengereau@biblibre.com> --- SandBox Test result: <h1>Something went wrong !</h1>Applying: Bug 8307: Set a value for items when ordering<br/> Using index info to reconstruct a base tree...<br/> Falling back to patching base and 3-way merge...<br/> Auto-merging installer/data/mysql/sysprefs.sql<br/> CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql<br/> Auto-merging installer/data/mysql/updatedatabase.pl<br/> CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl<br/> Failed to merge in the changes.<br/> Patch failed at 0001 Bug 8307: Set a value for items when ordering<br/> When you have resolved this problem run git am --resolved.<br/> If you would prefer to skip this patch, instead run git am --skip.<br/> To restore the original branch and stop patching run git am --abort.<br/> Bug 8307 - Set a value for items when receiving<br/> <br/> Bug 8307: Set a value for items when ordering<br/> Apply? [yn] <br/> Patch left in /tmp/Bug-8307-Set-a-value-for-items-when-ordering-K_sCQB.patch<br/> <br/>=== translation installation ===<br/> If you use this system for the 1st time, you may find usefull to reach the wiki page http://wiki.koha-community.org/wiki/Sandboxes to have some information about those results, to check if everything went well & if you can test the patch properly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10472|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11379&action=edit Bug 8307: Set a value for items when ordering Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11379|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 11525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11525&action=edit Bug 8307: Set a value for items when ordering If items are created when ordering, this patch allows to add a value for a field. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemStatusWhenReceived : set "995$o=5" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5 Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: I am just having doubts over the form of the preference. Filling in something like 952x=9 and parsing that. Could you please send a mail to the dev list and acquire some community consensus about this unusual form? Thank you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13463&action=edit Bug 8307: Set a value for subfields when receiving If items are created when ordering, this patch allows to add a value for some items subfields. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5. The subfield b have to contain 'foo bar' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- This new patch change the format of the syspref (subfield_1=value_1|...|subfield_n=value_n) Like this, it is possible to set any items subfields (not specific to the status value). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9088 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Jonathan: Could you have a look at 9088 too. That report deals with default values for AcqCreateItem=cataloging or receiving. Thanks Marcel -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.durand@unilim.fr --- Comment #10 from Frederic Durand <frederic.durand@unilim.fr> --- Applying: Bug 8307: Set a value for subfields when receiving Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 Bug 8307: Set a value for subfields when receiving When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 8307 - Set a value for items when receiving -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #11 from Frederic Durand <frederic.durand@unilim.fr> --- Sorry was a bit quick for copy the error message, i tried to test this patch on sandbox, it did not work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13463|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16235&action=edit Bug 8307: Set a value for subfields when receiving If items are created when ordering, this patch allows to add a value for some items subfields. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5. The subfield b have to contain 'foo bar' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16250&action=edit Bug 8307: Set a value for subfields when receiving If items are created when ordering, this patch allows to add a value for some items subfields. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5. The subfield b have to contain 'foo bar' Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16250|0 |1 is obsolete| | --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18605&action=edit Bug 8307: Set a value for subfields when receiving If items are created when ordering, this patch allows to add a value for some items subfields. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5. The subfield b have to contain 'foo bar' Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Two simple merge conflicts resolved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18606&action=edit Bug 8307: Set a value for subfields when receiving If items are created when ordering, this patch allows to add a value for some items subfields. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5. The subfield b have to contain 'foo bar' Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Forgot: 3.11 -> 3.13 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Tested this under AcqCreateItem=ordering. And verified that it did not change the items with AcqCreateItem=receiving. It works (I only struggled with booksellerid 952e that was overwritten later on). [We use AcqCreateItem=cataloging and have a different use on 952e. Probably, this field should not be in the marc 952 tag, as it is now.] No complaints from qa-tools. But I do have my doubts over this feature. First, AcqItemSetSubfieldsWhenReceived only works for AcqCreateItem=ordering. This should be noted more clearly in the pref description. What about setting an item value for AcqCreateItem=receiving or cataloging btw? Second, it looks like you want to update some status in the acquisition process and you implemented it in a perhaps somewhat unusual way that makes completely different applications possible. I am afraid that it could make code maintenance more difficult in the long run. Added a small followup for the split statement. Setting the status to Passed QA. I am not blocking this patch, but leave the final comment to RM. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18606|0 |1 is obsolete| | --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18607&action=edit Bug 8307: Set a value for subfields when receiving If items are created when ordering, this patch allows to add a value for some items subfields. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5. The subfield b have to contain 'foo bar' Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18608&action=edit Bug 8307: QA Followup for finishreceive.pl Only split the expression a=b on the first = sign. Tested with the very unlikely z=x=1 :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, I have been following this bug as it's an interesting feature I get asked about a lot. I am not sure I understand your concerns:
First, AcqItemSetSubfieldsWhenReceived only works for AcqCreateItem=ordering. >This should be noted more clearly in the pref description. What about setting an item value for AcqCreateItem=receiving or cataloging btw?
Not sure how it could work for those settings - it seems to me that in these cases we either have no item to change or no defined event to trigger the change? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #23 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #22)
First, AcqItemSetSubfieldsWhenReceived only works for AcqCreateItem=ordering. >This should be noted more clearly in the pref description. What about setting an item value for AcqCreateItem=receiving or cataloging btw?
Not sure how it could work for those settings - it seems to me that in these cases we either have no item to change or no defined event to trigger the change?
When you set it to receiving, you do have a new item. In that case it would function as a sort of default. So perhaps we should not do that? Trigger would be the same (confirm receive). In another way for cataloging, I opened another report once for default values for fund and itemtype (does not apply anymore). Just curious if we can get a broader application for this pref. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think dealing with defaults is maybe better done in a different place as this is focused on changing existing values from one value to another. For the use case you gave maybe it would work to use default values in the frameworks? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #25 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #24)
Hm, I think dealing with defaults is maybe better done in a different place as this is focused on changing existing values from one value to another. For the use case you gave maybe it would work to use default values in the frameworks?
Yes for the item values that probably would be enough. (Not for the fund and itemtype.) So it may be hard to widen the scope. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Chris Rohde <crohde@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10043 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #26 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! Being able to set item record values during receiving will be well received, but I must say that I am not a fan of how things have drifted: - It would be better to refer to item fields by their names, not how they happen to be mapped in a MARC framework. (By the way, I have an itch to stamp out the use of AddItemFromMarc and ModItemFromMarc, replacing it with direct calls to AddItem / ModItem, or their eventual DBIC equivalents. A helper routine to map a MARC field to an item should be used only when necessary -- during record import, primarily, and not item record editing). - It's not great that depending on what stage of the process you're dealing with, the configuration interface is either a syspref or the MARC frameworks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the syspref description is a bit confusing: AcqItemSetSubfieldsWhenReceived Set subfields for item when items are created when receiving (e.g. o=5|a="foo bar") Shouldn't it be something like: Update subfields in items on receive when items are created when ordering (e.g. o=5|a="foo bar") -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11237 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11237 | --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #27)
I think the syspref description is a bit confusing:
AcqItemSetSubfieldsWhenReceived Set subfields for item when items are created when receiving (e.g. o=5|a="foo bar")
Shouldn't it be something like: Update subfields in items on receive when items are created when ordering (e.g. o=5|a="foo bar")
Yes, you are right. I proposed a patch on bug 11237. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12557 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org