https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144018&action=edit Bug 32254: Add 'page-section' to various tools pages This patch adds a .page-section div to various pages in the tools section in order to provide a consistent page structure. Also changed: Corrected a couple of templates which were missing some <tr> tags. This patch includes indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Tools -> Access files - Tools -> HTML customizations - Additional contents, news or pages-- all use the same template. - Check the list of existing entries. - Tools -> Batch extend due dates - Choose a set of criteria that will return results and click "Continue". - Check the list of checkouts to be updated. - Tools -> Batch patron modification - Submit a batch of patrons for modification. - Check the list of patrons to be modified. - Tools -> Upload patron images - Upload one or more patron images - Check the view of results - Tools -> Upload - Upload a file and view the results, or perform a search and check the view of results. - Tools -> Patron card creator -> New patron card batch. - Submit a set of patrons and check the display of patrons in the resulting batch. - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - Confirm that the table of data looks correct -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144018|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144025&action=edit Bug 32254: Add 'page-section' to various tools pages This patch adds a .page-section div to various pages in the tools section in order to provide a consistent page structure. Also changed: Corrected a couple of templates which were missing some <tr> tags. This patch includes indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Tools -> Access files - Tools -> HTML customizations - Additional contents, news or pages-- all use the same template. - Check the list of existing entries. - Tools -> Batch extend due dates - Choose a set of criteria that will return results and click "Continue". - Check the list of checkouts to be updated. - Tools -> Batch patron modification - Submit a batch of patrons for modification. - Check the list of patrons to be modified. - Tools -> Upload patron images - Upload one or more patron images - Check the view of results - Tools -> Upload - Upload a file and view the results, or perform a search and check the view of results. - Tools -> Patron card creator -> New patron card batch. - Submit a set of patrons and check the display of patrons in the resulting batch. - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - Confirm that the table of data looks correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- A follow-up is also needed for the "Older transactions" section:* 1. Go to Transaction history for 2. In the "Older transactions" section enter a from date, for example: 1 November 2022 3. Click "Display" 4. Result: table (with no entries) has no page-section * Need to enable the UseCashRegisters system preference and add a cash register -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144074&action=edit Bug 32254: (follow-up) Add missing div around "Older transactions" To test: - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - In the "Older transactions" section, submit start and end dates which will return results. - The table of results should be styled correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144025|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 144079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144079&action=edit Bug 32254: Add 'page-section' to various tools pages This patch adds a .page-section div to various pages in the tools section in order to provide a consistent page structure. Also changed: Corrected a couple of templates which were missing some <tr> tags. This patch includes indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Tools -> Access files - Tools -> HTML customizations - Additional contents, news or pages-- all use the same template. - Check the list of existing entries. - Tools -> Batch extend due dates - Choose a set of criteria that will return results and click "Continue". - Check the list of checkouts to be updated. - Tools -> Batch patron modification - Submit a batch of patrons for modification. - Check the list of patrons to be modified. - Tools -> Upload patron images - Upload one or more patron images - Check the view of results - Tools -> Upload - Upload a file and view the results, or perform a search and check the view of results. - Tools -> Patron card creator -> New patron card batch. - Submit a set of patrons and check the display of patrons in the resulting batch. - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - Confirm that the table of data looks correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144074|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 144081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144081&action=edit Bug 32254: (follow-up) Add missing div around "Older transactions" To test: - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - In the "Older transactions" section, submit start and end dates which will return results. - The table of results should be styled correctly. Signed-off-by: David <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144081|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144091&action=edit Bug 32254: (follow-up) Add missing div around "Older transactions" To test: - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - In the "Older transactions" section, submit start and end dates which will return results. - The table of results should be styled correctly. Signed-off-by: David <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.