http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 11499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11499&action=edit Bug 8454 - Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. Currently, when you click "Holds to pull" from the Circulation menu, the only thing that you see is a white screen and a side navigation bar that says "Refine Results". Since there appear to be no results to refine, the holds to pull list appears completely empty. Staff have to know to click "Submit" on the "Refine Results" form to get anything. I propose that we have the "run_report" flag set to ON for the initial load. The report uses the default 2 days mentioned in the "Refine Results" form, so there is continuity across the board. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I figured the "if ( 1 ){}" approach would be the easiest, as it meant the fewest changes to the code, but I'm certainly up for alternative strategies :). I'm not sure that I understand your conditional here though. Doesn't that say that $run_report will be 1, if $input->param('run_report') isn't set/defined? Otherwise, if it is defined...then it will just be the param that's passed, which amounts to 1 anyway? In either case, it seems inevitable that the page will load the report upon page load, which I'm proposing is a good idea. However, in that event, how would it be possible for someone to load this page without running the report, as you suggest? (In reply to comment #4)

QA Comments:

Your patch is the same as if ( 1 ){}

I think a better way to do this is : my $run_report = ( not defined $input->param('run_report') ) ? 1 : $input->param('run_report');

If someone wants to load this page without running the report it is possible.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11499|0 |1 is obsolete| | --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Created attachment 12181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12181&action=edit Bug 8454 - Show pull list on load. Otherwise, it looks like the pull list is empty - Amended Ahh, I see your logic now. Here's an amended patch that uses your idea. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12181|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12182&action=edit Bug 8454 - Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. Currently, when you click "Holds to pull" from the Circulation menu, the only thing that you see is a white screen and a side navigation bar that says "Refine Results". Since there appear to be no results to refine, the holds to pull list appears completely empty. Staff have to know to click "Submit" on the "Refine Results" form to get anything. I propose that we have the "run_report" flag set to ON for the initial load. The report uses the default 2 days mentioned in the "Refine Results" form, so there is continuity across the board. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * very tiny patch, no side effect risk, just a default value added * koha-qa.pl OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.