https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 208214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208214&action=edit Bug 43829: Add toolbar to patron list detail page This patch adds a toolbar to the patron list detail page. The patch also makes some markup corrections for validity, and removes some unused JavaScript from the main patron lists page. To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - View the list and test the actions in the toolbar: New, Edit, and Delete. - Test the markup changes by clicking the "Add multiple patrons" link to confirm that the textarea is shown, and the "Search for patrons" link to hide it. - On the list of patron lists, test Actions -> Delete list to verify that the confirmation is shown. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 --- Comment #2 from Community Sandboxes <sandboxes@biblibre.com> --- Created attachment 208306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208306&action=edit Bug 43829: Add toolbar to patron list detail page This patch adds a toolbar to the patron list detail page. The patch also makes some markup corrections for validity, and removes some unused JavaScript from the main patron lists page. To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - View the list and test the actions in the toolbar: New, Edit, and Delete. - Test the markup changes by clicking the "Add multiple patrons" link to confirm that the textarea is shown, and the "Search for patrons" link to hide it. - On the list of patron lists, test Actions -> Delete list to verify that the confirmation is shown. Sponsored-by: Athens County Public Libraries Signed-off-by: Gretchen Maxeiner <maxeinergl@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu --- Comment #4 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Looks good. Everything works correctly and the new toolbar options are a nice improvement. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208306|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Failed QA --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, The new toolbar on the patron list page shows 'Edit list' and 'Delete list' to staff who don't own the list. The patron lists page hides both for lists shared by someone else, but the toolbar doesn't. 'Delete list' then fails with an error page, and 'Edit list' lets a non-owner change someone else's list. To reproduce: 1) Go to Tools > Patron lists (http://localhost:8081/cgi-bin/koha/patron_lists/lists.pl), click 'New patron list', enter 'Shared list' as the name, tick 'Shared' and click 'Save' 2) Go to patron Tanya Daniels (http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=3), click 'More' > 'Set permissions', tick 'catalogue' and, under 'tools', 'manage_patron_lists', then save 3) Click 'Change password' and set username 'tanya' and password 'Kohatest123' 4) Log out, log in as tanya, go to Tools > Patron lists and confirm 'Shared list' has no 'Edit' or 'Delete' under 'Actions' 5) Click 'Shared list' and confirm the toolbar shows 'Edit list' and 'Delete list' 6) Click 'Delete list', confirm, and see the error page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- This is not something new from my patch, but looking at it now I wonder... Should a non-owner be allowed to add patrons to someone else's list? Currently we don't do a check in the template or the script. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 211462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211462&action=edit Bug 43829: (follow-up) Hide edit and delete button if user doesn't own the list -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43829 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a toolbar release notes| |to the patron list detail | |page so that a user with | |the correct permission can | |easily edit or delete the | |list from this page. The | |patch also makes some | |markup corrections for | |validity, and removes some | |unused | |JavaScript from the main | |patron lists page. -- You are receiving this mail because: You are watching all bug changes.