[Bug 14389] New: Editing a syspref in a textarea does not ednable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Bug ID: 14389 Summary: Editing a syspref in a textarea does not ednable the Save button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com At least sometimes, editing a syspref in a textarea (like e.g. opaccredits) will not make the "Save" button active. I have observed this on 3.18.7. Others have possibly sighted it on master too. Workaround: Add and remove one char from a text input to activate the button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jweaver@bywatersolutions.co |ity.org |m --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Jesse Weaver asked that this be assigned to him. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Editing a syspref in a |Editing a syspref in a |textarea does not ednable |textarea does not enable |the Save button |the Save button -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 40156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40156&action=edit Bug 14389 - Editing a syspref in a textarea does not enable the Save button Test plan: 1. Navigate to the "opaccredits" syspref (or any other textarea, i.e., "Click to Edit", syspref) in the system preferences editor. 2. Change its contents, by either pasting or typing. The field may not be marked as modified, even after you click outside the box. 3. Apply the patch. 4. Reload the page and try again; either pasting or typing should mark the field as changed and allow you to save. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11464 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Hi Jesse, I tested this, and the following action: highlighting everything, and deleting the contents of a syspref (this case, nologininstructions) the button didn't activate when I might have expected it to. I can get around it by adding and deleting a space in the syspref. Also, we're still stuck with the "middle click paste" from linux not triggering the save button, but that might be an even more distant edge case. Is this something we can fix? This patch is certainly an improvement over the current behaviour. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Hi Jesse, I just tried this with only 'input', and it seems to work in every way I'd expect it to, including the linux middle button paste - what do you think? Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- actually forget I said anything :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- oy. it's getting too late for me, comment 4 stands, actually. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40156|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40182&action=edit Bug 14389 - Editing a syspref in a textarea does not enable the Save button Test plan: 1. Navigate to the "opaccredits" syspref (or any other textarea, i.e., "Click to Edit", syspref) in the system preferences editor. 2. Change its contents, by either pasting or typing. The field may not be marked as modified, even after you click outside the box. 3. Apply the patch. 4. Reload the page and try again; either pasting or typing should mark the field as changed and allow you to save. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Note: "even after you click outside the box." => This works even without this patch. With this patch, the "save" button is enabled when a change is made on input and textarea without having to click outside of the element. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40182|0 |1 is obsolete| | --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 40344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40344&action=edit Bug 14389 - Editing a syspref in a textarea does not enable the Save button Test plan: 1. Navigate to the "opaccredits" syspref (or any other textarea, i.e., "Click to Edit", syspref) in the system preferences editor. 2. Change its contents, by either pasting or typing. The field may not be marked as modified, even after you click outside the box. 3. Apply the patch. 4. Reload the page and try again; either pasting or typing should mark the field as changed and allow you to save. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40344|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 40345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40345&action=edit Bug 14389 - Editing a syspref in a textarea does not enable the Save button Test plan: 1. Navigate to the "opaccredits" syspref (or any other textarea, i.e., "Click to Edit", syspref) in the system preferences editor. 2. Change its contents, by either pasting or typing. The field may not be marked as modified, even after you click outside the box. 3. Apply the patch. 4. Reload the page and try again; either pasting or typing should mark the field as changed and allow you to save. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Confirmed working for normal input, paste and middle-click paste in Chrome and Firefox in Linux. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40345|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40361&action=edit Bug 14389 - Editing a syspref in a textarea does not enable the Save button Test plan: 1. Navigate to the "opaccredits" syspref (or any other textarea, i.e., "Click to Edit", syspref) in the system preferences editor. 2. Change its contents, by either pasting or typing. The field may not be marked as modified, even after you click outside the box. 3. Apply the patch. 4. Reload the page and try again; either pasting or typing should mark the field as changed and allow you to save. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Confirmed working for normal input, paste and middle-click paste in Chrome and Firefox in Linux. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, should this be Passed QA? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #12 from David Cook <dcook@prosentient.com.au> --- I was thinking about this bug recently. I suppose it still won't work for WYSIWYG editors in some cases, but that's not a community concern (yet). I'll have to do some thinking on that one when I have time... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #12)
I was thinking about this bug recently.
I suppose it still won't work for WYSIWYG editors in some cases, but that's not a community concern (yet). I'll have to do some thinking on that one when I have time...
Oh wait. Liz pointed out that it's on "input" and not on "change". It might work for WYSIWYG editors as well! I'll look into this! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #11)
Hi Jonathan, should this be Passed QA?
No, I signed it off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #13)
(In reply to David Cook from comment #12)
I was thinking about this bug recently.
I suppose it still won't work for WYSIWYG editors in some cases, but that's not a community concern (yet). I'll have to do some thinking on that one when I have time...
Oh wait. Liz pointed out that it's on "input" and not on "change".
It might work for WYSIWYG editors as well! I'll look into this!
(In reply to David Cook from comment #13)
(In reply to David Cook from comment #12)
I was thinking about this bug recently.
I suppose it still won't work for WYSIWYG editors in some cases, but that's not a community concern (yet). I'll have to do some thinking on that one when I have time...
Oh wait. Liz pointed out that it's on "input" and not on "change".
It might work for WYSIWYG editors as well! I'll look into this!
So I've been doing lots of research (as I do). Locally, I've added TinyMCE to some system preferences which use HTML. (I plan to upstream it when I find some time.) I've just been using "keyup" to detect changes to the TinyMCE editor, and then I trigger a "keyup" on the original textarea so that the "Save..." button activates. It works OK for the most part, but I've noticed a few issues like changes from the editor buttons not being detected or pastes not made through Ctrl+V or Ctrl+Ins. Anyway... using "input" for an event listener has been absolutely great with Firefox and Chrome. It fires for so many different events. It's so awesome! Unfortunately, IE doesn't support the "input" event for elements that are "contenteditable". TinyMCE uses a "contenteditable" body element within an iframe element to create its editor, so IE and TinyMCE are just not going to be friends with the "input" event. But it looks like the "input" event works well with IE otherwise, so yay! Just adding this info here in case its somehow relevant to people in the future (plus it's also just painfully interesting to know). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Sorry to spam people, but here are some relevant links for what I was talking about: https://developer.mozilla.org/en-US/docs/Web/Events/input https://connect.microsoft.com/IE/feedbackdetail/view/794285 Not actually relevant to this bug report though... just making that clear. This patch looks super good :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11584 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11584 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11584 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40361|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 40772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40772&action=edit Bug 14389 - Editing a syspref in a textarea does not enable the Save button Test plan: 1. Navigate to the "opaccredits" syspref (or any other textarea, i.e., "Click to Edit", syspref) in the system preferences editor. 2. Change its contents, by either pasting or typing. The field may not be marked as modified, even after you click outside the box. 3. Apply the patch. 4. Reload the page and try again; either pasting or typing should mark the field as changed and allow you to save. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Confirmed working for normal input, paste and middle-click paste in Chrome and Firefox in Linux. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #20 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.09 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #21 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org