[Bug 9752] New: Set marcflavor = normarc when NORMARC is chosen in the web installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Bug ID: 9752 Summary: Set marcflavor = normarc when NORMARC is chosen in the web installer Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus@enger.priv.no Reporter: magnus@enger.priv.no CC: gmcharlt@gmail.com I thought this was already being done, but alas. If you do a web install in Norwegian and choose NORMARC as the MARC dialect, the marcflavor syspref gets set to MARC21, not NORMARC. I hope the solution can be as simple as including something like this in the SQL file for the default NORMARC framework: UPDATE systempreferences SET value = 'normarc' WHERE variable = 'marcflavor'; But I will have to look at the order in which things are loaded by the webinstaller first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 15909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15909&action=edit Bug 9752 - Set marcflavour = NORMARC when NORMARC is chosen Currently, if you install the Norwegian translations and run through the web installer in Norwegian, choosing NORMARC as you marcflavour, the marcflavour syspref is set to MARC21. To test: - Apply the patch - Install nb-NO - Run through the web installer, choosing nb-NO as the language - Choose NORMARC as the MARC dialect - When the web installer is done, check the value of the marcflavour syspref. It should be NORMARC, not MARC21. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- So the solution was not in the SQL file as I initially thought, but in Installer.pm. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15909|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 16080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16080&action=edit Bug 9752: Set marcflavour to NORMARC when NORMARC is chosen Currently, if you install the Norwegian translations and run through the web installer in Norwegian, choosing NORMARC as you marcflavour, the marcflavour syspref is set to MARC21. To test: - Apply the patch - Install nb-NO - Run through the web installer, choosing nb-NO as the language - Choose NORMARC as the MARC dialect - When the web installer is done, check the value of the marcflavour syspref. It should be NORMARC, not MARC21. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16080|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17052&action=edit [PASSED QA] Bug 9752: Set marcflavour to NORMARC when NORMARC is chosen Currently, if you install the Norwegian translations and run through the web installer in Norwegian, choosing NORMARC as you marcflavour, the marcflavour syspref is set to MARC21. To test: - Apply the patch - Install nb-NO - Run through the web installer, choosing nb-NO as the language - Choose NORMARC as the MARC dialect - When the web installer is done, check the value of the marcflavour syspref. It should be NORMARC, not MARC21. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Did a regression test installing UNIMARC too. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9752 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Magnus Enger <magnus@enger.priv.no> --- Works as expected (tested with packages built off current master). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org