[Bug 20097] New: marc2dcxml croaks on format dc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Bug ID: 20097 Summary: marc2dcxml croaks on format dc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Format 'dc' could be accepted by C4::Record::marc2dcxml since there is a xslt. I saw this error in my log: The format argument (dc) not accepted. Please pass a valid format (oaidc, srwdc, or rdfdc) at opac/opac-export.pl line 80. [Probably from Googlebot or so.] I would prefer to see 'Format not supported' rather than 'Internal server error'. We can achieve that by using the same regex in opac-export.pl and Record.pm. Note that I skip catalogue/export.pl here, since it has no fallback at the end, and will not be called by bots. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 71018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71018&action=edit Bug 20097: Use same regex in marc2dcxml and opac-export This regex allows: dc, oaidc, srwdc, and rdfdc. Test plan: [1] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=dc [2] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=oaidc [3] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=nodc. This one should trigger a not-supported message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen@inlibro.com --- Comment #2 from Maksim Sen <maksim.sen@inlibro.com> --- Hey Marcel, When I tried to get to the links you put out, I got to an Error 404 in Koha (after changing the server and bibnumbers of course), with and without the patch. I accessed the links directly, do I need to access your through another page? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Maksim Sen from comment #2)
Hey Marcel,
When I tried to get to the links you put out, I got to an Error 404 in Koha (after changing the server and bibnumbers of course), with and without the patch.
I accessed the links directly, do I need to access your through another page?
Thx for testing, Maksim. Testing these links should be enough. They still work for me. Please paste the URL you tried. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72528&action=edit Bug 20097: Follow-up with a unit test kshell prove -v t/db_dependent/Record.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- I tested these on a reset_all, kohadevbox. localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=dc localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=oaidc localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=srwdc localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=rdfdc localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=nodc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71018|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72529&action=edit Bug 20097: Use same regex in marc2dcxml and opac-export This regex allows: dc, oaidc, srwdc, and rdfdc. Test plan: [1] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=dc [2] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=oaidc [3] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=nodc. This one should trigger a not-supported message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72528|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72530&action=edit Bug 20097: Follow-up with a unit test kshell prove -v t/db_dependent/Record.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72529|0 |1 is obsolete| | Attachment #72530|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72537&action=edit Bug 20097: Use same regex in marc2dcxml and opac-export This regex allows: dc, oaidc, srwdc, and rdfdc. Test plan: [1] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=dc [2] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=oaidc [3] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=nodc. This one should trigger a not-supported message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72538&action=edit Bug 20097: Follow-up with a unit test kshell prove -v t/db_dependent/Record.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org