[Bug 36490] New: Correct tab-switching keyboard shortcut for header search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Bug ID: 36490 Summary: Correct tab-switching keyboard shortcut for header search forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35850 Bug 35850 changed the markup of the header search forms but didn't update the JS in staff-global.js to match those changes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 [Bug 35850] Use template wrapper for tabs: Header search forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164265&action=edit Bug 36490: Correct tab-switching keyboard shortcut for header search forms This patch updates staff-global.js so that we correctly define the keyboard shortcuts for search header tabs following the switch to using the WRAPPER for tabs in Bug 35850. To test, apply the patch clear your browser cache if necessary. - Go to the staff interface. - Test each keyboard shortcut to confirm that the header search tabs activate correctly: - Check in: Alt-r - Renew: Alt-w - Search: Alt-q - Check out: Alt-u - Test that the keyboard shortcut takes you to the correct page if the header search form doesn't exist on the page, e.g. the Authorities home page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrewfh@dubcolib.org --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- This works except for one small thing. The alt-u shortcut for checkout only works if my cursor is not in the search box. If my cursor is in the search box and waiting for me to type, alt-u inputs a "¨". If my cursor if not in the box, alt-u correctly takes me to checkout. Otherwise all of these work, regardless of where my cursor is. I'm on a Mac, if that matters. So I was pressing Option instead of Alt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Andrew Fuerste-Henry from comment #2)
This works except for one small thing. The alt-u shortcut for checkout only works if my cursor is not in the search box.
I think this is the same as before the patch. Could you check in a pre-Bug 35850 installation, e.g. https://intranet.bywatersolutions.com/ ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164265|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 164300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164300&action=edit Bug 36490: Correct tab-switching keyboard shortcut for header search forms This patch updates staff-global.js so that we correctly define the keyboard shortcuts for search header tabs following the switch to using the WRAPPER for tabs in Bug 35850. To test, apply the patch clear your browser cache if necessary. - Go to the staff interface. - Test each keyboard shortcut to confirm that the header search tabs activate correctly: - Check in: Alt-r - Renew: Alt-w - Search: Alt-q - Check out: Alt-u - Test that the keyboard shortcut takes you to the correct page if the header search form doesn't exist on the page, e.g. the Authorities home page. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 --- Comment #5 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Owen Leonard from comment #3)
(In reply to Andrew Fuerste-Henry from comment #2)
This works except for one small thing. The alt-u shortcut for checkout only works if my cursor is not in the search box.
I think this is the same as before the patch. Could you check in a pre-Bug 35850 installation, e.g. https://intranet.bywatersolutions.com/ ?
Confirmed this issue exists before your patch when using Chrome on Mac. As such, I've signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Patch doesn't apply --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Owen, this one no longer applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164300|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 165008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165008&action=edit Bug 36490: Correct tab-switching keyboard shortcut for header search forms This patch updates staff-global.js so that we correctly define the keyboard shortcuts for search header tabs following the switch to using the WRAPPER for tabs in Bug 35850. To test, apply the patch clear your browser cache if necessary. - Go to the staff interface. - Test each keyboard shortcut to confirm that the header search tabs activate correctly: - Check in: Alt-r - Renew: Alt-w - Search: Alt-q - Check out: Alt-u - Test that the keyboard shortcut takes you to the correct page if the header search form doesn't exist on the page, e.g. the Authorities home page. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165008|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165024&action=edit Bug 36490: Correct tab-switching keyboard shortcut for header search forms This patch updates staff-global.js so that we correctly define the keyboard shortcuts for search header tabs following the switch to using the WRAPPER for tabs in Bug 35850. To test, apply the patch clear your browser cache if necessary. - Go to the staff interface. - Test each keyboard shortcut to confirm that the header search tabs activate correctly: - Check in: Alt-r - Renew: Alt-w - Search: Alt-q - Check out: Alt-u - Test that the keyboard shortcut takes you to the correct page if the header search form doesn't exist on the page, e.g. the Authorities home page. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working nicely, thanks Owen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35850 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Bug 36490 depends on bug 35850, which changed state. Bug 35850 Summary: Use template wrapper for tabs: Header search forms https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix. Nothing to change in the Koha manual. I added the Alt-W that was missing and updated the formatting. https://gitlab.com/koha-community/koha-manual/-/merge_requests/894 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org