https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 48765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48765&action=edit Add spelling exclusion parameter -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |QA tools |and plumbing | Product|Koha |Project Infrastructure Version|master |unspecified CC| |chris@bigballofwax.co.nz QA Contact|testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48765|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 48782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48782&action=edit Bug 16003: Add spelling exclusion switch. TEST PLAN --------- Run on a test file with isnt. -- spelling error Patch Run on the same file with a -s -- spelling tests skipped. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 48791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48791&action=edit Bug 16003 - Add exceptions file logic to codespell call I created an exceptions file by: $ git grep "isnt(" | cut -f2- -d":" | sort -u > ~/qa-test-tools/spelling.exceptions I then patched QohA/File.pm to include a -x extension to the codespell call if the exceptions file existed. TEST PLAN --------- In your koha development directory apply bug 15870 run the koha qa test tools -- you will get a complaint about isnt(, likely because it is tokenized as isnt. apply this patch to your qa test tools run the koha qa test tools on bug 15870 again -- spelling issue passed! THIS IS A COUNTER PATCH. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Mark, Please have a look at this patch. I think it does what you want but in a more flexible way: we won't blacklist an entire file, but just a line. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48791|0 |1 is obsolete| | Attachment #48839|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 48864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48864&action=edit [SIGNED-OFF] Bug 16003: Add exception pattern list for codespell checks The 'isnt' Test::More subroutine should not be considered as a failure by the codespell check. To avoid that this patch introduces the concept of "exception patterns" for this check. NOTE: This is better than introducing a '-x {exception file}', because it dynamically handles the isnt( issue. If other similar function name issues arise in the future, modifications to the i_dont_fail_spelling.pl file and the exception list can be made. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.