https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 --- Comment #1 from Adam Styles <adam.styles@esa.edu.au> --- Created attachment 148519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148519&action=edit Bug 33304: Report schedule form time input element attribute type changed to improves valid time value entry I offer an enhancement for the task scheduler form: /cgi-bin/koha/tools/scheduler.pl via scheduler.tt The time input element currently has an 'text' value for type attribute. This requires a user to enter a valid time string for any scheduled report manually which is no fun. I have created patch in scheduler.tt that changes the type attribute value from 'text' to 'time' which makes the input of valid time easy. This change leveraged standard web form principles of html5 and would be compatible with any modern browser such as chrome, firefox and safari. To test: 1) login to koha instance 2) navigate to report module from home page 3) create test report with basic action and save. (no actual run of report is requires, simply need to save with valid syntax) ... SELECT id FROM biblio_metadata LIMIT 1 ... 4) Press 'Schedule' icon from nav options 5) Enter relevant time value for schedule in 'time' input element which now has type 'time' attribute 3.00 pm, added easily. 6) Enter valid future date 7) Enter valid email address and press 'Save' 8) SIGN OFF -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 Adam Styles <adam.styles@esa.edu.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148519|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 149252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149252&action=edit Bug 33304: Report schedule form time input element attribute type changed to improves valid time value entry I offer an enhancement for the task scheduler form: /cgi-bin/koha/tools/scheduler.pl via scheduler.tt The time input element currently has an 'text' value for type attribute. This requires a user to enter a valid time string for any scheduled report manually which is no fun. I have created patch in scheduler.tt that changes the type attribute value from 'text' to 'time' which makes the input of valid time easy. This change leveraged standard web form principles of html5 and would be compatible with any modern browser such as chrome, firefox and safari. To test: 1) login to koha instance 2) navigate to report module from home page 3) create test report with basic action and save. (no actual run of report is requires, simply need to save with valid syntax) ... SELECT id FROM biblio_metadata LIMIT 1 ... 4) Press 'Schedule' icon from nav options 5) Enter relevant time value for schedule in 'time' input element which now has type 'time' attribute 3.00 pm, added easily. 6) Enter valid future date 7) Enter valid email address and press 'Save' 8) SIGN OFF Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 --- Comment #4 from Adam Styles <adam.styles@esa.edu.au> --- Hi David, Thanks for the sign off! I know I would use this in my daily drive Koha once implemented. 8-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a bit of an odd one for me. It looks like the form is not really up to 'Koha standard' to begin with. Meaning that time and date should not really be separate input fields. It should all be handled by he datepicker. Also: with the change, it doesn't work according to the TimeFormat preference still. In my case I see PM/AM times now, while TimeFormat is set to 24 hours. This makes me unsure of if it's better than before or not. Adam, would you be interested in having a look in how to use Flatpickr to achieve the same goal here? An example for date and time can be seen in circulation when specifying a due date for example. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 --- Comment #7 from Adam Styles <adam.styles@esa.edu.au> --- Hi Katrin, Thanks for this feed back. I did not take into account any system preferences that might be applied to date/time format for this solution. I am happy to investigate how I can use Flatpickr to rebuild this. Thanks for the 'circulation' example. Stay tuned for a new patch soon. Thanks. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 Adam Styles <adam.styles@esa.edu.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37402 Resolution|--- |MOVED Status|Failed QA |RESOLVED --- Comment #9 from Adam Styles <adam.styles@esa.edu.au> --- Hi All, I am now resolving this bug issue in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37402 Thanks. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37402 [Bug 37402] Task scheduling fails if you don't use the correct time format -- You are receiving this mail because: You are watching all bug changes.